fix: remove unused variables and biome-ignore suppressions#1955
Open
Felipeness wants to merge 1 commit intoopenstatusHQ:mainfrom
Open
fix: remove unused variables and biome-ignore suppressions#1955Felipeness wants to merge 1 commit intoopenstatusHQ:mainfrom
Felipeness wants to merge 1 commit intoopenstatusHQ:mainfrom
Conversation
Remove dead code that was being suppressed by biome-ignore lint/correctness/noUnusedVariables and noUnusedImports directives. Instead of suppressing the lint warning, the unused code is deleted. - Remove unused `stringToArrayProcess` function from monitors/validation.ts - Remove unused `req` parameter from cron function and all 6 call sites - Remove now-unnecessary `NextRequest` import from _cron.ts Ref openstatusHQ#826
|
@Felipeness is attempting to deploy a commit to the OpenStatus Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Focused first step toward resolving #826. This PR removes
biome-ignore lint/correctness/noUnusedVariablessuppressions by deleting the underlying dead code instead of silencing the lint rule.packages/db/src/schema/monitors/validation.ts: Remove unusedstringToArrayProcessfunction (empty body, had a TODO but was never implemented or called)apps/web/src/app/api/checker/cron/_cron.ts: Remove unusedreqparameter from thecronfunction signature, along with the now-unnecessaryNextRequestimportapps/web/src/app/api/checker/cron/{1m,5m,10m,30m,30s,1h}/route.ts: Stop passingreqtocron()since the parameter was removedWhat's NOT in this PR
The
examples.tsfile inpackages/tinybird/src/audit-log/also hasnoUnusedVariablessuppressions, but those are on intentionally-defined example/scratch functions with commented-out calls — removing them would defeat the file's purpose. Skipped to keep this PR conservative.Other biome-ignore categories (
noArrayIndexKey,useExhaustiveDependencies,noForEach, etc.) will follow in separate PRs to keep reviews small and focused.Test plan
reqparameter was never read insidecron())validation.tsstill exports all needed schemas (the removed function was dead code with an empty body)