Fix plugin manager handling of editable packages (#1802)

Author: user202729

news.d/bugfix/1802.ui.md

@@ -0,0 +1 @@
+Make the plugin manager handle some exceptional cases.

plover/gui_qt/plugins_manager.py

@@ -12,6 +12,7 @@
     QInputDialog,
 )
 
+from plover import log
 from plover.gui_qt.tool import Tool
 from plover.gui_qt.info_browser import InfoBrowser
 from plover.gui_qt.plugins_manager_ui import Ui_PluginsManager
@@ -109,7 +110,7 @@ def handle_selection_change(self):
         if current_item is None:
             return
         metadata = self._get_state(current_item.row()).metadata
-        if metadata is None:
+        if metadata is None or metadata.name is None:
             return
         prologue = "<h1>%s (%s)</h1>" % (
             html.escape(metadata.name),
@@ -145,8 +146,13 @@ def restart(self):
             os.execv(args[0], args)
 
     def _update_packages(self):
-        self._packages.update()
-        self._packages_updated.emit()
+        try:
+            self._packages.update()
+            self._packages_updated.emit()
+        except BaseException:
+            # gui_qt/main.py sets sys.excepthook, but this function is run in a thread
+            # so it doesn't apply. We catch exceptions manually.
+            log.error("Error in updating packages", exc_info=sys.exc_info())
 
     def _clear_info(self):
         self.info.setHtml("")

plover/plugins_manager/registry.py

@@ -143,6 +143,7 @@ def update(self):
                 pkg.available = metadata
                 if (
                     pkg.current
+                    and pkg.current.version is not None
                     and pkg.current.parsed_version < pkg.latest.parsed_version
                 ):
                     pkg.status = "outdated"