Skip to content

Could you provide an interface to inject a amdZip or ZipEntry? #3

@ChristianJunghans

Description

@ChristianJunghans

Hi,

I am using your library to parse a manifest and I already have a zip because the apk is uploaded into a service. So I create the zip on the fly from the postet data.

currently I do this:

var admZip = require('adm-zip');
var ApkReader = require('adbkit-apkreader');

var zip = new admZip(blob);
var reader = new ApkReader(null);
reader.zip = zip;
var manifest = reader.readManifestSync();

This works but as soon as you change something internally it will break.

So I suggest to add an optional parameter zip to the readManifestSync function. If it is set, the function could read the provided zip if not the one of the class.

Regards
Christian

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions