Conversation
error: ‘void QCheckBox::stateChanged(int)’ is deprecated: Use checkStateChanged() instead [-Werror=deprecated-declarations]
…de for now, don't care much This reverts commit 433d6c6. There is no plain libicu18n.so ``` $ ls -la /opt/Qt/6.11.0/gcc_64/lib/libicui18n.so* lrwxrwxrwx 1 root root 18 Mar 18 06:34 /opt/Qt/6.11.0/gcc_64/lib/libicui18n.so.73 -> libicui18n.so.73.2 -rwxr-xr-x 1 root root 4477136 Mar 18 06:34 /opt/Qt/6.11.0/gcc_64/lib/libicui18n.so.73.2 $ ls -la /opt/Qt/6.5.2/gcc_64/lib/libicui18n.so* lrwxrwxrwx 1 root root 18 Jul 8 2023 /opt/Qt/6.5.2/gcc_64/lib/libicui18n.so -> libicui18n.so.56.1 lrwxrwxrwx 1 root root 18 Jul 8 2023 /opt/Qt/6.5.2/gcc_64/lib/libicui18n.so.56 -> libicui18n.so.56.1 -rwxr-xr-x 1 root root 3368288 Jul 8 2023 /opt/Qt/6.5.2/gcc_64/lib/libicui18n.so.56.1 ```
…WebView "", which already has a layout ((null):0, (null)) auto* hLayout = new QHBoxLayout(this); // <-- passes `this` as parent, sets layout on PreviewWebView mainLayout->addLayout(hLayout); Passing this to QHBoxLayout(this) immediately sets hLayout as the layout of the PreviewWebView widget. But mainLayout was already set as its layout on line 180 via setLayout(mainLayout). Qt then warns because you're trying to assign a second layout to the same widget. The fix is to not pass this — just create the layout without a parent and let mainLayout->addLayout(hLayout) own it
…d signal of openstudio::LocationView::unnamed ((null):0, (null)) Calling disconnect() with no arguments is a "wildcard disconnect" that disconnects all signals — including Qt's internal destroyed signal, which Qt uses for its own cleanup. Qt warns when that happens. The fix is simply to remove the explicit disconnect() call — Qt automatically disconnects everything when an object is deleted.
…ebView "", which already has a layout ((null):0, (null))
…onsole + it's left aligned by default
…rt grey, but apparently Qt 6.11 changed its behavior
jmarrec
commented
Mar 30, 2026
Comment on lines
604
to
+616
| set(QT_ICU_LIBS | ||
| ${QT_ICU} | ||
| ${QT_ICUDATA} | ||
| ${QT_ICUUC} | ||
| ) | ||
| "${QT_INSTALL_DIR}/lib/libicui18n.so.73.2" | ||
| "${QT_INSTALL_DIR}/lib/libicuuc.so.73.2" | ||
| "${QT_INSTALL_DIR}/lib/libicudata.so.73.2" | ||
| ) | ||
| # Ensure each ICU library exists | ||
| foreach(lib IN LISTS QT_ICU_LIBS) | ||
| if(NOT EXISTS "${lib}") | ||
| message(FATAL_ERROR "Qt ICU library not found: ${lib}") | ||
| elseif(IS_SYMLINK "${lib}") | ||
| message(FATAL_ERROR "Qt ICU library is a symlink, expected a real file: ${lib}") | ||
| endif() | ||
| endforeach() |
Collaborator
Author
There was a problem hiding this comment.
This isn't great to have it harcoded but I'm not sure a GLOB is a better idea.
TODO: temporary, pending a new release of aqtinstall after 3.3.0, need to download a fix, download.qt.io changed the directory structure for Qt 6.11.0 on windows: * Issue: miurahr/aqtinstall#1007 * Fixed via miurahr/aqtinstall#1000
jmarrec
added
Pull Request - Ready for CI
Collaborator
Author
|
@macumber CI is green, if you can review that'd be great. |
jmarrec
commented
Apr 9, 2026
Comment on lines
+435
to
+439
| # TODO: temporary, pending a new release after 3.3.0, need to download a fix, download.qt.io changed the directory structure for Qt 6.11.0 on windows: | ||
| # * Issue: https://github.com/miurahr/aqtinstall/issues/1007 | ||
| # * Fixed via https://github.com/miurahr/aqtinstall/pull/1000 | ||
| # pip install aqtinstall | ||
| pip install git+https://github.com/miurahr/aqtinstall.git@master |
Collaborator
Author
There was a problem hiding this comment.
Had to pull aqtinstall from master for now.
macumber
reviewed
Apr 12, 2026
Collaborator
|
@jmarrec this is great, merge away when ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.