fix vivaldi test being stuck on startup

Author: tophf

src/background/common.js

@@ -42,20 +42,19 @@ export let WRBTest = __.BUILD !== 'firefox' && CHROME &&
     return res;
   });
 
-export let isVivaldi = !!(browserWindows && CHROME) && (async () => {
-  const wnd = (await browserWindows.getAll())[0] ||
-    await new Promise(resolve => browserWindows.onCreated.addListener(function onCreated(w) {
-      browserWindows.onCreated.removeListener(onCreated);
-      resolve(w);
-    }));
-  isVivaldi = !!(wnd && (wnd.vivExtData || wnd.extData));
-  return isVivaldi;
-})();
-
 export let bgBusy = global[k_busy] = (_ =>
   Object.assign(new Promise(cb => (_ = cb)), {[kResolve]: _})
 )();
 
+export let isVivaldi, vivaldiTest;
+if (__.BUILD !== 'firefox' && CHROME && browserWindows) {
+  vivaldiTest = (async (wnd = browserWindows.getLastFocused()) => (
+    isVivaldi = !!((wnd = await wnd) && (wnd.vivExtData || wnd.extData))
+  ));
+} else {
+  isVivaldi = false;
+}
+
 bgPreInit.push(WRBTest);
 bgBusy.then(() => {
   bgBusy = null;

src/background/set-client-data.js

@@ -3,7 +3,7 @@ import {API} from '@/js/msg-api';
 import * as prefs from '@/js/prefs';
 import {FIREFOX} from '@/js/ua';
 import {isDark, setSystemDark} from './color-scheme';
-import {bgBusy, dataHub, isVivaldi, WRB, WRBTest} from './common';
+import {bgBusy, dataHub, isVivaldi, vivaldiTest, WRB, WRBTest} from './common';
 import {stateDB} from './db';
 import {ownPagesCommitted} from './navigation-manager';
 import makePopupData from './popup-data';
@@ -81,7 +81,7 @@ export default async function setClientData({
   const jobs = /** @namespace StylusClientData */ Object.assign({
     apply: styleMan.getSectionsByUrl.call({sender}, pageUrl, {init: true}),
     dark: isDark,
-    favicon: FIREFOX || isVivaldi,
+    favicon: FIREFOX || (isVivaldi ?? vivaldiTest()),
     prefs: nondefaults,
     tabId: tabId ?? -1,
     [kBadFavs]: (page === 'edit' || page === 'install-usercss' || page === 'manage')

src/background/token-manager.js

@@ -6,7 +6,7 @@ import * as URLS from '@/js/urls';
 import {clamp, getHost} from '@/js/util';
 import {browserWindows} from '@/js/util-webext';
 import launchWebAuthFlow from 'webext-launch-web-auth-flow';
-import {isVivaldi} from './common';
+import {isVivaldi, vivaldiTest} from './common';
 
 const AUTH = {
   dropbox: {
@@ -193,7 +193,7 @@ async function authUser(keys, name, interactive = false, hooks = null) {
 }
 
 async function authUserMV2(url, interactive, redirectUri) {
-  alwaysUseTab ??= await isVivaldi;
+  alwaysUseTab ??= isVivaldi ?? await vivaldiTest();
   const width = clamp(screen.availWidth - 100, 400, 800);
   const height = clamp(screen.availHeight - 100, 200, 800);
   const wnd = !alwaysUseTab && await browserWindows.getLastFocused();