feat(sdk): Move to rewrap v2 request/response format #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If these changes look good, signoff on them with: If they aren't any good, please remove them with: |
X-Test Failure Resultsopentdf-sdk-lib |
X-Test Failure Resultsopentdf-sdk-lib |
* - Pin `@bufbuild/buf` and `@bufbuild/protoc-gen-es` dependencies to specific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`. * - Pin `@bufbuild/buf` and `@bufbuild/protoc-gen-es` dependencies to specific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`. * Add `obligations` and `rootCerts` attributes to test fixtures and mock data. Signed-off-by: Elizabeth Healy <[email protected]>
Signed-off-by: Elizabeth Healy <[email protected]>
Signed-off-by: Elizabeth Healy <[email protected]>
* - Pin `@bufbuild/buf` and `@bufbuild/protoc-gen-es` dependencies to specific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`. * - Pin `@bufbuild/buf` and `@bufbuild/protoc-gen-es` dependencies to specific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`. * Add `obligations` and `rootCerts` attributes to test fixtures and mock data. * Add `getRootCertsFromNamespace` function and include headers initialization in `authProvider` * Add input validation for `getRootCertsFromNamespace` and basic unit tests Signed-off-by: Elizabeth Healy <[email protected]>
* feat(core): initial obligations support in rewrap flow * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * wip Signed-off-by: jakedoublev <[email protected]> * more wip * rm unused import * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * lint fix Signed-off-by: jakedoublev <[email protected]> * tests Signed-off-by: jakedoublev <[email protected]> * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * move file * tdf3 client * cleanup * obligations method on opentdf reader classes * requiredObligations on DecoratedReadableStream in tdf3 * wip: fetch decision if obligations haven't been set on reader * wip * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * bugfix in case of no data attributes leading to no obligations Signed-off-by: jakedoublev <[email protected]> * working state Signed-off-by: jakedoublev <[email protected]> * fix Signed-off-by: jakedoublev <[email protected]> * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * fix comments * rm example web app hardcoded attributes and obligations * unit tests for getRequiredObligations * improve nullish operators * cleanup * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * improvements * fix * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * improve log * put back package.json changes * pr feedback Signed-off-by: jakedoublev <[email protected]> * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * rm rewrap header for obligations over legacy http for older platforms --------- Signed-off-by: jakedoublev <[email protected]> Signed-off-by: Elizabeth Healy <[email protected]>
* chore(main): release sdk 0.5.0 * Update dependencies --------- Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]>
…l/go versions (#767) * add a workflow to update the pbs * trigger on PR * correct platform location * add gh token to env * remove extra file after use * detect changes on regen * test with latest version * remove, test changes * test for signed commits * try with api * push the new branch * use a shorter file name in the message * fix for non existing files * run slightly after midnight to avoid queues Signed-off-by: Elizabeth Healy <[email protected]>
Signed-off-by: Elizabeth Healy <[email protected]>
Signed-off-by: Elizabeth Healy <[email protected]>
Signed-off-by: Elizabeth Healy <[email protected]>
Signed-off-by: Elizabeth Healy <[email protected]>
Signed-off-by: Elizabeth Healy <[email protected]>
…763) Bumps [playwright](https://github.com/microsoft/playwright) to 1.56.1 and updates ancestor dependency [@playwright/test](https://github.com/microsoft/playwright). These dependencies need to be updated together. Updates `playwright` from 1.50.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.50.1...v1.56.1) Updates `@playwright/test` from 1.50.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.50.1...v1.56.1) --- updated-dependencies: - dependency-name: playwright dependency-version: 1.56.1 dependency-type: indirect - dependency-name: "@playwright/test" dependency-version: 1.56.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.3.6 to 6.4.1. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/[email protected]/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 6.4.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]>
Signed-off-by: Elizabeth Healy <[email protected]>
Signed-off-by: Elizabeth Healy <[email protected]>
Signed-off-by: Elizabeth Healy <[email protected]>
Bumps [playwright](https://github.com/microsoft/playwright) and [@playwright/test](https://github.com/microsoft/playwright). These dependencies needed to be updated together. Updates `playwright` from 1.50.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.50.1...v1.56.1) Updates `@playwright/test` from 1.50.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.50.1...v1.56.1) --- updated-dependencies: - dependency-name: playwright dependency-version: 1.56.1 dependency-type: direct:development - dependency-name: "@playwright/test" dependency-version: 1.56.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]>
elizabethhealy
force-pushed
the
DSPX-1781-use-v2-rewrap
branch
from
ae82fc7 to
347302e
Compare
elizabethhealy
changed the title
X-Test Failure Reportopentdf-sdk-lib |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the rewrap request/response format from v1 (deprecated) to v2 (bulk-style). The changes update the SDK to use protobuf-based request/response structures while maintaining backward compatibility through an upgrade function. The implementation doesn't introduce actual bulk support but adopts the bulk-style format to align with ACP requirements.
Key Changes
- Replaced JSON-based rewrap requests with protobuf
UnsignedRewrapRequeststructures - Updated rewrap response handling to process
RewrapResponsewith nested result structures - Added
upgradeRewrapResponseV1function to handle backward compatibility with v1 responses
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/tests/server.ts | Updated mock KAS server to parse/generate v2 protobuf rewrap requests/responses |
| lib/tdf3/src/tdf.ts | Converted TDF3 rewrap logic to use protobuf request format and handle v2 response structure |
| lib/src/utils.ts | Added upgradeRewrapResponseV1 helper function for v1-to-v2 response migration |
| lib/src/nanotdf/Client.ts | Updated NanoTDF client to build protobuf rewrap requests and process v2 responses |
| lib/src/access/access-rpc.ts | Enhanced error handling with new handleRpcRewrapError and handleRpcRewrapErrorString functions |
| .github/workflows/format.yaml | Commented out workflow trigger (likely temporary for development) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
pflynn-virtru
approved these changes
Oct 24, 2025
eugenioenko
reviewed
Oct 28, 2025
eugenioenko
reviewed
Oct 28, 2025
eugenioenko
reviewed
Oct 28, 2025
eugenioenko
reviewed
Oct 28, 2025
eugenioenko
reviewed
Oct 28, 2025
eugenioenko
reviewed
Oct 28, 2025
eugenioenko
approved these changes
Oct 28, 2025
elizabethhealy
added a commit
that referenced
this pull request
Oct 29, 2025
* feat: Certificates & Obligations (#755) * - Pin `@bufbuild/buf` and `@bufbuild/protoc-gen-es` dependencies to specific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`. * - Pin `@bufbuild/buf` and `@bufbuild/protoc-gen-es` dependencies to specific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`. * Add `obligations` and `rootCerts` attributes to test fixtures and mock data. Signed-off-by: Elizabeth Healy <[email protected]> * feat: upgrade tdf clients to rewrap v2 proto structure Signed-off-by: Elizabeth Healy <[email protected]> * updates to match go behavior Signed-off-by: Elizabeth Healy <[email protected]> * feat: Get Namespace (#756) * - Pin `@bufbuild/buf` and `@bufbuild/protoc-gen-es` dependencies to specific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`. * - Pin `@bufbuild/buf` and `@bufbuild/protoc-gen-es` dependencies to specific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`. * Add `obligations` and `rootCerts` attributes to test fixtures and mock data. * Add `getRootCertsFromNamespace` function and include headers initialization in `authProvider` * Add input validation for `getRootCertsFromNamespace` and basic unit tests Signed-off-by: Elizabeth Healy <[email protected]> * feat(sdk): initial obligations support in rewrap flow (#748) * feat(core): initial obligations support in rewrap flow * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * wip Signed-off-by: jakedoublev <[email protected]> * more wip * rm unused import * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * lint fix Signed-off-by: jakedoublev <[email protected]> * tests Signed-off-by: jakedoublev <[email protected]> * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * move file * tdf3 client * cleanup * obligations method on opentdf reader classes * requiredObligations on DecoratedReadableStream in tdf3 * wip: fetch decision if obligations haven't been set on reader * wip * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * bugfix in case of no data attributes leading to no obligations Signed-off-by: jakedoublev <[email protected]> * working state Signed-off-by: jakedoublev <[email protected]> * fix Signed-off-by: jakedoublev <[email protected]> * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * fix comments * rm example web app hardcoded attributes and obligations * unit tests for getRequiredObligations * improve nullish operators * cleanup * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * improvements * fix * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * improve log * put back package.json changes * pr feedback Signed-off-by: jakedoublev <[email protected]> * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * rm rewrap header for obligations over legacy http for older platforms --------- Signed-off-by: jakedoublev <[email protected]> Signed-off-by: Elizabeth Healy <[email protected]> * chore: release sdk 0.5.0 (#658) * chore(main): release sdk 0.5.0 * Update dependencies --------- Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]> * feat(ci): Add a workflow to update the generated code for new protocol/go versions (#767) * add a workflow to update the pbs * trigger on PR * correct platform location * add gh token to env * remove extra file after use * detect changes on regen * test with latest version * remove, test changes * test for signed commits * try with api * push the new branch * use a shorter file name in the message * fix for non existing files * run slightly after midnight to avoid queues Signed-off-by: Elizabeth Healy <[email protected]> * 🤖 🎨 Autoformat Signed-off-by: Elizabeth Healy <[email protected]> * handle rewrap response Signed-off-by: Elizabeth Healy <[email protected]> * formatting Signed-off-by: Elizabeth Healy <[email protected]> * passing unit tests Signed-off-by: Elizabeth Healy <[email protected]> * format Signed-off-by: Elizabeth Healy <[email protected]> * chore(docs): bump playwright and @playwright/test in /web-app/tests (#763) Bumps [playwright](https://github.com/microsoft/playwright) to 1.56.1 and updates ancestor dependency [@playwright/test](https://github.com/microsoft/playwright). These dependencies need to be updated together. Updates `playwright` from 1.50.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.50.1...v1.56.1) Updates `@playwright/test` from 1.50.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.50.1...v1.56.1) --- updated-dependencies: - dependency-name: playwright dependency-version: 1.56.1 dependency-type: indirect - dependency-name: "@playwright/test" dependency-version: 1.56.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]> * chore(docs): bump vite from 6.3.6 to 6.4.1 in /web-app (#764) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.3.6 to 6.4.1. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/[email protected]/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 6.4.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]> * v1 backwards compatability Signed-off-by: Elizabeth Healy <[email protected]> * error handling Signed-off-by: Elizabeth Healy <[email protected]> * cleanup Signed-off-by: Elizabeth Healy <[email protected]> * chore(docs): bump playwright and @playwright/test in /web-app (#775) Bumps [playwright](https://github.com/microsoft/playwright) and [@playwright/test](https://github.com/microsoft/playwright). These dependencies needed to be updated together. Updates `playwright` from 1.50.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.50.1...v1.56.1) Updates `@playwright/test` from 1.50.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.50.1...v1.56.1) --- updated-dependencies: - dependency-name: playwright dependency-version: 1.56.1 dependency-type: direct:development - dependency-name: "@playwright/test" dependency-version: 1.56.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]> * suggestions --------- Signed-off-by: Elizabeth Healy <[email protected]> Signed-off-by: jakedoublev <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Paul Flynn <[email protected]> Co-authored-by: jakedoublev <[email protected]> Co-authored-by: Jake Van Vorhis <[email protected]> Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]>
elizabethhealy
added a commit
that referenced
this pull request
Oct 29, 2025
* feat(sdk): Move to rewrap v2 request/response format (#774) * feat: Certificates & Obligations (#755) * - Pin `@bufbuild/buf` and `@bufbuild/protoc-gen-es` dependencies to specific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`. * - Pin `@bufbuild/buf` and `@bufbuild/protoc-gen-es` dependencies to specific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`. * Add `obligations` and `rootCerts` attributes to test fixtures and mock data. Signed-off-by: Elizabeth Healy <[email protected]> * feat: upgrade tdf clients to rewrap v2 proto structure Signed-off-by: Elizabeth Healy <[email protected]> * updates to match go behavior Signed-off-by: Elizabeth Healy <[email protected]> * feat: Get Namespace (#756) * - Pin `@bufbuild/buf` and `@bufbuild/protoc-gen-es` dependencies to specific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`. * - Pin `@bufbuild/buf` and `@bufbuild/protoc-gen-es` dependencies to specific versions. - Update copyright notices in `http_pb.ts` and `validate_pb.ts`. * Add `obligations` and `rootCerts` attributes to test fixtures and mock data. * Add `getRootCertsFromNamespace` function and include headers initialization in `authProvider` * Add input validation for `getRootCertsFromNamespace` and basic unit tests Signed-off-by: Elizabeth Healy <[email protected]> * feat(sdk): initial obligations support in rewrap flow (#748) * feat(core): initial obligations support in rewrap flow * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * wip Signed-off-by: jakedoublev <[email protected]> * more wip * rm unused import * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * lint fix Signed-off-by: jakedoublev <[email protected]> * tests Signed-off-by: jakedoublev <[email protected]> * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * move file * tdf3 client * cleanup * obligations method on opentdf reader classes * requiredObligations on DecoratedReadableStream in tdf3 * wip: fetch decision if obligations haven't been set on reader * wip * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * bugfix in case of no data attributes leading to no obligations Signed-off-by: jakedoublev <[email protected]> * working state Signed-off-by: jakedoublev <[email protected]> * fix Signed-off-by: jakedoublev <[email protected]> * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * fix comments * rm example web app hardcoded attributes and obligations * unit tests for getRequiredObligations * improve nullish operators * cleanup * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * improvements * fix * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * improve log * put back package.json changes * pr feedback Signed-off-by: jakedoublev <[email protected]> * 🤖 🎨 Autoformat Signed-off-by: jakedoublev <[email protected]> * rm rewrap header for obligations over legacy http for older platforms --------- Signed-off-by: jakedoublev <[email protected]> Signed-off-by: Elizabeth Healy <[email protected]> * chore: release sdk 0.5.0 (#658) * chore(main): release sdk 0.5.0 * Update dependencies --------- Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]> * feat(ci): Add a workflow to update the generated code for new protocol/go versions (#767) * add a workflow to update the pbs * trigger on PR * correct platform location * add gh token to env * remove extra file after use * detect changes on regen * test with latest version * remove, test changes * test for signed commits * try with api * push the new branch * use a shorter file name in the message * fix for non existing files * run slightly after midnight to avoid queues Signed-off-by: Elizabeth Healy <[email protected]> * 🤖 🎨 Autoformat Signed-off-by: Elizabeth Healy <[email protected]> * handle rewrap response Signed-off-by: Elizabeth Healy <[email protected]> * formatting Signed-off-by: Elizabeth Healy <[email protected]> * passing unit tests Signed-off-by: Elizabeth Healy <[email protected]> * format Signed-off-by: Elizabeth Healy <[email protected]> * chore(docs): bump playwright and @playwright/test in /web-app/tests (#763) Bumps [playwright](https://github.com/microsoft/playwright) to 1.56.1 and updates ancestor dependency [@playwright/test](https://github.com/microsoft/playwright). These dependencies need to be updated together. Updates `playwright` from 1.50.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.50.1...v1.56.1) Updates `@playwright/test` from 1.50.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.50.1...v1.56.1) --- updated-dependencies: - dependency-name: playwright dependency-version: 1.56.1 dependency-type: indirect - dependency-name: "@playwright/test" dependency-version: 1.56.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]> * chore(docs): bump vite from 6.3.6 to 6.4.1 in /web-app (#764) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.3.6 to 6.4.1. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/[email protected]/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 6.4.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]> * v1 backwards compatability Signed-off-by: Elizabeth Healy <[email protected]> * error handling Signed-off-by: Elizabeth Healy <[email protected]> * cleanup Signed-off-by: Elizabeth Healy <[email protected]> * chore(docs): bump playwright and @playwright/test in /web-app (#775) Bumps [playwright](https://github.com/microsoft/playwright) and [@playwright/test](https://github.com/microsoft/playwright). These dependencies needed to be updated together. Updates `playwright` from 1.50.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.50.1...v1.56.1) Updates `@playwright/test` from 1.50.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.50.1...v1.56.1) --- updated-dependencies: - dependency-name: playwright dependency-version: 1.56.1 dependency-type: direct:development - dependency-name: "@playwright/test" dependency-version: 1.56.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]> * suggestions --------- Signed-off-by: Elizabeth Healy <[email protected]> Signed-off-by: jakedoublev <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Paul Flynn <[email protected]> Co-authored-by: jakedoublev <[email protected]> Co-authored-by: Jake Van Vorhis <[email protected]> Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Elizabeth Healy <[email protected]> * additional comments and cleanup Signed-off-by: Elizabeth Healy <[email protected]> * format * fix merge --------- Signed-off-by: Elizabeth Healy <[email protected]> Signed-off-by: jakedoublev <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Paul Flynn <[email protected]> Co-authored-by: jakedoublev <[email protected]> Co-authored-by: Jake Van Vorhis <[email protected]> Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain fields of the rewrap request and response have been deprecated, move to the bulk-style rewrap request/response to be in line with ACP -- the PR does not introduce bulk support, just bulk style requests
Maintains backward compatibility -- can still make and receive v1 requests and responses