Skip to content

Commit 35aa4e2

Browse files
fix (#633)
[CTS]: traces v2 list fix What this PR does / why we need it Fix CTSv2 list func struct issue Reviewed-by: Artem Sh.
1 parent 3f39e43 commit 35aa4e2

File tree

2 files changed

+4
-21
lines changed

2 files changed

+4
-21
lines changed

acceptance/openstack/cts/v2/traces_test.go

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -5,41 +5,24 @@ import (
55

66
"github.com/opentelekomcloud/gophertelekomcloud/acceptance/clients"
77
"github.com/opentelekomcloud/gophertelekomcloud/acceptance/openstack/cts"
8-
"github.com/opentelekomcloud/gophertelekomcloud/openstack/cts/v1/tracker"
8+
"github.com/opentelekomcloud/gophertelekomcloud/acceptance/tools"
99
"github.com/opentelekomcloud/gophertelekomcloud/openstack/cts/v2/traces"
1010
th "github.com/opentelekomcloud/gophertelekomcloud/testhelper"
1111
)
1212

1313
func TestTraces(t *testing.T) {
14-
cv1, err := clients.NewCTSV1Client()
15-
th.AssertNoErr(t, err)
16-
1714
bucketName := cts.CreateOBSBucket(t)
1815
t.Cleanup(func() {
1916
cts.DeleteOBSBucket(t, bucketName)
2017
})
2118

22-
t.Logf("Attempting to create CTSv1 Tracker")
23-
ctsTracker, err := tracker.Create(cv1, tracker.CreateOpts{
24-
BucketName: bucketName,
25-
})
26-
27-
t.Cleanup(func() {
28-
t.Logf("Attempting to delete CTSv1 Tracker: %s", ctsTracker.TrackerName)
29-
err := tracker.Delete(cv1, ctsTracker.TrackerName)
30-
th.AssertNoErr(t, err)
31-
t.Logf("Deleted CTSv1 Tracker: %s", ctsTracker.TrackerName)
32-
})
33-
34-
th.AssertNoErr(t, err)
35-
t.Logf("Created CTSv1 Tracker: %s", ctsTracker.TrackerName)
36-
3719
cv2, err := clients.NewCTSV2Client()
3820
th.AssertNoErr(t, err)
3921

40-
list, err := traces.List(cv2, ctsTracker.TrackerName, traces.ListTracesOpts{})
22+
list, err := traces.List(cv2, "system", traces.ListTracesOpts{})
4123
th.AssertNoErr(t, err)
4224

4325
t.Logf("Number of Tracker Traces: %d", len(list.Traces))
4426
th.AssertEquals(t, true, len(list.Traces) > 0)
27+
tools.PrintResource(t, list)
4528
}

openstack/cts/v2/traces/List.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ type Traces struct {
7575
// including letters, digits, hyphens (-), underscores (_), and periods (.). It must start with a letter.
7676
TraceName string `json:"trace_name,omitempty"`
7777
// Trace status. The value can be normal, warning, or incident.
78-
TraceStatus string `q:"trace_status,omitempty"`
78+
TraceStatus string `json:"trace_status,omitempty"`
7979
// Trace source. The value can be ApiCall, ConsoleAction, or SystemAction.
8080
TraceType string `json:"trace_type,omitempty"`
8181
// Request of an operation on resources.

0 commit comments

Comments
 (0)