Skip to content

Commit c360626

Browse files
Laravel 6.x support (#185)
* request illuminate check both getHost and host method * add laravel version * fix: Return blank string instead of null Signed-off-by: Natsuki Ikeguchi <[email protected]> Co-authored-by: Abhishek Surve <[email protected]>
1 parent 70e5a29 commit c360626

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"minimum-stability": "dev",
1010
"require": {
1111
"php": "^8.0",
12-
"laravel/framework": "*",
12+
"laravel/framework": ">=6.0",
1313
"ext-opentelemetry": "*",
1414
"open-telemetry/api": "^1.0.0beta10",
1515
"open-telemetry/sem-conv": "^1"

src/LaravelInstrumentation.php

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public static function register(): void
5656
->setAttribute(TraceAttributes::HTTP_FLAVOR, $request->getProtocolVersion())
5757
->setAttribute(TraceAttributes::HTTP_CLIENT_IP, $request->ip())
5858
->setAttribute(TraceAttributes::HTTP_TARGET, self::httpTarget($request))
59-
->setAttribute(TraceAttributes::NET_HOST_NAME, $request->host())
59+
->setAttribute(TraceAttributes::NET_HOST_NAME, self::httpHostName($request))
6060
->setAttribute(TraceAttributes::NET_HOST_PORT, $request->getPort())
6161
->setAttribute(TraceAttributes::NET_PEER_PORT, $request->server('REMOTE_PORT'))
6262
->setAttribute(TraceAttributes::USER_AGENT_ORIGINAL, $request->userAgent())
@@ -116,4 +116,16 @@ private static function httpTarget(Request $request): string
116116

117117
return $query ? $request->path() . $question . $query : $request->path();
118118
}
119+
120+
private static function httpHostName(Request $request): string
121+
{
122+
if (method_exists($request, 'host')) {
123+
return $request->host();
124+
}
125+
if (method_exists($request, 'getHost')) {
126+
return $request->getHost();
127+
}
128+
129+
return '';
130+
}
119131
}

0 commit comments

Comments
 (0)