Update span name if route is known (#205)

Author: cedricziel

src/SymfonyInstrumentation.php

@@ -83,7 +83,10 @@ public static function register(): void
                     $routeName = $request->attributes->get('_route', '');
 
                     if ('' !== $routeName) {
-                        $span->setAttribute(TraceAttributes::HTTP_ROUTE, $routeName);
+                        /** @psalm-suppress ArgumentTypeCoercion */
+                        $span
+                            ->updateName(sprintf('%s %s', $request->getMethod(), $routeName))
+                            ->setAttribute(TraceAttributes::HTTP_ROUTE, $routeName);
                     }
                 }
 

tests/Integration/SymfonyInstrumentationTest.php

@@ -48,7 +48,7 @@ public function test_http_kernel_handle_attributes(): void
 
         $attributes = $this->storage[0]->getAttributes();
         $this->assertCount(1, $this->storage);
-        $this->assertEquals('HTTP GET', $this->storage[0]->getName());
+        $this->assertEquals('GET test_route', $this->storage[0]->getName());
         $this->assertEquals('http://:/', $attributes->get(TraceAttributes::URL_FULL));
         $this->assertEquals('GET', $attributes->get(TraceAttributes::HTTP_REQUEST_METHOD));
         $this->assertEquals('http', $attributes->get(TraceAttributes::URL_SCHEME));