Merge pull request #3052 from opentensor/fix/roman/fix-after-Rate-limit-hyperparams-setting

Fix after `Rate limit hyperparams setting`

Author: basfroman

bittensor/core/async_subtensor.py

@@ -1104,6 +1104,33 @@ async def does_hotkey_exist(
         )
         return return_val
 
+    async def get_admin_freeze_window(
+        self,
+        block: Optional[int] = None,
+        block_hash: Optional[str] = None,
+        reuse_block: bool = False,
+    ) -> int:
+        """
+        Returns the number of blocks when dependent transactions will be frozen for execution.
+
+        Arguments:
+            block: The block number at which to retrieve the hyperparameter. Do not specify if using block_hash or
+                reuse_block.
+            block_hash: The hash of the blockchain block for the query. Do not specify if using block or reuse_block.
+            reuse_block: Whether to reuse the last-used block hash. Do not set if using block_hash or block.
+
+        Returns:
+            AdminFreezeWindow as integer. The number of blocks are frozen.
+        """
+        block_hash = await self.determine_block_hash(block, block_hash, reuse_block)
+        return (
+            await self.substrate.query(
+                module="SubtensorModule",
+                storage_function="AdminFreezeWindow",
+                block_hash=block_hash,
+            )
+        ).value
+
     async def get_all_subnets_info(
         self,
         block: Optional[int] = None,

bittensor/core/subtensor.py

@@ -630,6 +630,23 @@ def does_hotkey_exist(self, hotkey_ss58: str, block: Optional[int] = None) -> bo
         )
         return return_val
 
+    def get_admin_freeze_window(self, block: Optional[int] = None) -> int:
+        """
+        Returns the number of blocks when dependent transactions will be frozen for execution.
+
+        Arguments:
+            block: The block number for which the children are to be retrieved.
+
+        Returns:
+            AdminFreezeWindow as integer. The number of blocks are frozen.
+        """
+
+        return self.substrate.query(
+            module="SubtensorModule",
+            storage_function="AdminFreezeWindow",
+            block_hash=self.determine_block_hash(block),
+        ).value
+
     def get_all_subnets_info(self, block: Optional[int] = None) -> list["SubnetInfo"]:
         """
         Retrieves detailed information about all subnets within the Bittensor network. This function provides

tests/e2e_tests/test_commit_reveal.py

@@ -31,6 +31,18 @@ async def test_commit_and_reveal_weights_cr4(local_chain, subtensor, alice_walle
     Raises:
         AssertionError: If any of the checks or verifications fail
     """
+
+    # turn off admin freeze window limit for testing
+    assert (
+        sudo_set_admin_utils(
+            local_chain,
+            alice_wallet,
+            call_function="sudo_set_admin_freeze_window",
+            call_params={"window": 0},
+        )[0]
+        is True
+    ), "Failed to set admin freeze window to 0"
+
     logging.console.info("Testing `test_commit_and_reveal_weights_cr4`")
 
     # 12 for non-fast-block, 0.25 for fast block
@@ -249,6 +261,18 @@ async def test_async_commit_and_reveal_weights_cr4(
     Raises:
         AssertionError: If any of the checks or verifications fail
     """
+
+    # turn off admin freeze window limit for testing
+    assert (
+        sudo_set_admin_utils(
+            local_chain,
+            alice_wallet,
+            call_function="sudo_set_admin_freeze_window",
+            call_params={"window": 0},
+        )[0]
+        is True
+    ), "Failed to set admin freeze window to 0"
+
     logging.console.info("Testing `test_commit_and_reveal_weights_cr4`")
 
     async with async_subtensor:

tests/e2e_tests/test_commit_weights.py

@@ -26,6 +26,18 @@ async def test_commit_and_reveal_weights_legacy(local_chain, subtensor, alice_wa
     Raises:
         AssertionError: If any of the checks or verifications fail
     """
+
+    # turn off admin freeze window limit for testing
+    assert (
+        sudo_set_admin_utils(
+            local_chain,
+            alice_wallet,
+            call_function="sudo_set_admin_freeze_window",
+            call_params={"window": 0},
+        )[0]
+        is True
+    ), "Failed to set admin freeze window to 0"
+
     netuid = subtensor.get_total_subnets()  # 2
     set_tempo = 100 if subtensor.is_fast_blocks() else 10
     print("Testing test_commit_and_reveal_weights")
@@ -165,6 +177,18 @@ async def test_commit_weights_uses_next_nonce(local_chain, subtensor, alice_wall
     Raises:
         AssertionError: If any of the checks or verifications fail
     """
+
+    # turn off admin freeze window limit for testing
+    assert (
+        sudo_set_admin_utils(
+            local_chain,
+            alice_wallet,
+            call_function="sudo_set_admin_freeze_window",
+            call_params={"window": 0},
+        )[0]
+        is True
+    ), "Failed to set admin freeze window to 0"
+
     subnet_tempo = 50 if subtensor.is_fast_blocks() else 10
     netuid = subtensor.get_total_subnets()  # 2
 

tests/e2e_tests/test_incentive.py

@@ -9,8 +9,6 @@
 )
 from tests.e2e_tests.utils.e2e_test_utils import wait_to_start_call
 
-DURATION_OF_START_CALL = 10
-
 
 @pytest.mark.asyncio
 async def test_incentive(local_chain, subtensor, templates, alice_wallet, bob_wallet):
@@ -26,6 +24,17 @@ async def test_incentive(local_chain, subtensor, templates, alice_wallet, bob_wa
         AssertionError: If any of the checks or verifications fail
     """
 
+    # turn off admin freeze window limit for testing
+    assert (
+        sudo_set_admin_utils(
+            local_chain,
+            alice_wallet,
+            call_function="sudo_set_admin_freeze_window",
+            call_params={"window": 0},
+        )[0]
+        is True
+    ), "Failed to set admin freeze window to 0"
+
     print("Testing test_incentive")
     alice_subnet_netuid = subtensor.get_total_subnets()  # 2
 

tests/e2e_tests/test_liquid_alpha.py

@@ -3,6 +3,7 @@
 from tests.e2e_tests.utils.chain_interactions import (
     sudo_set_hyperparameter_bool,
     sudo_set_hyperparameter_values,
+    sudo_set_admin_utils,
 )
 
 
@@ -28,6 +29,17 @@ def test_liquid_alpha(local_chain, subtensor, alice_wallet):
     Raises:
         AssertionError: If any of the checks or verifications fail
     """
+    # turn off admin freeze window limit for testing
+    assert (
+        sudo_set_admin_utils(
+            local_chain,
+            alice_wallet,
+            call_function="sudo_set_admin_freeze_window",
+            call_params={"window": 0},
+        )[0]
+        is True
+    ), "Failed to set admin freeze window to 0"
+
     u16_max = 65535
     netuid = 2
     logging.console.info("Testing test_liquid_alpha_enabled")

tests/e2e_tests/test_set_weights.py

@@ -28,6 +28,17 @@ async def test_set_weights_uses_next_nonce(local_chain, subtensor, alice_wallet)
         AssertionError: If any of the checks or verifications fail
     """
 
+    # turn off admin freeze window limit for testing
+    assert (
+        sudo_set_admin_utils(
+            local_chain,
+            alice_wallet,
+            call_function="sudo_set_admin_freeze_window",
+            call_params={"window": 0},
+        )[0]
+        is True
+    ), "Failed to set admin freeze window to 0"
+
     netuids = [2, 3]
     subnet_tempo = 50
     BLOCK_TIME = 0.25  # 12 for non-fast-block, 0.25 for fast block

tests/e2e_tests/test_staking.py

@@ -342,6 +342,18 @@ def test_safe_staking_scenarios(
     2. Succeeds with strict threshold (0.5%) and partial staking allowed
     3. Succeeds with lenient threshold (10% and 30%) and no partial staking
     """
+
+    # turn off admin freeze window limit for testing
+    assert (
+        sudo_set_admin_utils(
+            local_chain,
+            alice_wallet,
+            call_function="sudo_set_admin_freeze_window",
+            call_params={"window": 0},
+        )[0]
+        is True
+    ), "Failed to set admin freeze window to 0"
+
     alice_subnet_netuid = subtensor.subnets.get_total_subnets()  # 2
     # Register root as Alice - the subnet owner and validator
     assert subtensor.extrinsics.register_subnet(alice_wallet, True, True)

tests/e2e_tests/utils/chain_interactions.py

@@ -16,7 +16,12 @@
     from bittensor import Wallet
     from bittensor.core.async_subtensor import AsyncSubtensor
     from bittensor.core.subtensor import Subtensor
-    from async_substrate_interface import SubstrateInterface, ExtrinsicReceipt
+    from async_substrate_interface import (
+        AsyncSubstrateInterface,
+        AsyncExtrinsicReceipt,
+        SubstrateInterface,
+        ExtrinsicReceipt,
+    )
 
 
 def get_dynamic_balance(rao: int, netuid: int = 0):
@@ -274,6 +279,49 @@ def sudo_set_admin_utils(
     return response.is_success, response.error_message
 
 
+async def async_sudo_set_admin_utils(
+    substrate: "AsyncSubstrateInterface",
+    wallet: "Wallet",
+    call_function: str,
+    call_params: dict,
+    call_module: str = "AdminUtils",
+) -> tuple[bool, Optional[dict]]:
+    """
+    Wraps the call in sudo to set hyperparameter values using AdminUtils.
+
+    Parameters:
+        substrate: Substrate connection.
+        wallet: Wallet object with the keypair for signing.
+        call_function: The AdminUtils function to call.
+        call_params: Parameters for the AdminUtils function.
+        call_module: The AdminUtils module to call. Defaults to "AdminUtils".
+
+    Returns:
+        tuple: (success status, error details).
+    """
+    inner_call = await substrate.compose_call(
+        call_module=call_module,
+        call_function=call_function,
+        call_params=call_params,
+    )
+
+    sudo_call = await substrate.compose_call(
+        call_module="Sudo",
+        call_function="sudo",
+        call_params={"call": inner_call},
+    )
+    extrinsic = await substrate.create_signed_extrinsic(
+        call=sudo_call, keypair=wallet.coldkey
+    )
+    response: "AsyncExtrinsicReceipt" = await substrate.submit_extrinsic(
+        extrinsic,
+        wait_for_inclusion=True,
+        wait_for_finalization=True,
+    )
+
+    return await response.is_success, await response.error_message
+
+
 async def root_set_subtensor_hyperparameter_values(
     substrate: "SubstrateInterface",
     wallet: "Wallet",