apply default era.period to all subtensor extrinsic calls

Author: basfroman

bittensor/core/async_subtensor.py

@@ -956,7 +956,11 @@ async def bonds(
         return b_map
 
     async def commit(
-        self, wallet: "Wallet", netuid: int, data: str, period: Optional[int] = None
+        self,
+        wallet: "Wallet",
+        netuid: int,
+        data: str,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> bool:
         """Commits arbitrary data to the Bittensor network by publishing metadata.
 
@@ -4049,7 +4053,7 @@ async def set_reveal_commitment(
         data: str,
         blocks_until_reveal: int = 360,
         block_time: Union[int, float] = 12,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> tuple[bool, int]:
         """
         Commits arbitrary data to the Bittensor network by publishing metadata.
@@ -4443,7 +4447,7 @@ async def sign_and_send_extrinsic(
         wait_for_finalization: bool = False,
         sign_with: str = "coldkey",
         use_nonce: bool = False,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
         nonce_key: str = "hotkey",
         raise_error: bool = False,
     ) -> tuple[bool, str]:
@@ -4476,13 +4480,7 @@ async def sign_and_send_extrinsic(
                 f"'sign_with' must be either 'coldkey', 'hotkey' or 'coldkeypub', not '{sign_with}'"
             )
         signing_keypair = getattr(wallet, sign_with)
-        extrinsic_data = {
-            "call": call,
-            "keypair": signing_keypair,
-            "era": {
-                "period": period or DEFAULT_PERIOD,
-            },
-        }
+        extrinsic_data = {"call": call, "keypair": signing_keypair}
         if use_nonce:
             if nonce_key not in possible_keys:
                 raise AttributeError(
@@ -4493,6 +4491,9 @@ async def sign_and_send_extrinsic(
             )
             extrinsic_data["nonce"] = next_nonce
 
+        if period is not None:
+            extrinsic_data["era"] = {"period": period}
+
         extrinsic = await self.substrate.create_signed_extrinsic(**extrinsic_data)
         try:
             response = await self.substrate.submit_extrinsic(
@@ -4533,7 +4534,7 @@ async def add_stake(
         safe_staking: bool = False,
         allow_partial_stake: bool = False,
         rate_tolerance: float = 0.005,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> bool:
         """
         Adds a stake from the specified wallet to the neuron identified by the SS58 address of its hotkey in specified
@@ -4591,7 +4592,7 @@ async def add_liquidity(
         hotkey: Optional[str] = None,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = False,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> tuple[bool, str]:
         """
         Adds liquidity to the specified price range.
@@ -4674,7 +4675,7 @@ async def burned_register(
         netuid: int,
         wait_for_inclusion: bool = False,
         wait_for_finalization: bool = True,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> bool:
         """
         Registers a neuron on the Bittensor network by recycling TAO. This method of registration involves recycling
@@ -4723,7 +4724,7 @@ async def commit_weights(
         wait_for_inclusion: bool = False,
         wait_for_finalization: bool = False,
         max_retries: int = 5,
-        period: Optional[int] = 16,
+        period: Optional[int] = DEFAULT_PERIOD,
         mechid: int = 0,
     ) -> tuple[bool, str]:
         """
@@ -4798,7 +4799,7 @@ async def modify_liquidity(
         hotkey: Optional[str] = None,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = False,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> tuple[bool, str]:
         """Modifies liquidity in liquidity position by adding or removing liquidity from it.
 
@@ -4871,7 +4872,7 @@ async def move_stake(
         amount: Optional[Balance] = None,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = False,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
         move_all_stake: bool = False,
     ) -> bool:
         """
@@ -4923,7 +4924,7 @@ async def register(
         num_processes: Optional[int] = None,
         update_interval: Optional[int] = None,
         log_verbose: bool = False,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ):
         """
         Registers a neuron on the Bittensor network using the provided wallet.
@@ -4977,7 +4978,7 @@ async def register_subnet(
         wallet: "Wallet",
         wait_for_inclusion: bool = False,
         wait_for_finalization: bool = True,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> bool:
         """
         Registers a new subnetwork on the Bittensor network.
@@ -5011,7 +5012,7 @@ async def remove_liquidity(
         hotkey: Optional[str] = None,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = False,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> tuple[bool, str]:
         """Remove liquidity and credit balances back to wallet's hotkey stake.
 
@@ -5059,7 +5060,7 @@ async def reveal_weights(
         wait_for_inclusion: bool = False,
         wait_for_finalization: bool = False,
         max_retries: int = 5,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
         mechid: int = 0,
     ) -> tuple[bool, str]:
         """
@@ -5124,7 +5125,7 @@ async def root_set_pending_childkey_cooldown(
         cooldown: int,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = True,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> tuple[bool, str]:
         """Sets the pending childkey cooldown.
 
@@ -5160,7 +5161,7 @@ async def root_register(
         block_hash: Optional[str] = None,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = True,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> bool:
         """
         Register neuron by recycling some TAO.
@@ -5195,7 +5196,7 @@ async def root_set_weights(
         version_key: int = 0,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = True,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> bool:
         """
         Set weights for the root network.
@@ -5233,7 +5234,7 @@ async def set_auto_stake(
         wallet: "Wallet",
         netuid: int,
         hotkey_ss58: str,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
         raise_error: bool = False,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = True,
@@ -5277,7 +5278,7 @@ async def set_children(
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = True,
         raise_error: bool = False,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> tuple[bool, str]:
         """
         Allows a coldkey to set children-keys.
@@ -5331,7 +5332,7 @@ async def set_delegate_take(
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = True,
         raise_error: bool = False,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> tuple[bool, str]:
         """
         Sets the delegate 'take' percentage for a neuron identified by its hotkey.
@@ -5414,7 +5415,7 @@ async def set_subnet_identity(
         subnet_identity: SubnetIdentity,
         wait_for_inclusion: bool = False,
         wait_for_finalization: bool = True,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> tuple[bool, str]:
         """
         Sets the identity of a subnet for a specific wallet and network.
@@ -5464,7 +5465,7 @@ async def set_weights(
         wait_for_finalization: bool = False,
         max_retries: int = 5,
         block_time: float = 12.0,
-        period: Optional[int] = 8,
+        period: Optional[int] = DEFAULT_PERIOD,
         mechid: int = 0,
         commit_reveal_version: int = 4,
     ):
@@ -5589,7 +5590,7 @@ async def serve_axon(
         wait_for_inclusion: bool = False,
         wait_for_finalization: bool = True,
         certificate: Optional[Certificate] = None,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> bool:
         """
         Registers an ``Axon`` serving endpoint on the Bittensor network for a specific neuron. This function is used to
@@ -5627,7 +5628,7 @@ async def start_call(
         netuid: int,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = False,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> tuple[bool, str]:
         """
         Submits a start_call extrinsic to the blockchain, to trigger the start call process for a subnet (used to start
@@ -5668,7 +5669,7 @@ async def swap_stake(
         safe_staking: bool = False,
         allow_partial_stake: bool = False,
         rate_tolerance: float = 0.005,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> bool:
         """
         Moves stake between subnets while keeping the same coldkey-hotkey pair ownership.
@@ -5727,7 +5728,7 @@ async def toggle_user_liquidity(
         enable: bool,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = False,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> tuple[bool, str]:
         """Allow to toggle user liquidity for specified subnet.
 
@@ -5767,7 +5768,7 @@ async def transfer(
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = False,
         keep_alive: bool = True,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> bool:
         """
         Transfer token of amount to destination.
@@ -5810,7 +5811,7 @@ async def transfer_stake(
         amount: Balance,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = False,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> bool:
         """
         Transfers stake from one subnet to another while changing the coldkey owner.
@@ -5856,7 +5857,7 @@ async def unstake(
         safe_staking: bool = False,
         allow_partial_stake: bool = False,
         rate_tolerance: float = 0.005,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
         unstake_all: bool = False,
     ) -> bool:
         """
@@ -5913,7 +5914,7 @@ async def unstake_all(
         rate_tolerance: Optional[float] = 0.005,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = False,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
     ) -> tuple[bool, str]:
         """Unstakes all TAO/Alpha associated with a hotkey from the specified subnets on the Bittensor network.
 
@@ -5997,7 +5998,7 @@ async def unstake_multiple(
         amounts: Optional[list[Balance]] = None,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = False,
-        period: Optional[int] = None,
+        period: Optional[int] = DEFAULT_PERIOD,
         unstake_all: bool = False,
     ) -> bool:
         """

bittensor/core/settings.py

@@ -71,7 +71,7 @@
 SS58_ADDRESS_LENGTH = 48
 
 # Default period for extrinsic Era
-DEFAULT_PERIOD = 16
+DEFAULT_PERIOD = 32
 
 # Block Explorers map network to explorer url
 # Must all be polkadotjs explorer urls