Merge pull request #2702 from opentensor/fix/thewhaleking/dendrite-del-method

Dendrite `__del__` method fix

Author: thewhaleking

bittensor/core/dendrite.py

@@ -877,7 +877,14 @@ def __del__(self):
             # ... some operations ...
             del dendrite  # This will implicitly invoke the __del__ method and close the session.
         """
-        self.close_session()
+        try:
+            self.close_session()
+        except RuntimeError:
+            if self._session:
+                logging.debug(
+                    "A Dendrite session was unable to be closed during garbage-collection of the Dendrite object. This "
+                    "usually indicates that you were not using the async context manager."
+                )
 
 
 # For back-compatibility with torch

tests/unit_tests/test_dendrite.py

@@ -83,6 +83,17 @@ def test_close(setup_dendrite, setup_axon):
     assert setup_dendrite._session is None
 
 
+def test_garbage_collection(setup_dendrite):
+    del setup_dendrite  # should not raise an error
+
+
+@pytest.mark.asyncio
+async def test_async_garbage_collection(setup_dendrite, setup_axon):
+    async with setup_dendrite as dendrite:
+        assert (await dendrite.session) is not None
+    del setup_dendrite  # should not raise error
+
+
 @pytest.mark.asyncio
 async def test_aclose(setup_dendrite, setup_axon):
     axon = setup_axon