refactor: omit return_error_message param in sudo_set_admin_utils

Author: zyzniewski-reef

tests/e2e_tests/test_commit_reveal_v3.py

@@ -59,7 +59,6 @@ async def test_commit_and_reveal_weights_cr3(local_chain, subtensor, alice_walle
         alice_wallet,
         call_function="sudo_set_weights_set_rate_limit",
         call_params={"netuid": netuid, "weights_set_rate_limit": "0"},
-        return_error_message=True,
     )
 
     assert error is None
@@ -81,7 +80,6 @@ async def test_commit_and_reveal_weights_cr3(local_chain, subtensor, alice_walle
             alice_wallet,
             call_function="sudo_set_tempo",
             call_params={"netuid": netuid, "tempo": tempo_set},
-            return_error_message=True,
         )[0]
         is True
     )

tests/e2e_tests/test_commit_weights.py

@@ -60,7 +60,6 @@ async def test_commit_and_reveal_weights_legacy(local_chain, subtensor, alice_wa
         alice_wallet,
         call_function="sudo_set_weights_set_rate_limit",
         call_params={"netuid": netuid, "weights_set_rate_limit": "0"},
-        return_error_message=True,
     )
 
     assert error is None
@@ -80,7 +79,6 @@ async def test_commit_and_reveal_weights_legacy(local_chain, subtensor, alice_wa
             "netuid": netuid,
             "tempo": 100,
         },
-        return_error_message=True,
     )
 
     # Commit-reveal values
@@ -202,7 +200,6 @@ async def test_commit_weights_uses_next_nonce(local_chain, subtensor, alice_wall
         alice_wallet,
         call_function="sudo_set_weights_set_rate_limit",
         call_params={"netuid": netuid, "weights_set_rate_limit": "0"},
-        return_error_message=True,
     )
 
     assert error is None

tests/e2e_tests/test_delegate.py

@@ -320,7 +320,6 @@ def test_nominator_min_required_stake(local_chain, subtensor, alice_wallet, bob_
         call_params={
             "min_stake": "100000000000000",
         },
-        return_error_message=True,
     )
 
     minimum_required_stake = subtensor.get_minimum_required_stake()

tests/e2e_tests/test_dendrite.py

@@ -43,7 +43,6 @@ async def test_dendrite(local_chain, subtensor, templates, alice_wallet, bob_wal
             "netuid": netuid,
             "max_allowed_validators": 1,
         },
-        return_error_message=True,
     )
 
     # update weights_set_rate_limit for fast-blocks
@@ -55,7 +54,6 @@ async def test_dendrite(local_chain, subtensor, templates, alice_wallet, bob_wal
             "netuid": netuid,
             "weights_set_rate_limit": 10,
         },
-        return_error_message=True,
     )
 
     assert error is None

tests/e2e_tests/test_incentive.py

@@ -71,7 +71,6 @@ async def test_incentive(local_chain, subtensor, templates, alice_wallet, bob_wa
         alice_wallet,
         call_function="sudo_set_weights_set_rate_limit",
         call_params={"netuid": netuid, "weights_set_rate_limit": 10},
-        return_error_message=True,
     )
 
     assert error is None

tests/e2e_tests/test_set_weights.py

@@ -34,15 +34,13 @@ async def test_set_weights_uses_next_nonce(local_chain, subtensor, alice_wallet)
         alice_wallet,
         call_function="sudo_set_network_rate_limit",
         call_params={"rate_limit": "0"},  # No limit
-        return_error_message=True,
     )
     # Set lock reduction interval
     sudo_set_admin_utils(
         local_chain,
         alice_wallet,
         call_function="sudo_set_lock_reduction_interval",
         call_params={"interval": "1"},  # 1 block # reduce lock every block
-        return_error_message=True,
     )
 
     # Try to register the subnets
@@ -90,7 +88,6 @@ async def test_set_weights_uses_next_nonce(local_chain, subtensor, alice_wallet)
             alice_wallet,
             call_function="sudo_set_weights_set_rate_limit",
             call_params={"netuid": netuid, "weights_set_rate_limit": "0"},
-            return_error_message=True,
         )
 
         assert error is None

tests/e2e_tests/utils/chain_interactions.py

@@ -150,8 +150,7 @@ def sudo_set_admin_utils(
     wallet: "Wallet",
     call_function: str,
     call_params: dict,
-    return_error_message: bool = False,
-) -> tuple[bool, str]:
+) -> tuple[bool, dict]:
     """
     Wraps the call in sudo to set hyperparameter values using AdminUtils.
 
@@ -160,10 +159,9 @@ def sudo_set_admin_utils(
         wallet (Wallet): Wallet object with the keypair for signing.
         call_function (str): The AdminUtils function to call.
         call_params (dict): Parameters for the AdminUtils function.
-        return_error_message (bool): If True, returns the error message along with the success status.
 
     Returns:
-        Union[bool, tuple[bool, Optional[str]]]: Success status or (success status, error message).
+        tuple[bool, dict]: (success status, error details).
     """
     inner_call = substrate.compose_call(
         call_module="AdminUtils",
@@ -185,10 +183,7 @@ def sudo_set_admin_utils(
         wait_for_finalization=True,
     )
 
-    if return_error_message:
-        return response.is_success, response.error_message
-
-    return response.is_success, ""
+    return response.is_success, response.error_message
 
 
 async def root_set_subtensor_hyperparameter_values(