Changed return types and fixed tests to reflect this

Author: thewhaleking

bittensor/core/async_subtensor.py

@@ -980,7 +980,7 @@ async def get_parents(
         block: Optional[int] = None,
         block_hash: Optional[str] = None,
         reuse_block: bool = False,
-    ) -> tuple[bool, list[tuple[float, str]], str]:
+    ) -> list[tuple[float, str]]:
         """
         This method retrieves the parent of a given hotkey and netuid. It queries the SubtensorModule's ParentKeys
             storage function to get the children and formats them before returning as a tuple.
@@ -993,8 +993,7 @@ async def get_parents(
             reuse_block (bool): Whether to reuse the last-used block hash.
 
         Returns:
-            A tuple containing a boolean indicating success or failure, a list of formatted
-                parents [(proportion, parent)], and an error message (if applicable)
+            A list of formatted parents [(proportion, parent)]
         """
         block_hash = await self.determine_block_hash(block, block_hash, reuse_block)
         parents = await self.substrate.query(
@@ -1011,9 +1010,9 @@ async def get_parents(
                 formatted_child = decode_account_id(parent[0])
                 normalized_proportion = u64_normalized_float(proportion)
                 formatted_parents.append((normalized_proportion, formatted_child))
-            return True, formatted_parents, ""
+            return formatted_parents
         else:
-            return True, [], ""
+            return []
 
     async def get_children(
         self,

bittensor/core/subtensor.py

@@ -753,7 +753,7 @@ def get_hyperparameter(
 
     def get_parents(
         self, hotkey: str, netuid: int, block: Optional[int] = None
-    ) -> tuple[bool, list[tuple[float, str]], str]:
+    ) -> list[tuple[float, str]]:
         """
         This method retrieves the parent of a given hotkey and netuid. It queries the SubtensorModule's ParentKeys
             storage function to get the children and formats them before returning as a tuple.
@@ -764,8 +764,7 @@ def get_parents(
             block (Optional[int]): The block number for which the children are to be retrieved.
 
         Returns:
-            A tuple containing a boolean indicating success or failure, a list of formatted
-                parents [(proportion, parent)], and an error message (if applicable)
+            A list of formatted parents [(proportion, parent)]
         """
         parents = self.substrate.query(
             module="SubtensorModule",

tests/e2e_tests/test_hotkeys.py

@@ -276,12 +276,8 @@ async def test_children(local_chain, subtensor, alice_wallet, bob_wallet, dave_w
     assert success is True
     assert children == [(1.0, bob_wallet.hotkey.ss58_address)]
 
-    success_, parent_, error_ = subtensor.get_parents(
-        bob_wallet.hotkey.ss58_address, dave_subnet_netuid
-    )
+    parent_ = subtensor.get_parents(bob_wallet.hotkey.ss58_address, dave_subnet_netuid)
 
-    assert error_ == ""
-    assert success_ is True
     assert parent_ == [(1.0, alice_wallet.hotkey.ss58_address)]
 
     # pending queue is empty

tests/unit_tests/test_async_subtensor.py

@@ -2021,7 +2021,7 @@ async def test_get_parents_success(subtensor, mocker):
     mocked_decode_account_id.assert_has_calls(
         [mocker.call("parent_key_1"), mocker.call("parent_key_2")]
     )
-    assert result == (True, expected_formatted_parents, "")
+    assert result == expected_formatted_parents
 
 
 @pytest.mark.asyncio
@@ -2046,7 +2046,7 @@ async def test_get_parents_no_parents(subtensor, mocker):
         params=[fake_hotkey, fake_netuid],
         reuse_block_hash=False,
     )
-    assert result == (True, [], "")
+    assert result == []
 
 
 @pytest.mark.asyncio
@@ -2060,24 +2060,9 @@ async def test_get_parents_substrate_request_exception(subtensor, mocker):
     mocked_query = mocker.AsyncMock(side_effect=fake_exception)
     subtensor.substrate.query = mocked_query
 
-    mocked_format_error_message = mocker.Mock(return_value="Formatted error message")
-    mocker.patch.object(
-        async_subtensor, "format_error_message", mocked_format_error_message
-    )
-
     # Call
-    result = await subtensor.get_parents(hotkey=fake_hotkey, netuid=fake_netuid)
-
-    # Asserts
-    mocked_query.assert_called_once_with(
-        block_hash=None,
-        module="SubtensorModule",
-        storage_function="ParentKeys",
-        params=[fake_hotkey, fake_netuid],
-        reuse_block_hash=False,
-    )
-    mocked_format_error_message.assert_called_once_with(fake_exception)
-    assert result == (False, [], "Formatted error message")
+    with pytest.raises(async_subtensor.SubstrateRequestException):
+        await subtensor.get_parents(hotkey=fake_hotkey, netuid=fake_netuid)
 
 
 @pytest.mark.asyncio

tests/unit_tests/test_subtensor.py

@@ -8,6 +8,7 @@
 from async_substrate_interface import sync_substrate
 from async_substrate_interface.types import ScaleObj
 import websockets
+from substrateinterface.exceptions import SubstrateRequestException
 
 from bittensor import StakeInfo
 from bittensor.core import settings
@@ -3786,7 +3787,7 @@ def test_get_parents_success(subtensor, mocker):
     mocked_decode_account_id.assert_has_calls(
         [mocker.call("parent_key_1"), mocker.call("parent_key_2")]
     )
-    assert result == (True, expected_formatted_parents, "")
+    assert result == expected_formatted_parents
 
 
 def test_get_parents_no_parents(subtensor, mocker):
@@ -3809,33 +3810,19 @@ def test_get_parents_no_parents(subtensor, mocker):
         storage_function="ParentKeys",
         params=[fake_hotkey, fake_netuid],
     )
-    assert result == (True, [], "")
+    assert result == []
 
 
 def test_get_parents_substrate_request_exception(subtensor, mocker):
     """Tests get_parents when SubstrateRequestException is raised."""
     # Preps
     fake_hotkey = "valid_hotkey"
     fake_netuid = 1
-    fake_exception = subtensor_module.SubstrateRequestException("Test Exception")
+    fake_exception = SubstrateRequestException("Test Exception")
 
     mocked_query = mocker.MagicMock(side_effect=fake_exception)
     subtensor.substrate.query = mocked_query
 
-    mocked_format_error_message = mocker.Mock(return_value="Formatted error message")
-    mocker.patch.object(
-        subtensor_module, "format_error_message", mocked_format_error_message
-    )
-
     # Call
-    result = subtensor.get_parents(hotkey=fake_hotkey, netuid=fake_netuid)
-
-    # Asserts
-    mocked_query.assert_called_once_with(
-        block_hash=None,
-        module="SubtensorModule",
-        storage_function="ParentKeys",
-        params=[fake_hotkey, fake_netuid],
-    )
-    mocked_format_error_message.assert_called_once_with(fake_exception)
-    assert result == (False, [], "Formatted error message")
+    with pytest.raises(SubstrateRequestException):
+        subtensor.get_parents(hotkey=fake_hotkey, netuid=fake_netuid)