fix: properly mock data_chain class methods

Author: zyzniewski-reef

tests/unit_tests/test_async_subtensor.py

@@ -389,8 +389,10 @@ async def test_get_delegates(subtensor, mocker, fake_result, response):
         autospec=subtensor.query_runtime_api, return_value=fake_result
     )
     subtensor.query_runtime_api = mocked_query_runtime_api
-    mocked_delegate_info_list_from_dicts = mocker.Mock()
-    async_subtensor.DelegateInfo.list_from_dicts = mocked_delegate_info_list_from_dicts
+    mocked_delegate_info_list_from_dicts = mocker.patch.object(
+        async_subtensor.DelegateInfo,
+        "list_from_dicts",
+    )
 
     # Call
     result = await subtensor.get_delegates(block_hash=None, reuse_block=False)
@@ -432,7 +434,11 @@ async def test_get_stake_info_for_coldkey(subtensor, mocker, fake_result, respon
     mocked_stake_info_list_from_dicts = mocker.Mock(
         return_value=[mock_stake_info] if fake_result else []
     )
-    async_subtensor.StakeInfo.list_from_dicts = mocked_stake_info_list_from_dicts
+    mocker.patch.object(
+        async_subtensor.StakeInfo,
+        "list_from_dicts",
+        mocked_stake_info_list_from_dicts,
+    )
 
     # Call
     result = await subtensor.get_stake_info_for_coldkey(
@@ -974,9 +980,8 @@ async def test_neurons_lite(subtensor, mocker, fake_result, response):
     mocked_query_runtime_api = mocker.AsyncMock(return_value=fake_result)
     subtensor.query_runtime_api = mocked_query_runtime_api
 
-    mocked_neuron_info_lite_list_from_dicts = mocker.Mock()
-    async_subtensor.NeuronInfoLite.list_from_dicts = (
-        mocked_neuron_info_lite_list_from_dicts
+    mocked_neuron_info_lite_list_from_dicts = mocker.patch.object(
+        async_subtensor.NeuronInfoLite, "list_from_dicts"
     )
 
     # Call
@@ -1138,11 +1143,14 @@ async def test_neuron_for_uid_happy_path(subtensor, mocker):
     fake_netuid = 2
     fake_block_hash = "block_hash"
 
-    mocked_null_neuron = mocker.Mock()
-    async_subtensor.NeuronInfo.get_null_neuron = mocked_null_neuron
-
-    mocked_neuron_info_from_dict = mocker.Mock()
-    async_subtensor.NeuronInfo.from_dict = mocked_neuron_info_from_dict
+    mocked_null_neuron = mocker.patch.object(
+        async_subtensor.NeuronInfo,
+        "get_null_neuron",
+    )
+    mocked_neuron_info_from_dict = mocker.patch.object(
+        async_subtensor.NeuronInfo,
+        "from_dict",
+    )
 
     # Call
     result = await subtensor.neuron_for_uid(
@@ -1165,8 +1173,10 @@ async def test_neuron_for_uid_with_none_uid(subtensor, mocker):
     fake_netuid = 1
     fake_block_hash = "block_hash"
 
-    mocked_null_neuron = mocker.Mock()
-    async_subtensor.NeuronInfo.get_null_neuron = mocked_null_neuron
+    mocked_null_neuron = mocker.patch.object(
+        async_subtensor.NeuronInfo,
+        "get_null_neuron",
+    )
 
     # Call
     result = await subtensor.neuron_for_uid(
@@ -1186,8 +1196,10 @@ async def test_neuron_for_uid(subtensor, mocker):
     fake_netuid = 2
     fake_block_hash = "block_hash"
 
-    mocked_null_neuron = mocker.Mock()
-    async_subtensor.NeuronInfo.get_null_neuron = mocked_null_neuron
+    mocked_null_neuron = mocker.patch.object(
+        async_subtensor.NeuronInfo,
+        "get_null_neuron",
+    )
 
     # no result in response
     mocked_substrate_runtime_call = mocker.AsyncMock(
@@ -1197,8 +1209,10 @@ async def test_neuron_for_uid(subtensor, mocker):
     )
     subtensor.substrate.runtime_call = mocked_substrate_runtime_call
 
-    mocked_neuron_info_from_dict = mocker.Mock()
-    async_subtensor.NeuronInfo.from_dict = mocked_neuron_info_from_dict
+    mocked_neuron_info_from_dict = mocker.patch.object(
+        async_subtensor.NeuronInfo,
+        "from_dict",
+    )
 
     # Call
     result = await subtensor.neuron_for_uid(
@@ -2173,8 +2187,11 @@ async def test_weights_rate_limit_success(subtensor, mocker):
     fake_netuid = 1
     fake_rate_limit = 10
 
-    mocked_get_hyperparameter = mocker.AsyncMock(return_value=fake_rate_limit)
-    subtensor.get_hyperparameter = mocked_get_hyperparameter
+    mocked_get_hyperparameter = mocker.patch.object(
+        subtensor,
+        "get_hyperparameter",
+        return_value=fake_rate_limit,
+    )
 
     # Call
     result = await subtensor.weights_rate_limit(netuid=fake_netuid)
@@ -2196,8 +2213,11 @@ async def test_weights_rate_limit_none(subtensor, mocker):
     fake_netuid = 1
     fake_result = None
 
-    mocked_get_hyperparameter = mocker.AsyncMock(return_value=fake_result)
-    subtensor.get_hyperparameter = mocked_get_hyperparameter
+    mocked_get_hyperparameter = mocker.patch.object(
+        subtensor,
+        "get_hyperparameter",
+        return_value=fake_result,
+    )
 
     # Call
     result = await subtensor.weights_rate_limit(netuid=fake_netuid)
@@ -2222,10 +2242,11 @@ async def test_blocks_since_last_update_success(subtensor, mocker):
     current_block = 100
     fake_blocks_since_update = current_block - last_update_block
 
-    mocked_get_hyperparameter = mocker.AsyncMock(
-        return_value={fake_uid: last_update_block}
+    mocked_get_hyperparameter = mocker.patch.object(
+        subtensor,
+        "get_hyperparameter",
+        return_value={fake_uid: last_update_block},
     )
-    subtensor.get_hyperparameter = mocked_get_hyperparameter
 
     mocked_get_current_block = mocker.AsyncMock(return_value=current_block)
     subtensor.get_current_block = mocked_get_current_block
@@ -2249,8 +2270,11 @@ async def test_blocks_since_last_update_no_last_update(subtensor, mocker):
     fake_uid = 5
     fake_result = None
 
-    mocked_get_hyperparameter = mocker.AsyncMock(return_value=fake_result)
-    subtensor.get_hyperparameter = mocked_get_hyperparameter
+    mocked_get_hyperparameter = mocker.patch.object(
+        subtensor,
+        "get_hyperparameter",
+        return_value=fake_result,
+    )
 
     # Call
     result = await subtensor.blocks_since_last_update(netuid=fake_netuid, uid=fake_uid)

tests/unit_tests/test_subtensor.py

@@ -367,15 +367,23 @@ def test_blocks_since_last_update_success_calls(subtensor, mocker):
     uid = 7
     mocked_current_block = 2
     mocked_result = {uid: 1}
-    subtensor.get_hyperparameter = mocker.MagicMock(return_value=mocked_result)
-    subtensor.get_current_block = mocker.MagicMock(return_value=mocked_current_block)
+    mocked_get_hyperparameter = mocker.patch.object(
+        subtensor,
+        "get_hyperparameter",
+        return_value=mocked_result,
+    )
+    mocked_get_current_block = mocker.patch.object(
+        subtensor,
+        "get_current_block",
+        return_value=mocked_current_block,
+    )
 
     # Call
     result = subtensor.blocks_since_last_update(netuid=7, uid=uid)
 
     # Assertions
-    subtensor.get_current_block.assert_called_once()
-    subtensor.get_hyperparameter.assert_called_once_with(
+    mocked_get_current_block.assert_called_once()
+    mocked_get_hyperparameter.assert_called_once_with(
         param_name="LastUpdate", netuid=7
     )
     assert result == 1
@@ -386,13 +394,17 @@ def test_blocks_since_last_update_success_calls(subtensor, mocker):
 def test_weights_rate_limit_success_calls(subtensor, mocker):
     """Tests the weights_rate_limit method to ensure it correctly fetches the WeightsSetRateLimit hyperparameter."""
     # Prep
-    subtensor.get_hyperparameter = mocker.MagicMock(return_value=5)
+    mocked_get_hyperparameter = mocker.patch.object(
+        subtensor,
+        "get_hyperparameter",
+        return_value=5,
+    )
 
     # Call
     result = subtensor.weights_rate_limit(netuid=7)
 
     # Assertions
-    subtensor.get_hyperparameter.assert_called_once_with(
+    mocked_get_hyperparameter.assert_called_once_with(
         param_name="WeightsSetRateLimit",
         netuid=7,
         block=None,
@@ -1285,9 +1297,11 @@ def test_subnetwork_n(subtensor, mocker):
     fake_block = 123
     fake_result = 2
 
-    mocked_get_hyperparameter = mocker.MagicMock()
-    mocked_get_hyperparameter.return_value = fake_result
-    subtensor.get_hyperparameter = mocked_get_hyperparameter
+    mocked_get_hyperparameter = mocker.patch.object(
+        subtensor,
+        "get_hyperparameter",
+        return_value=fake_result,
+    )
 
     # Call
     result = subtensor.subnetwork_n(fake_netuid, fake_block)
@@ -1589,11 +1603,13 @@ def test_immunity_period(subtensor, mocker):
     # Preps
     fake_netuid = 1
     fake_block = 123
-    fare_result = 101
+    fake_result = 101
 
-    mocked_get_hyperparameter = mocker.MagicMock()
-    mocked_get_hyperparameter.return_value = fare_result
-    subtensor.get_hyperparameter = mocked_get_hyperparameter
+    mocked_get_hyperparameter = mocker.patch.object(
+        subtensor,
+        "get_hyperparameter",
+        return_value=fake_result,
+    )
 
     # Call
     result = subtensor.immunity_period(netuid=fake_netuid, block=fake_block)
@@ -1638,11 +1654,13 @@ def test_tempo(subtensor, mocker):
     # Preps
     fake_netuid = 1
     fake_block = 123
-    fare_result = 101
+    fake_result = 101
 
-    mocked_get_hyperparameter = mocker.MagicMock()
-    mocked_get_hyperparameter.return_value = fare_result
-    subtensor.get_hyperparameter = mocked_get_hyperparameter
+    mocked_get_hyperparameter = mocker.patch.object(
+        subtensor,
+        "get_hyperparameter",
+        return_value=fake_result,
+    )
 
     # Call
     result = subtensor.tempo(netuid=fake_netuid, block=fake_block)
@@ -1823,8 +1841,11 @@ def test_min_allowed_weights(subtensor, mocker):
     fake_block = 123
     return_value = 10
 
-    mocked_get_hyperparameter = mocker.MagicMock(return_value=return_value)
-    subtensor.get_hyperparameter = mocked_get_hyperparameter
+    mocked_get_hyperparameter = mocker.patch.object(
+        subtensor,
+        "get_hyperparameter",
+        return_value=return_value,
+    )
 
     # Call
     result = subtensor.min_allowed_weights(netuid=fake_netuid, block=fake_block)
@@ -1842,8 +1863,11 @@ def test_max_weight_limit(subtensor, mocker):
     fake_block = 123
     return_value = 100
 
-    mocked_get_hyperparameter = mocker.MagicMock(return_value=return_value)
-    subtensor.get_hyperparameter = mocked_get_hyperparameter
+    mocked_get_hyperparameter = mocker.patch.object(
+        subtensor,
+        "get_hyperparameter",
+        return_value=return_value,
+    )
 
     mocked_u16_normalized_float = mocker.patch.object(
         subtensor_module,