Merge pull request #2963 from opentensor/release/9.8.2

Release/9.8.2

Author: basfroman

CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## 9.8.2 /2025-07-10
+
+## What's Changed
+* edit docstrings by @MichaelTrestman in https://github.com/opentensor/bittensor/pull/2951
+* fix and improve e2e stake fee test by @basfroman in https://github.com/opentensor/bittensor/pull/2959
+* Make DynamicInfo backwards compatible by @basfroman in https://github.com/opentensor/bittensor/pull/2958
+* Update staking fee logic by @basfroman in https://github.com/opentensor/bittensor/pull/2961
+
+## New Contributors
+* @MichaelTrestman made their first contribution in https://github.com/opentensor/bittensor/pull/2951
+
+**Full Changelog**: https://github.com/opentensor/bittensor/compare/v9.8.1...v9.8.2
+
 ## 9.8.1 /2025-07-08
 
 ## What's Changed

bittensor/core/async_subtensor.py

@@ -75,21 +75,24 @@ def _from_dict(cls, decoded: dict) -> "DynamicInfo":
 
         subnet_volume = Balance.from_rao(decoded["subnet_volume"]).set_unit(netuid)
 
-        if decoded.get("subnet_identity"):
+        if subnet_identity := decoded.get("subnet_identity"):
+            # we need to check it for keep backwards compatibility
+            logo_bytes = subnet_identity.get("logo_url")
+            si_logo_url = bytes(logo_bytes).decode() if logo_bytes else None
+
             subnet_identity = SubnetIdentity(
-                subnet_name=bytes(decoded["subnet_identity"]["subnet_name"]).decode(),
-                github_repo=bytes(decoded["subnet_identity"]["github_repo"]).decode(),
-                subnet_contact=bytes(
-                    decoded["subnet_identity"]["subnet_contact"]
-                ).decode(),
-                subnet_url=bytes(decoded["subnet_identity"]["subnet_url"]).decode(),
-                logo_url=bytes(decoded["subnet_identity"]["logo_url"]).decode(),
-                discord=bytes(decoded["subnet_identity"]["discord"]).decode(),
-                description=bytes(decoded["subnet_identity"]["description"]).decode(),
-                additional=bytes(decoded["subnet_identity"]["additional"]).decode(),
+                subnet_name=bytes(subnet_identity["subnet_name"]).decode(),
+                github_repo=bytes(subnet_identity["github_repo"]).decode(),
+                subnet_contact=bytes(subnet_identity["subnet_contact"]).decode(),
+                subnet_url=bytes(subnet_identity["subnet_url"]).decode(),
+                logo_url=si_logo_url,
+                discord=bytes(subnet_identity["discord"]).decode(),
+                description=bytes(subnet_identity["description"]).decode(),
+                additional=bytes(subnet_identity["additional"]).decode(),
             )
         else:
             subnet_identity = None
+
         price = decoded.get("price", None)
 
         if price and not isinstance(price, Balance):
@@ -110,7 +113,11 @@ def _from_dict(cls, decoded: dict) -> "DynamicInfo":
             tao_in=tao_in,
             k=tao_in.rao * alpha_in.rao,
             is_dynamic=is_dynamic,
-            price=price,
+            price=(
+                price
+                if price is not None
+                else Balance.from_tao(tao_in.tao / alpha_in.tao).set_unit(netuid)
+            ),
             alpha_out_emission=alpha_out_emission,
             alpha_in_emission=alpha_in_emission,
             tao_in_emission=tao_in_emission,

bittensor/core/chain_data/dynamic_info.py

@@ -306,7 +306,7 @@ async def get_metadata(
     block: Optional[int] = None,
     block_hash: Optional[str] = None,
     reuse_block: bool = False,
-) -> str:
+) -> Union[str, dict]:
     """Fetches metadata from the blockchain for a given hotkey and netuid."""
     async with subtensor.substrate:
         block_hash = await subtensor.determine_block_hash(

bittensor/core/extrinsics/asyncex/serving.py

@@ -120,7 +120,11 @@
     price_to_tick,
     LiquidityPosition,
 )
-from bittensor.utils.weight_utils import generate_weight_hash, convert_uids_and_weights
+from bittensor.utils.weight_utils import (
+    generate_weight_hash,
+    convert_uids_and_weights,
+    U16_MAX,
+)
 
 if TYPE_CHECKING:
     from bittensor_wallet import Wallet
@@ -445,15 +449,14 @@ def all_subnets(self, block: Optional[int] = None) -> Optional[list["DynamicInfo
             Optional[DynamicInfo]: A list of DynamicInfo objects, each containing detailed information about a subnet.
 
         """
-        block_hash = self.determine_block_hash(block)
+        block_hash = self.determine_block_hash(block=block)
         query = self.substrate.runtime_call(
-            "SubnetInfoRuntimeApi",
-            "get_all_dynamic_info",
+            api="SubnetInfoRuntimeApi",
+            method="get_all_dynamic_info",
             block_hash=block_hash,
         )
         subnet_prices = self.get_subnet_prices()
         decoded = query.decode()
-
         for sn in decoded:
             sn.update({"price": subnet_prices.get(sn["netuid"], Balance.from_tao(0))})
         return DynamicInfo.list_from_dicts(decoded)
@@ -1277,13 +1280,9 @@ def get_hotkey_owner(
     def get_minimum_required_stake(self) -> Balance:
         """
         Returns the minimum required stake for nominators in the Subtensor network.
-        This method retries the substrate call up to three times with exponential backoff in case of failures.
 
         Returns:
-            Balance: The minimum required stake as a Balance object.
-
-        Raises:
-            Exception: If the substrate call fails after the maximum number of retries.
+            The minimum required stake as a Balance object in TAO.
         """
         result = self.substrate.query(
             module="SubtensorModule", storage_function="NominatorMinRequiredStake"
@@ -1761,6 +1760,7 @@ def get_stake(
 
         return Balance.from_rao(int(stake)).set_unit(netuid=netuid)
 
+    # TODO: remove unused parameters in SDK.v10
     def get_stake_add_fee(
         self,
         amount: Balance,
@@ -1782,19 +1782,7 @@ def get_stake_add_fee(
         Returns:
             The calculated stake fee as a Balance object
         """
-        result = self.query_runtime_api(
-            runtime_api="StakeInfoRuntimeApi",
-            method="get_stake_fee",
-            params=[
-                None,
-                coldkey_ss58,
-                (hotkey_ss58, netuid),
-                coldkey_ss58,
-                amount.rao,
-            ],
-            block=block,
-        )
-        return Balance.from_rao(result)
+        return self.get_stake_operations_fee(amount=amount, netuid=netuid, block=block)
 
     def get_subnet_info(
         self, netuid: int, block: Optional[int] = None
@@ -1887,6 +1875,7 @@ def get_subnet_prices(
         prices.update({0: Balance.from_tao(1)})
         return prices
 
+    # TODO: remove unused parameters in SDK.v10
     def get_unstake_fee(
         self,
         amount: Balance,
@@ -1908,20 +1897,9 @@ def get_unstake_fee(
         Returns:
             The calculated stake fee as a Balance object
         """
-        result = self.query_runtime_api(
-            runtime_api="StakeInfoRuntimeApi",
-            method="get_stake_fee",
-            params=[
-                (hotkey_ss58, netuid),
-                coldkey_ss58,
-                None,
-                coldkey_ss58,
-                amount.rao,
-            ],
-            block=block,
-        )
-        return Balance.from_rao(result)
+        return self.get_stake_operations_fee(amount=amount, netuid=netuid, block=block)
 
+    # TODO: remove unused parameters in SDK.v10
     def get_stake_movement_fee(
         self,
         amount: Balance,
@@ -1949,19 +1927,9 @@ def get_stake_movement_fee(
         Returns:
             The calculated stake fee as a Balance object
         """
-        result = self.query_runtime_api(
-            runtime_api="StakeInfoRuntimeApi",
-            method="get_stake_fee",
-            params=[
-                (origin_hotkey_ss58, origin_netuid),
-                origin_coldkey_ss58,
-                (destination_hotkey_ss58, destination_netuid),
-                destination_coldkey_ss58,
-                amount.rao,
-            ],
-            block=block,
+        return self.get_stake_operations_fee(
+            amount=amount, netuid=origin_netuid, block=block
         )
-        return Balance.from_rao(result)
 
     def get_stake_for_coldkey_and_hotkey(
         self,
@@ -2049,6 +2017,31 @@ def get_stake_for_hotkey(
 
     get_hotkey_stake = get_stake_for_hotkey
 
+    def get_stake_operations_fee(
+        self,
+        amount: Balance,
+        netuid: int,
+        block: Optional[int] = None,
+    ):
+        """Returns fee for any stake operation in specified subnet.
+
+        Args:
+            amount: Amount of stake to add in Alpha/TAO.
+            netuid: Netuid of subnet.
+            block: Block number at which to perform the calculation.
+
+        Returns:
+            The calculated stake fee as a Balance object.
+        """
+        block_hash = self.determine_block_hash(block=block)
+        result = self.substrate.query(
+            module="Swap",
+            storage_function="FeeRate",
+            params=[netuid],
+            block_hash=block_hash,
+        )
+        return amount * (result.value / U16_MAX)
+
     def get_subnet_burn_cost(self, block: Optional[int] = None) -> Optional[Balance]:
         """
         Retrieves the burn cost for registering a new subnet within the Bittensor network. This cost represents the
@@ -2700,17 +2693,20 @@ def subnet(self, netuid: int, block: Optional[int] = None) -> Optional[DynamicIn
             Optional[DynamicInfo]: A DynamicInfo object, containing detailed information about a subnet.
 
         """
-        block_hash = self.determine_block_hash(block)
+        block_hash = self.determine_block_hash(block=block)
 
         query = self.substrate.runtime_call(
-            "SubnetInfoRuntimeApi",
-            "get_dynamic_info",
+            api="SubnetInfoRuntimeApi",
+            method="get_dynamic_info",
             params=[netuid],
             block_hash=block_hash,
         )
 
         if isinstance(decoded := query.decode(), dict):
-            price = self.get_subnet_price(netuid=netuid, block=block)
+            try:
+                price = self.get_subnet_price(netuid=netuid, block=block)
+            except SubstrateRequestException:
+                price = None
             return DynamicInfo.from_dict({**decoded, "price": price})
         return None
 

bittensor/core/subtensor.py

@@ -19,6 +19,7 @@ def __init__(self, subtensor: Union["_Subtensor", "_AsyncSubtensor"]):
         )
         self.get_stake_info_for_coldkey = subtensor.get_stake_info_for_coldkey
         self.get_stake_movement_fee = subtensor.get_stake_movement_fee
+        self.get_stake_operations_fee = subtensor.get_stake_operations_fee
         self.get_unstake_fee = subtensor.get_unstake_fee
         self.unstake = subtensor.unstake
         self.unstake_all = subtensor.unstake_all

bittensor/core/subtensor_api/staking.py

@@ -86,6 +86,7 @@ def add_legacy_methods(subtensor: "SubtensorApi"):
         subtensor._subtensor.get_stake_info_for_coldkey
     )
     subtensor.get_stake_movement_fee = subtensor._subtensor.get_stake_movement_fee
+    subtensor.get_stake_operations_fee = subtensor._subtensor.get_stake_operations_fee
     subtensor.get_subnet_burn_cost = subtensor._subtensor.get_subnet_burn_cost
     subtensor.get_subnet_hyperparameters = (
         subtensor._subtensor.get_subnet_hyperparameters

bittensor/core/subtensor_api/utils.py

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "bittensor"
-version = "9.8.1"
+version = "9.8.2"
 description = "Bittensor"
 readme = "README.md"
 authors = [

pyproject.toml

@@ -293,11 +293,13 @@ async def test_delegates(local_chain, subtensor, alice_wallet, bob_wallet):
     bittensor.logging.console.success("Test [green]test_delegates[/green] passed.")
 
 
-def test_nominator_min_required_stake(local_chain, subtensor, alice_wallet, bob_wallet):
+def test_nominator_min_required_stake(
+    local_chain, subtensor, alice_wallet, bob_wallet, dave_wallet
+):
     """
     Tests:
     - Check default NominatorMinRequiredStake
-    - Add Stake to Nominate
+    - Add Stake to Nominate from Dave to Bob
     - Update NominatorMinRequiredStake
     - Check Nominator is removed
     """
@@ -323,15 +325,22 @@ def test_nominator_min_required_stake(local_chain, subtensor, alice_wallet, bob_
     assert minimum_required_stake == Balance(0)
 
     subtensor.burned_register(
-        bob_wallet,
-        alice_subnet_netuid,
+        wallet=bob_wallet,
+        netuid=alice_subnet_netuid,
+        wait_for_inclusion=True,
+        wait_for_finalization=True,
+    )
+
+    subtensor.burned_register(
+        wallet=dave_wallet,
+        netuid=alice_subnet_netuid,
         wait_for_inclusion=True,
         wait_for_finalization=True,
     )
 
     success = subtensor.add_stake(
-        alice_wallet,
-        bob_wallet.hotkey.ss58_address,
+        wallet=dave_wallet,
+        hotkey_ss58=bob_wallet.hotkey.ss58_address,
         netuid=alice_subnet_netuid,
         amount=Balance.from_tao(10_000),
         wait_for_inclusion=True,
@@ -341,17 +350,17 @@ def test_nominator_min_required_stake(local_chain, subtensor, alice_wallet, bob_
     assert success is True
 
     stake = subtensor.get_stake(
-        alice_wallet.coldkey.ss58_address,
-        bob_wallet.hotkey.ss58_address,
+        coldkey_ss58=dave_wallet.coldkey.ss58_address,
+        hotkey_ss58=bob_wallet.hotkey.ss58_address,
         netuid=alice_subnet_netuid,
     )
 
     assert stake > 0
 
     # this will trigger clear_small_nominations
     sudo_set_admin_utils(
-        local_chain,
-        alice_wallet,
+        substrate=local_chain,
+        wallet=alice_wallet,
         call_function="sudo_set_nominator_min_required_stake",
         call_params={
             "min_stake": "100000000000000",
@@ -363,8 +372,8 @@ def test_nominator_min_required_stake(local_chain, subtensor, alice_wallet, bob_
     assert minimum_required_stake == Balance.from_tao(100_000)
 
     stake = subtensor.get_stake(
-        alice_wallet.coldkey.ss58_address,
-        bob_wallet.hotkey.ss58_address,
+        coldkey_ss58=dave_wallet.coldkey.ss58_address,
+        hotkey_ss58=bob_wallet.hotkey.ss58_address,
         netuid=alice_subnet_netuid,
     )