Merge pull request #2699 from opentensor/fix/thewhaleking/get-all-commitments-fix

Fixes get_all_commitments, adds tests.

Author: thewhaleking

bittensor/core/async_subtensor.py

@@ -999,7 +999,7 @@ async def get_all_commitments(
         )
         result = {}
         async for id_, value in query:
-            result[decode_account_id(id_[0])] = decode_account_id(value)
+            result[decode_account_id(id_[0])] = decode_metadata(value)
         return result
 
     async def get_current_weight_commit_info(

bittensor/core/subtensor.py

@@ -754,7 +754,7 @@ def get_all_commitments(
         )
         result = {}
         for id_, value in query:
-            result[decode_account_id(id_[0])] = decode_account_id(value)
+            result[decode_account_id(id_[0])] = decode_metadata(value)
         return result
 
     def get_current_weight_commit_info(

tests/e2e_tests/conftest.py

@@ -8,8 +8,9 @@
 
 import pytest
 from async_substrate_interface import SubstrateInterface
-from bittensor.core.subtensor import Subtensor
 
+from bittensor.core.async_subtensor import AsyncSubtensor
+from bittensor.core.subtensor import Subtensor
 from bittensor.utils.btlogging import logging
 from tests.e2e_tests.utils.e2e_test_utils import (
     Templates,
@@ -101,6 +102,11 @@ def subtensor(local_chain):
     return Subtensor(network="ws://localhost:9944")
 
 
+@pytest.fixture
+def async_subtensor(local_chain):
+    return AsyncSubtensor(network="ws://localhost:9944")
+
+
 @pytest.fixture
 def alice_wallet():
     keypair, wallet = setup_wallet("//Alice")

tests/e2e_tests/test_commitment.py

@@ -51,3 +51,61 @@ def test_commitment(subtensor, alice_wallet):
         netuid=1,
         uid=uid,
     )
+
+    assert (
+        subtensor.get_all_commitments(netuid=1)[alice_wallet.hotkey.ss58_address]
+        == "Hello World!"
+    )
+
+
+@pytest.mark.asyncio
+async def test_commitment_async(async_subtensor, alice_wallet):
+    async with async_subtensor as sub:
+        with pytest.raises(SubstrateRequestException, match="AccountNotAllowedCommit"):
+            await sub.set_commitment(
+                alice_wallet,
+                netuid=1,
+                data="Hello World!",
+            )
+
+        assert await sub.burned_register(
+            alice_wallet,
+            netuid=1,
+        )
+
+        uid = await sub.get_uid_for_hotkey_on_subnet(
+            alice_wallet.hotkey.ss58_address,
+            netuid=1,
+        )
+
+        assert uid is not None
+
+        assert "" == await sub.get_commitment(
+            netuid=1,
+            uid=uid,
+        )
+
+        assert await sub.set_commitment(
+            alice_wallet,
+            netuid=1,
+            data="Hello World!",
+        )
+
+        with pytest.raises(
+            SubstrateRequestException,
+            match="CommitmentSetRateLimitExceeded",
+        ):
+            await sub.set_commitment(
+                alice_wallet,
+                netuid=1,
+                data="Hello World!",
+            )
+
+        assert "Hello World!" == await sub.get_commitment(
+            netuid=1,
+            uid=uid,
+        )
+
+        assert (await sub.get_all_commitments(netuid=1))[
+            alice_wallet.hotkey.ss58_address
+        ] == "Hello World!"