fix sudo_set_weights_set_rate_limit

Author: zyzniewski-reef

tests/e2e_tests/test_commit_reveal_v3.py

@@ -1,15 +1,12 @@
 import re
-import time
 
 import numpy as np
 import pytest
 from bittensor.utils.btlogging import logging
-from bittensor.utils.balance import Balance
 from bittensor.utils.weight_utils import convert_weights_and_uids_for_emit
 from tests.e2e_tests.utils.chain_interactions import (
     sudo_set_admin_utils,
     sudo_set_hyperparameter_bool,
-    sudo_set_hyperparameter_values,
     wait_interval,
     next_tempo,
 )
@@ -57,14 +54,17 @@ async def test_commit_and_reveal_weights_cr3(local_chain, subtensor, alice_walle
     logging.console.info("Commit reveal enabled")
 
     # Change the weights rate limit on the subnet
-    assert sudo_set_hyperparameter_values(
+    status, error = sudo_set_admin_utils(
         local_chain,
         alice_wallet,
         call_function="sudo_set_weights_set_rate_limit",
         call_params={"netuid": netuid, "weights_set_rate_limit": "0"},
         return_error_message=True,
     )
 
+    assert error is None
+    assert status is True
+
     # Verify weights rate limit was changed
     assert (
         subtensor.get_subnet_hyperparameters(netuid=netuid).weights_rate_limit == 0

tests/e2e_tests/test_commit_weights.py

@@ -7,7 +7,6 @@
 from tests.e2e_tests.utils.chain_interactions import (
     sudo_set_admin_utils,
     sudo_set_hyperparameter_bool,
-    sudo_set_hyperparameter_values,
     wait_epoch,
 )
 
@@ -54,15 +53,19 @@ async def test_commit_and_reveal_weights_legacy(local_chain, subtensor, alice_wa
     assert (
         subtensor.weights_rate_limit(netuid=netuid) > 0
     ), "Weights rate limit is below 0"
+
     # Lower the rate limit
-    assert sudo_set_hyperparameter_values(
+    status, error = sudo_set_admin_utils(
         local_chain,
         alice_wallet,
         call_function="sudo_set_weights_set_rate_limit",
         call_params={"netuid": netuid, "weights_set_rate_limit": "0"},
         return_error_message=True,
     )
 
+    assert error is None
+    assert status is True
+
     assert (
         subtensor.get_subnet_hyperparameters(netuid=netuid).weights_rate_limit == 0
     ), "Failed to set weights_rate_limit"
@@ -192,15 +195,19 @@ async def test_commit_weights_uses_next_nonce(local_chain, subtensor, alice_wall
     assert (
         subtensor.weights_rate_limit(netuid=netuid) > 0
     ), "Weights rate limit is below 0"
+
     # Lower the rate limit
-    assert sudo_set_hyperparameter_values(
+    status, error = sudo_set_admin_utils(
         local_chain,
         alice_wallet,
         call_function="sudo_set_weights_set_rate_limit",
         call_params={"netuid": netuid, "weights_set_rate_limit": "0"},
         return_error_message=True,
     )
 
+    assert error is None
+    assert status is True
+
     assert (
         subtensor.get_subnet_hyperparameters(netuid=netuid).weights_rate_limit == 0
     ), "Failed to set weights_rate_limit"

tests/e2e_tests/test_dendrite.py

@@ -6,7 +6,6 @@
 from bittensor.utils.btlogging import logging
 from tests.e2e_tests.utils.chain_interactions import (
     sudo_set_admin_utils,
-    sudo_set_hyperparameter_values,
     wait_epoch,
 )
 
@@ -48,7 +47,7 @@ async def test_dendrite(local_chain, subtensor, templates, alice_wallet, bob_wal
     )
 
     # update weights_set_rate_limit for fast-blocks
-    assert sudo_set_hyperparameter_values(
+    status, error = sudo_set_admin_utils(
         local_chain,
         alice_wallet,
         call_function="sudo_set_weights_set_rate_limit",
@@ -59,6 +58,9 @@ async def test_dendrite(local_chain, subtensor, templates, alice_wallet, bob_wal
         return_error_message=True,
     )
 
+    assert error is None
+    assert status is True
+
     # Register Bob to the network
     assert subtensor.burned_register(
         bob_wallet, netuid

tests/e2e_tests/test_incentive.py

@@ -3,7 +3,7 @@
 import pytest
 
 from tests.e2e_tests.utils.chain_interactions import (
-    sudo_set_hyperparameter_values,
+    sudo_set_admin_utils,
     wait_epoch,
 )
 
@@ -66,14 +66,17 @@ async def test_incentive(local_chain, subtensor, templates, alice_wallet, bob_wa
     assert bob_neuron.trust == 0
 
     # update weights_set_rate_limit for fast-blocks
-    assert sudo_set_hyperparameter_values(
+    status, error = sudo_set_admin_utils(
         local_chain,
         alice_wallet,
         call_function="sudo_set_weights_set_rate_limit",
         call_params={"netuid": netuid, "weights_set_rate_limit": 10},
         return_error_message=True,
     )
 
+    assert error is None
+    assert status is True
+
     async with templates.miner(bob_wallet, netuid):
         async with templates.validator(alice_wallet, netuid) as validator:
             # wait for the Validator to process and set_weights

tests/e2e_tests/test_set_weights.py

@@ -5,7 +5,6 @@
 from bittensor.utils.weight_utils import convert_weights_and_uids_for_emit
 from tests.e2e_tests.utils.chain_interactions import (
     sudo_set_hyperparameter_bool,
-    sudo_set_hyperparameter_values,
     sudo_set_admin_utils,
     wait_epoch,
 )
@@ -84,15 +83,19 @@ async def test_set_weights_uses_next_nonce(local_chain, subtensor, alice_wallet)
         assert (
             subtensor.weights_rate_limit(netuid=netuid) > 0
         ), "Weights rate limit is below 0"
+
         # Lower the rate limit
-        assert sudo_set_hyperparameter_values(
+        status, error = sudo_set_admin_utils(
             local_chain,
             alice_wallet,
             call_function="sudo_set_weights_set_rate_limit",
             call_params={"netuid": netuid, "weights_set_rate_limit": "0"},
             return_error_message=True,
         )
 
+        assert error is None
+        assert status is True
+
         assert (
             subtensor.get_subnet_hyperparameters(netuid=netuid).weights_rate_limit == 0
         ), "Failed to set weights_rate_limit"