Skip to content

Commit 8aa8f4c

Browse files
authored
Merge pull request #2684 from opentensor/feat/thewhaleking/refactor-aenter-logic
Refactor AsyncSubtensor aenter logic
2 parents 4bebb26 + f7a9315 commit 8aa8f4c

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

bittensor/core/async_subtensor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,8 @@ async def __aenter__(self):
173173
f"[magenta]Connecting to Substrate:[/magenta] [blue]{self}[/blue][magenta]...[/magenta]"
174174
)
175175
try:
176-
async with self.substrate:
177-
return self
176+
await self.substrate.initialize()
177+
return self
178178
except TimeoutError:
179179
logging.error(
180180
f"[red]Error[/red]: Timeout occurred connecting to substrate."

tests/unit_tests/test_async_subtensor.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,8 @@ async def test_async_subtensor_magic_methods(mocker):
128128
pass
129129

130130
# Asserts
131-
fake_async_substrate.__aenter__.assert_called_once()
132-
fake_async_substrate.__aexit__.assert_called_once()
133-
fake_async_substrate.close.assert_awaited_once()
131+
fake_async_substrate.initialize.assert_called_once()
132+
fake_async_substrate.close.assert_called_once()
134133

135134

136135
@pytest.mark.parametrize(
@@ -145,7 +144,7 @@ async def test_async_subtensor_aenter_connection_refused_error(
145144
# Preps
146145
fake_async_substrate = mocker.AsyncMock(
147146
autospec=async_subtensor.AsyncSubstrateInterface,
148-
__aenter__=mocker.AsyncMock(side_effect=error),
147+
initialize=mocker.AsyncMock(side_effect=error),
149148
)
150149
mocker.patch.object(
151150
async_subtensor, "AsyncSubstrateInterface", return_value=fake_async_substrate
@@ -158,7 +157,7 @@ async def test_async_subtensor_aenter_connection_refused_error(
158157
pass
159158

160159
# Asserts
161-
fake_async_substrate.__aenter__.assert_called_once()
160+
fake_async_substrate.initialize.assert_awaited_once()
162161

163162

164163
@pytest.mark.asyncio

0 commit comments

Comments
 (0)