PR comments

Author: thewhaleking

bittensor/core/async_subtensor.py

@@ -1331,7 +1331,7 @@ async def get_metagraph_info(
         block: Optional[int] = None,
         block_hash: Optional[str] = None,
         reuse_block: bool = False,
-    ) -> Optional[MetagraphInfo]:
+    ) -> MetagraphInfo:
         """
         Retrieves the MetagraphInfo dataclass from the node for a single subnet (netuid)
 
@@ -1342,6 +1342,9 @@ async def get_metagraph_info(
             block_hash: The hash of blockchain block number for the query. Do not specify if using
                 block or reuse_block
             reuse_block: Whether to reuse the last-used block hash. Do not set if using block_hash or block.
+
+        Returns:
+            MetagraphInfo dataclass
         """
         block_hash = await self.determine_block_hash(block, block_hash, reuse_block)
         if not block_hash and reuse_block:
@@ -1371,6 +1374,9 @@ async def get_all_metagraphs_info(
             block_hash (Optional[str]): The hash of blockchain block number for the query. Do not specify if using
                 block or reuse_block
             reuse_block (bool): Whether to reuse the last-used block hash. Do not set if using block_hash or block.
+
+        Returns:
+            MetagraphInfo dataclass
         """
         block_hash = await self.determine_block_hash(block, block_hash.reuse_block)
         if not block_hash and reuse_block:
@@ -3454,7 +3460,7 @@ async def swap_stake(
         hotkey_ss58: str,
         origin_netuid: int,
         destination_netuid: int,
-        amount: Union[Balance, float],
+        amount: Balance,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = False,
     ) -> bool:

bittensor/core/extrinsics/transfer.py

@@ -1,4 +1,4 @@
-from typing import Union, TYPE_CHECKING
+from typing import TYPE_CHECKING
 
 from bittensor.core.settings import NETWORK_EXPLORER_MAP
 from bittensor.utils.balance import Balance
@@ -19,7 +19,7 @@ def _do_transfer(
     subtensor: "Subtensor",
     wallet: "Wallet",
     destination: str,
-    amount: "Balance",
+    amount: Balance,
     wait_for_inclusion: bool = True,
     wait_for_finalization: bool = False,
 ) -> tuple[bool, str, str]:
@@ -68,7 +68,7 @@ def transfer_extrinsic(
     subtensor: "Subtensor",
     wallet: "Wallet",
     dest: str,
-    amount: Union["Balance", float],
+    amount: Balance,
     transfer_all: bool = False,
     wait_for_inclusion: bool = True,
     wait_for_finalization: bool = False,

bittensor/core/subtensor.py

@@ -549,7 +549,7 @@ def get_all_subnets_info(self, block: Optional[int] = None) -> list["SubnetInfo"
         else:
             return SubnetInfo.list_from_vec_u8(hex_to_bytes(hex_bytes_result))
 
-    def get_balance(self, address: str, block: Optional[int] = None) -> "Balance":
+    def get_balance(self, address: str, block: Optional[int] = None) -> Balance:
         """
         Retrieves the balance for given coldkey.
 
@@ -574,7 +574,7 @@ def get_balances(
         self,
         *addresses: str,
         block: Optional[int] = None,
-    ) -> dict[str, "Balance"]:
+    ) -> dict[str, Balance]:
         """
         Retrieves the balance for given coldkey(s)
 
@@ -905,7 +905,7 @@ def get_delegate_take(
 
     def get_delegated(
         self, coldkey_ss58: str, block: Optional[int] = None
-    ) -> list[tuple["DelegateInfo", "Balance"]]:
+    ) -> list[tuple["DelegateInfo", Balance]]:
         """
         Retrieves a list of delegates and their associated stakes for a given coldkey. This function identifies the
         delegates that a specific account has staked tokens on.
@@ -954,9 +954,7 @@ def get_delegates(self, block: Optional[int] = None) -> list["DelegateInfo"]:
         else:
             return []
 
-    def get_existential_deposit(
-        self, block: Optional[int] = None
-    ) -> Optional["Balance"]:
+    def get_existential_deposit(self, block: Optional[int] = None) -> Optional[Balance]:
         """
         Retrieves the existential deposit amount for the Bittensor blockchain.
         The existential deposit is the minimum amount of TAO required for an account to exist on the blockchain.
@@ -1012,7 +1010,7 @@ def get_hotkey_owner(
         hotkey_owner = val if exists else None
         return hotkey_owner
 
-    def get_minimum_required_stake(self) -> "Balance":
+    def get_minimum_required_stake(self) -> Balance:
         """
         Returns the minimum required stake for nominators in the Subtensor network.
         This method retries the substrate call up to three times with exponential backoff in case of failures.
@@ -1353,7 +1351,7 @@ def get_subnets(self, block: Optional[int] = None) -> list[int]:
 
     def get_total_stake_for_coldkey(
         self, ss58_address: str, block: Optional[int] = None
-    ) -> "Balance":
+    ) -> Balance:
         """
         Returns the total stake held on a coldkey.
 
@@ -1374,7 +1372,7 @@ def get_total_stake_for_coldkey(
 
     def get_total_stake_for_coldkeys(
         self, *ss58_addresses: str, block: Optional[int] = None
-    ) -> dict[str, "Balance"]:
+    ) -> dict[str, Balance]:
         """
         Returns the total stake held on multiple coldkeys.
 
@@ -1406,7 +1404,7 @@ def get_total_stake_for_coldkeys(
 
     def get_total_stake_for_hotkey(
         self, ss58_address: str, block: Optional[int] = None
-    ) -> "Balance":
+    ) -> Balance:
         """
         Returns the total stake held on a hotkey.
 
@@ -1427,7 +1425,7 @@ def get_total_stake_for_hotkey(
 
     def get_total_stake_for_hotkeys(
         self, *ss58_addresses: str, block: Optional[int] = None
-    ) -> dict[str, "Balance"]:
+    ) -> dict[str, Balance]:
         """
         Returns the total stake held on hotkeys.
 
@@ -1468,8 +1466,8 @@ def get_total_subnets(self, block: Optional[int] = None) -> Optional[int]:
         return getattr(result, "value", None)
 
     def get_transfer_fee(
-        self, wallet: "Wallet", dest: str, value: Union["Balance", float, int]
-    ) -> "Balance":
+        self, wallet: "Wallet", dest: str, value: Union[Balance, float, int]
+    ) -> Balance:
         """
         Calculates the transaction fee for transferring tokens from a wallet to a specified destination address. This
             function simulates the transfer to estimate the associated cost, taking into account the current network
@@ -1875,9 +1873,7 @@ def neurons_lite(
         hex_bytes_result = self.query_runtime_api(
             runtime_api="NeuronInfoRuntimeApi",
             method="get_neurons_lite",
-            params=[
-                netuid
-            ],  # TODO check to see if this can accept more than one at a time
+            params=[netuid],
             block=block,
         )
 
@@ -1917,7 +1913,7 @@ def query_identity(self, key: str, block: Optional[int] = None) -> dict:
         except TypeError:
             return {}
 
-    def recycle(self, netuid: int, block: Optional[int] = None) -> Optional["Balance"]:
+    def recycle(self, netuid: int, block: Optional[int] = None) -> Optional[Balance]:
         """
         Retrieves the 'Burn' hyperparameter for a specified subnet. The 'Burn' parameter represents the amount of Tao
             that is effectively recycled within the Bittensor network.
@@ -2766,7 +2762,7 @@ def transfer(
         self,
         wallet: "Wallet",
         dest: str,
-        amount: Union["Balance", float],
+        amount: Balance,
         wait_for_inclusion: bool = True,
         wait_for_finalization: bool = False,
         transfer_all: bool = False,

requirements/prod.txt

@@ -2,8 +2,8 @@ wheel
 setuptools~=70.0.0
 aiohttp~=3.9
 asyncstdlib~=3.13.0
-# bittensor-cli
-bt-decode==0.5.0-a0
+bittensor-cli
+bt-decode==0.4.0
 colorama~=0.4.6
 fastapi~=0.110.1
 munch~=2.5.0
@@ -25,4 +25,4 @@ uvicorn
 websockets>=14.1
 bittensor-commit-reveal>=0.2.0
 bittensor-wallet>=3.0.0
-async-substrate-interface==1.0.0rc7
+async-substrate-interface==1.0.0rc6