Merge branch 'staging' into fix/zyzniewski/unittests_warnings

# Conflicts:
#	tests/unit_tests/extrinsics/test_registration.py

Author: Roman

.circleci/config.yml

@@ -39,7 +39,7 @@ jobs:
             python -m venv .venv
             . .venv/bin/activate
             python -m pip install --upgrade uv
-            uv pip install ruff
+            uv pip install ruff==0.11.5
 
       - save_cache:
           name: Save cached ruff venv

.github/workflows/e2e-subtensor-tests.yaml

@@ -41,7 +41,7 @@ jobs:
           test_files=$(find tests/e2e_tests -name "test*.py" | jq -R -s -c 'split("\n") | map(select(. != ""))')
           # keep it here for future debug
           # test_files=$(find tests/e2e_tests -type f -name "test*.py" | grep -E 'test_(incentive|commit_weights|set_weights)\.py$' | jq -R -s -c 'split("\n") | map(select(. != ""))')
-          echo "::set-output name=test-files::$test_files"
+          echo "test-files=$test_files" >> "$GITHUB_OUTPUT"
         shell: bash
 
   pull-docker-image:
@@ -101,5 +101,26 @@ jobs:
       - name: Load Docker Image
         run: docker load -i subtensor-localnet.tar
 
-      - name: Run tests
-        run: uv run pytest ${{ matrix.test-file }} -s
+#      - name: Run tests
+#        run: uv run pytest ${{ matrix.test-file }} -s
+
+      - name: Run tests with retry
+        run: |
+          set +e
+          for i in 1 2; do
+            echo "🔁 Attempt $i: Running tests"
+            uv run pytest ${{ matrix.test-file }} -s
+            status=$?
+            if [ $status -eq 0 ]; then
+              echo "✅ Tests passed on attempt $i"
+              break
+            else
+              echo "❌ Tests failed on attempt $i"
+              if [ $i -eq 2 ]; then
+                echo "Tests failed after 2 attempts"
+                exit 1
+              fi
+              echo "Retrying..."
+              sleep 5
+            fi
+          done

bittensor/core/async_subtensor.py

@@ -753,6 +753,7 @@ async def does_hotkey_exist(
         return_val = (
             False
             if result is None
+            # not the default key (0x0)
             else result != "5C4hrfjw9DjXZTzV3MwzrrAr9P1MJhSrvWGWqi1eSuyUpnhM"
         )
         return return_val
@@ -3005,7 +3006,7 @@ async def wait_for_block(self, block: Optional[int] = None):
 
         async def handler(block_data: dict):
             logging.debug(
-                f'reached block {block_data["header"]["number"]}. Waiting for block {target_block}'
+                f"reached block {block_data['header']['number']}. Waiting for block {target_block}"
             )
             if block_data["header"]["number"] >= target_block:
                 return True

bittensor/core/axon.py

@@ -504,9 +504,9 @@ def verify_custom(synapse: MyCustomSynapse):
             )
 
         param_class = first_param.annotation
-        assert issubclass(
-            param_class, Synapse
-        ), "The first argument of forward_fn must inherit from bittensor.Synapse"
+        assert issubclass(param_class, Synapse), (
+            "The first argument of forward_fn must inherit from bittensor.Synapse"
+        )
         request_name = param_class.__name__
 
         async def endpoint(*args, **kwargs):
@@ -580,19 +580,19 @@ async def endpoint(*args, **kwargs):
             blacklist_sig = Signature(
                 expected_params, return_annotation=Tuple[bool, str]
             )
-            assert (
-                signature(blacklist_fn) == blacklist_sig
-            ), f"The blacklist_fn function must have the signature: blacklist( synapse: {request_name} ) -> tuple[bool, str]"
+            assert signature(blacklist_fn) == blacklist_sig, (
+                f"The blacklist_fn function must have the signature: blacklist( synapse: {request_name} ) -> tuple[bool, str]"
+            )
         if priority_fn:
             priority_sig = Signature(expected_params, return_annotation=float)
-            assert (
-                signature(priority_fn) == priority_sig
-            ), f"The priority_fn function must have the signature: priority( synapse: {request_name} ) -> float"
+            assert signature(priority_fn) == priority_sig, (
+                f"The priority_fn function must have the signature: priority( synapse: {request_name} ) -> float"
+            )
         if verify_fn:
             verify_sig = Signature(expected_params, return_annotation=None)
-            assert (
-                signature(verify_fn) == verify_sig
-            ), f"The verify_fn function must have the signature: verify( synapse: {request_name} ) -> None"
+            assert signature(verify_fn) == verify_sig, (
+                f"The verify_fn function must have the signature: verify( synapse: {request_name} ) -> None"
+            )
 
         # Store functions in appropriate attribute dictionaries
         self.forward_class_types[request_name] = param_class
@@ -747,9 +747,9 @@ def check_config(cls, config: "Config"):
         Raises:
             AssertionError: If the axon or external ports are not in range [1024, 65535]
         """
-        assert (
-            1024 < config.axon.port < 65535
-        ), "Axon port must be in range [1024, 65535]"
+        assert 1024 < config.axon.port < 65535, (
+            "Axon port must be in range [1024, 65535]"
+        )
 
         assert config.axon.external_port is None or (
             1024 < config.axon.external_port < 65535

bittensor/core/extrinsics/asyncex/staking.py

@@ -127,7 +127,7 @@ async def add_stake_extrinsic(
             logging.info(
                 f":satellite: [magenta]Safe Staking to:[/magenta] "
                 f"[blue]netuid: [green]{netuid}[/green], amount: [green]{staking_balance}[/green], "
-                f"tolerance percentage: [green]{rate_tolerance*100}%[/green], "
+                f"tolerance percentage: [green]{rate_tolerance * 100}%[/green], "
                 f"price limit: [green]{rate_with_tolerance}[/green], "
                 f"original price: [green]{base_rate}[/green], "
                 f"with partial stake: [green]{allow_partial_stake}[/green] "

bittensor/core/extrinsics/asyncex/start_call.py

@@ -1,6 +1,6 @@
 from typing import TYPE_CHECKING
 
-from bittensor.utils import unlock_key
+from bittensor.utils import unlock_key, format_error_message
 from bittensor.utils.btlogging import logging
 
 if TYPE_CHECKING:
@@ -58,4 +58,4 @@ async def start_call_extrinsic(
         if await response.is_success:
             return True, "Success with `start_call` response."
 
-        return False, await response.error_message
+        return False, format_error_message(await response.error_message)

bittensor/core/extrinsics/asyncex/unstaking.py

@@ -106,7 +106,7 @@ async def unstake_extrinsic(
             logging.info(
                 f":satellite: [magenta]Safe Unstaking from:[/magenta] "
                 f"netuid: [green]{netuid}[/green], amount: [green]{unstaking_balance}[/green], "
-                f"tolerance percentage: [green]{rate_tolerance*100}%[/green], "
+                f"tolerance percentage: [green]{rate_tolerance * 100}%[/green], "
                 f"price limit: [green]{rate_with_tolerance}[/green], "
                 f"original price: [green]{base_rate}[/green], "
                 f"with partial unstake: [green]{allow_partial_stake}[/green] "

bittensor/core/extrinsics/staking.py

@@ -115,7 +115,7 @@ def add_stake_extrinsic(
             logging.info(
                 f":satellite: [magenta]Safe Staking to:[/magenta] "
                 f"[blue]netuid: [green]{netuid}[/green], amount: [green]{staking_balance}[/green], "
-                f"tolerance percentage: [green]{rate_tolerance*100}%[/green], "
+                f"tolerance percentage: [green]{rate_tolerance * 100}%[/green], "
                 f"price limit: [green]{rate_with_tolerance}[/green], "
                 f"original price: [green]{base_rate}[/green], "
                 f"with partial stake: [green]{allow_partial_stake}[/green] "

bittensor/core/extrinsics/start_call.py

@@ -1,6 +1,6 @@
 from typing import TYPE_CHECKING
 
-from bittensor.utils import unlock_key
+from bittensor.utils import unlock_key, format_error_message
 from bittensor.utils.btlogging import logging
 
 if TYPE_CHECKING:
@@ -59,4 +59,4 @@ def start_call_extrinsic(
         if response.is_success:
             return True, "Success with `start_call` response."
 
-        return False, response.error_message
+        return False, format_error_message(response.error_message)

bittensor/core/extrinsics/unstaking.py

@@ -103,7 +103,7 @@ def unstake_extrinsic(
             logging.info(
                 f":satellite: [magenta]Safe Unstaking from:[/magenta] "
                 f"netuid: [green]{netuid}[/green], amount: [green]{unstaking_balance}[/green], "
-                f"tolerance percentage: [green]{rate_tolerance*100}%[/green], "
+                f"tolerance percentage: [green]{rate_tolerance * 100}%[/green], "
                 f"price limit: [green]{rate_with_tolerance}[/green], "
                 f"original price: [green]{base_rate}[/green], "
                 f"with partial unstake: [green]{allow_partial_stake}[/green] "