Merge pull request #3204 from opentensor/feat/roman/add-warning-for-mev-hk-usage

[v10] Add warning about MeV HK usage

Author: basfroman

bittensor/core/extrinsics/asyncex/serving.py

@@ -4,6 +4,7 @@
 from bittensor.core.errors import MetadataError
 from bittensor.core.extrinsics.asyncex.mev_shield import submit_encrypted_extrinsic
 from bittensor.core.extrinsics.pallets import Commitments, SubtensorModule
+from bittensor.core.extrinsics.utils import MEV_HOTKEY_USAGE_WARNING
 from bittensor.core.settings import DEFAULT_MEV_PROTECTION, version_as_int
 from bittensor.core.types import AxonServeCallParams, ExtrinsicResponse
 from bittensor.utils import (
@@ -108,6 +109,7 @@ async def serve_extrinsic(
         call = await call_function(**params.as_dict())
 
         if mev_protection:
+            logging.warning(MEV_HOTKEY_USAGE_WARNING)
             response = await submit_encrypted_extrinsic(
                 subtensor=subtensor,
                 wallet=wallet,
@@ -291,6 +293,7 @@ async def publish_metadata_extrinsic(
         call = await Commitments(subtensor).set_commitment(netuid=netuid, info=info)
 
         if mev_protection:
+            logging.warning(MEV_HOTKEY_USAGE_WARNING)
             response = await submit_encrypted_extrinsic(
                 subtensor=subtensor,
                 wallet=wallet,

bittensor/core/extrinsics/asyncex/weights.py

@@ -6,6 +6,7 @@
 
 from bittensor.core.extrinsics.asyncex.mev_shield import submit_encrypted_extrinsic
 from bittensor.core.extrinsics.pallets import SubtensorModule
+from bittensor.core.extrinsics.utils import MEV_HOTKEY_USAGE_WARNING
 from bittensor.core.settings import DEFAULT_MEV_PROTECTION, version_as_int
 from bittensor.core.types import ExtrinsicResponse, Salt, UIDs, Weights
 from bittensor.utils import get_mechid_storage_index
@@ -107,6 +108,7 @@ async def commit_timelocked_weights_extrinsic(
         )
 
         if mev_protection:
+            logging.warning(MEV_HOTKEY_USAGE_WARNING)
             response = await submit_encrypted_extrinsic(
                 subtensor=subtensor,
                 wallet=wallet,
@@ -215,6 +217,7 @@ async def commit_weights_extrinsic(
         )
 
         if mev_protection:
+            logging.warning(MEV_HOTKEY_USAGE_WARNING)
             response = await submit_encrypted_extrinsic(
                 subtensor=subtensor,
                 wallet=wallet,
@@ -315,6 +318,7 @@ async def reveal_weights_extrinsic(
         )
 
         if mev_protection:
+            logging.warning(MEV_HOTKEY_USAGE_WARNING)
             response = await submit_encrypted_extrinsic(
                 subtensor=subtensor,
                 wallet=wallet,
@@ -412,6 +416,7 @@ async def set_weights_extrinsic(
         )
 
         if mev_protection:
+            logging.warning(MEV_HOTKEY_USAGE_WARNING)
             response = await submit_encrypted_extrinsic(
                 subtensor=subtensor,
                 wallet=wallet,

bittensor/core/extrinsics/serving.py

@@ -3,6 +3,7 @@
 from bittensor.core.errors import MetadataError
 from bittensor.core.extrinsics.mev_shield import submit_encrypted_extrinsic
 from bittensor.core.extrinsics.pallets import Commitments, SubtensorModule
+from bittensor.core.extrinsics.utils import MEV_HOTKEY_USAGE_WARNING
 from bittensor.core.settings import DEFAULT_MEV_PROTECTION, version_as_int
 from bittensor.core.types import AxonServeCallParams, ExtrinsicResponse
 from bittensor.utils import (
@@ -106,6 +107,7 @@ def serve_extrinsic(
         call = call_function(**params.as_dict())
 
         if mev_protection:
+            logging.warning(MEV_HOTKEY_USAGE_WARNING)
             response = submit_encrypted_extrinsic(
                 subtensor=subtensor,
                 wallet=wallet,
@@ -286,6 +288,7 @@ def publish_metadata_extrinsic(
         call = Commitments(subtensor).set_commitment(netuid=netuid, info=info)
 
         if mev_protection:
+            logging.warning(MEV_HOTKEY_USAGE_WARNING)
             response = submit_encrypted_extrinsic(
                 subtensor=subtensor,
                 wallet=wallet,

bittensor/core/extrinsics/utils.py

@@ -10,6 +10,14 @@
 from bittensor.core.types import ExtrinsicResponse
 from bittensor.utils.balance import Balance
 
+
+# TODO: Michael/Roman add the link to the docs once it's ready.'
+MEV_HOTKEY_USAGE_WARNING = (
+    "MeV Shield cannot be used with hotkey-signed extrinsics. The transaction will fail because the hotkey cannot pay "
+    "the required extrinsic deposit fee. If you still want to use the hot key, please top up your balance before making"
+    " the transaction."
+)
+
 if TYPE_CHECKING:
     from bittensor_wallet import Wallet
     from bittensor.core.chain_data import StakeInfo

bittensor/core/extrinsics/weights.py

@@ -6,6 +6,7 @@
 
 from bittensor.core.extrinsics.mev_shield import submit_encrypted_extrinsic
 from bittensor.core.extrinsics.pallets import SubtensorModule
+from bittensor.core.extrinsics.utils import MEV_HOTKEY_USAGE_WARNING
 from bittensor.core.settings import DEFAULT_MEV_PROTECTION, version_as_int
 from bittensor.core.types import ExtrinsicResponse, Salt, UIDs, Weights
 from bittensor.utils import get_mechid_storage_index
@@ -108,6 +109,7 @@ def commit_timelocked_weights_extrinsic(
         )
 
         if mev_protection:
+            logging.warning(MEV_HOTKEY_USAGE_WARNING)
             response = submit_encrypted_extrinsic(
                 subtensor=subtensor,
                 wallet=wallet,
@@ -216,6 +218,7 @@ def commit_weights_extrinsic(
         )
 
         if mev_protection:
+            logging.warning(MEV_HOTKEY_USAGE_WARNING)
             response = submit_encrypted_extrinsic(
                 subtensor=subtensor,
                 wallet=wallet,
@@ -316,6 +319,7 @@ def reveal_weights_extrinsic(
         )
 
         if mev_protection:
+            logging.warning(MEV_HOTKEY_USAGE_WARNING)
             response = submit_encrypted_extrinsic(
                 subtensor=subtensor,
                 wallet=wallet,
@@ -413,6 +417,7 @@ def set_weights_extrinsic(
         )
 
         if mev_protection:
+            logging.warning(MEV_HOTKEY_USAGE_WARNING)
             response = submit_encrypted_extrinsic(
                 subtensor=subtensor,
                 wallet=wallet,