Merge branch 'staging' into master

Author: HudsonGraeme

.github/workflows/release.yml

@@ -45,7 +45,7 @@ jobs:
         fi
 
     - name: Upload artifact
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: dist
         path: dist/
@@ -60,7 +60,7 @@ jobs:
 
     steps:
     - name: Download artifact
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: dist
         path: dist/

bittensor/core/axon.py

@@ -142,14 +142,6 @@ def run_in_thread(self):
             self.should_exit = True
             thread.join()
 
-    def _wrapper_run(self):
-        """
-        A wrapper method for the :func:`run_in_thread` context manager. This method is used internally by the ``start`` method to initiate the server's execution in a separate thread.
-        """
-        with self.run_in_thread():
-            while not self.should_exit:
-                time.sleep(1e-3)
-
     def start(self):
         """
         Starts the FastAPI server in a separate thread if it is not already running. This method sets up the server to handle HTTP requests concurrently, enabling the Axon server to efficiently manage incoming network requests.
@@ -158,7 +150,7 @@ def start(self):
         """
         if not self.is_running:
             self.should_exit = False
-            thread = threading.Thread(target=self._wrapper_run, daemon=True)
+            thread = threading.Thread(target=self.run, daemon=True)
             thread.start()
             self.is_running = True
 
@@ -377,7 +369,11 @@ def __init__(
         self.app = FastAPI()
         log_level = "trace" if logging.__trace_on__ else "critical"
         self.fast_config = uvicorn.Config(
-            self.app, host="0.0.0.0", port=self.config.axon.port, log_level=log_level
+            self.app,
+            host="0.0.0.0",
+            log_level=log_level,
+            loop="none",
+            port=self.config.axon.port,
         )
         self.fast_server = FastAPIThreadedServer(config=self.fast_config)
         self.router = APIRouter()

bittensor/core/extrinsics/async_commit_reveal.py

@@ -143,7 +143,7 @@ async def commit_reveal_v3_extrinsic(
             return False, message
 
         logging.success(
-            f"[green]Finalized![/green] Weights commited with reveal round [blue]{reveal_round}[/blue]."
+            f"[green]Finalized![/green] Weights committed with reveal round [blue]{reveal_round}[/blue]."
         )
         return True, f"reveal_round:{reveal_round}"
 

bittensor/core/extrinsics/commit_reveal.py

@@ -145,7 +145,7 @@ def commit_reveal_v3_extrinsic(
 
         if success is True:
             logging.success(
-                f"[green]Finalized![/green] Weights commited with reveal round [blue]{reveal_round}[/blue]."
+                f"[green]Finalized![/green] Weights committed with reveal round [blue]{reveal_round}[/blue]."
             )
             return True, f"reveal_round:{reveal_round}"
         else:

bittensor/core/metagraph.py

@@ -554,7 +554,7 @@ def sync(
         NOTE:
             If attempting to access data beyond the previous 300 blocks, you **must** use the ``archive`` network for subtensor. Light nodes are configured only to store the previous 300 blocks if connecting to finney or test networks.
 
-            For example::
+            For example:
 
                 from bittensor.core.subtensor import Subtensor
 
@@ -1112,7 +1112,7 @@ def load_from_path(self, dir_path: str) -> "Metagraph":
         Returns:
             metagraph (bittensor.core.metagraph.Metagraph): The current metagraph instance with the loaded state.
 
-        Example::
+        Example:
 
             from bittensor.core.metagraph import Metagraph
 

bittensor/utils/btlogging/loggingmachine.py

@@ -582,6 +582,10 @@ def get_level(self) -> int:
         """Returns Logging level."""
         return self._logger.level
 
+    def setLevel(self, level):
+        """Set the specified level on the underlying logger."""
+        self._logger.setLevel(level)
+
     def check_config(self, config: "Config"):
         assert config.logging
 

bittensor/utils/networking.py

@@ -34,7 +34,7 @@ def int_to_ip(int_val: int) -> str:
 def ip_to_int(str_val: str) -> int:
     """Maps an ip-string to a unique integer.
     arg:
-        str_val (:tyep:`str`, `required):
+        str_val (:type:`str`, `required):
             The string representation of an ip. Of form *.*.*.* for ipv4 or *::*:*:*:* for ipv6
 
     Returns:
@@ -51,7 +51,7 @@ def ip_to_int(str_val: str) -> int:
 def ip_version(str_val: str) -> int:
     """Returns the ip version (IPV4 or IPV6).
     arg:
-        str_val (:tyep:`str`, `required):
+        str_val (:type:`str`, `required):
             The string representation of an ip. Of form *.*.*.* for ipv4 or *::*:*:*:* for ipv6
 
     Returns:

requirements/dev.txt

@@ -12,7 +12,7 @@ flake8==7.0.0
 mypy==1.8.0
 types-retry==0.9.9.4
 freezegun==1.5.0
-torch>=1.13.1
+torch==2.5.1
 httpx==0.27.0
 ruff==0.4.7
 aioresponses==0.7.6

requirements/torch.txt

@@ -1 +1 @@
-torch>=1.13.1
+torch==2.5.1

tests/unit_tests/test_axon.py

@@ -17,20 +17,23 @@
 
 
 import re
+import threading
 import time
 from dataclasses import dataclass
 from typing import Any, Optional, Tuple
 from unittest import IsolatedAsyncioTestCase
 from unittest.mock import AsyncMock, MagicMock, patch
 
+import aiohttp
 import fastapi
 import netaddr
 import pydantic
 import pytest
+import uvicorn
 from fastapi.testclient import TestClient
 from starlette.requests import Request
 
-from bittensor.core.axon import AxonMiddleware, Axon
+from bittensor.core.axon import Axon, AxonMiddleware, FastAPIThreadedServer
 from bittensor.core.errors import RunException
 from bittensor.core.settings import version_as_int
 from bittensor.core.stream import StreamingSynapse
@@ -785,3 +788,45 @@ async def forward_fn(synapse: streaming_synapse_cls):
                 "computed_body_hash": "a7ffc6f8bf1ed76651c14756a061d662f580ff4de43b49fa82d80a4b80f8434a",
             },
         )
+
+
+@pytest.mark.asyncio
+async def test_threaded_fastapi():
+    server_started = threading.Event()
+    server_stopped = threading.Event()
+
+    async def lifespan(app):
+        server_started.set()
+        yield
+        server_stopped.set()
+
+    app = fastapi.FastAPI(
+        lifespan=lifespan,
+    )
+    app.get("/")(lambda: "Hello World")
+
+    server = FastAPIThreadedServer(
+        uvicorn.Config(
+            app,
+        ),
+    )
+    server.start()
+
+    server_started.wait()
+
+    assert server.is_running is True
+
+    async with aiohttp.ClientSession(
+        base_url="http://127.0.0.1:8000",
+    ) as session:
+        async with session.get("/") as response:
+            assert await response.text() == '"Hello World"'
+
+        server.stop()
+
+        assert server.should_exit is True
+
+        server_stopped.wait()
+
+        with pytest.raises(aiohttp.ClientConnectorError):
+            await session.get("/")