Tests

Author: thewhaleking

bittensor/core/extrinsics/asyncex/transfer.py

@@ -53,7 +53,7 @@ async def _do_transfer(
         else:
             call_params["keep_alive"] = False
     else:
-        call_params["amount"] = amount.rao
+        call_params["value"] = amount.rao
         if keep_alive:
             call_function = "transfer_keep_alive"
         else:

tests/unit_tests/extrinsics/asyncex/test_transfer.py

@@ -3,12 +3,32 @@
 from bittensor.utils.balance import Balance
 
 
+@pytest.mark.parametrize(
+    "amount,keep_alive,call_function,call_params",
+    [
+        (
+            Balance(1),
+            True,
+            "transfer_keep_alive",
+            {"dest": "SS58PUBLICKEY", "value": Balance(1).rao},
+        ),
+        (None, True, "transfer_all", {"dest": "SS58PUBLICKEY", "keep_alive": True}),
+        (None, False, "transfer_all", {"dest": "SS58PUBLICKEY", "keep_alive": False}),
+        (
+            Balance(1),
+            False,
+            "transfer_allow_death",
+            {"dest": "SS58PUBLICKEY", "value": Balance(1).rao},
+        ),
+    ],
+)
 @pytest.mark.asyncio
-async def test_do_transfer_success(subtensor, fake_wallet, mocker):
+async def test_do_transfer_success(
+    subtensor, fake_wallet, mocker, amount, keep_alive, call_function, call_params
+):
     """Tests _do_transfer when the transfer is successful."""
     # Preps
-    fake_destination = "destination_address"
-    fake_amount = mocker.Mock(autospec=Balance, rao=1000)
+    fake_destination = "SS58PUBLICKEY"
     fake_block_hash = "fake_block_hash"
 
     mocker.patch.object(subtensor.substrate, "compose_call")
@@ -24,16 +44,17 @@ async def test_do_transfer_success(subtensor, fake_wallet, mocker):
         subtensor=subtensor,
         wallet=fake_wallet,
         destination=fake_destination,
-        amount=fake_amount,
+        amount=amount,
+        keep_alive=keep_alive,
         wait_for_inclusion=True,
         wait_for_finalization=True,
     )
 
     # Asserts
     subtensor.substrate.compose_call.assert_awaited_once_with(
         call_module="Balances",
-        call_function="transfer_keep_alive",
-        call_params={"dest": fake_destination, "value": fake_amount.rao},
+        call_function=call_function,
+        call_params=call_params,
     )
 
     subtensor.sign_and_send_extrinsic.assert_awaited_once_with(

tests/unit_tests/extrinsics/test_transfer.py

@@ -1,12 +1,34 @@
 from bittensor.core.extrinsics.transfer import _do_transfer
 from bittensor.utils.balance import Balance
 
-
-def test_do_transfer_is_success_true(subtensor, fake_wallet, mocker):
+import pytest
+
+
+@pytest.mark.parametrize(
+    "amount,keep_alive,call_function,call_params",
+    [
+        (
+            Balance(1),
+            True,
+            "transfer_keep_alive",
+            {"dest": "SS58PUBLICKEY", "value": Balance(1).rao},
+        ),
+        (None, True, "transfer_all", {"dest": "SS58PUBLICKEY", "keep_alive": True}),
+        (None, False, "transfer_all", {"dest": "SS58PUBLICKEY", "keep_alive": False}),
+        (
+            Balance(1),
+            False,
+            "transfer_allow_death",
+            {"dest": "SS58PUBLICKEY", "value": Balance(1).rao},
+        ),
+    ],
+)
+def test_do_transfer_is_success_true(
+    subtensor, fake_wallet, mocker, amount, keep_alive, call_function, call_params
+):
     """Successful do_transfer call."""
     # Prep
     fake_dest = "SS58PUBLICKEY"
-    fake_transfer_balance = Balance(1)
     fake_wait_for_inclusion = True
     fake_wait_for_finalization = True
 
@@ -18,16 +40,17 @@ def test_do_transfer_is_success_true(subtensor, fake_wallet, mocker):
         subtensor,
         fake_wallet,
         fake_dest,
-        fake_transfer_balance,
+        amount,
+        keep_alive,
         fake_wait_for_inclusion,
         fake_wait_for_finalization,
     )
 
     # Asserts
     subtensor.substrate.compose_call.assert_called_once_with(
         call_module="Balances",
-        call_function="transfer_keep_alive",
-        call_params={"dest": fake_dest, "value": fake_transfer_balance.rao},
+        call_function=call_function,
+        call_params=call_params,
     )
     subtensor.sign_and_send_extrinsic.assert_called_once_with(
         call=subtensor.substrate.compose_call.return_value,
@@ -45,6 +68,7 @@ def test_do_transfer_is_success_false(subtensor, fake_wallet, mocker):
     # Prep
     fake_dest = "SS58PUBLICKEY"
     fake_transfer_balance = Balance(1)
+    keep_alive = True
     fake_wait_for_inclusion = True
     fake_wait_for_finalization = True
 
@@ -57,6 +81,7 @@ def test_do_transfer_is_success_false(subtensor, fake_wallet, mocker):
         fake_wallet,
         fake_dest,
         fake_transfer_balance,
+        keep_alive,
         fake_wait_for_inclusion,
         fake_wait_for_finalization,
     )
@@ -83,6 +108,7 @@ def test_do_transfer_no_waits(subtensor, fake_wallet, mocker):
     # Prep
     fake_dest = "SS58PUBLICKEY"
     fake_transfer_balance = Balance(1)
+    keep_alive = True
     fake_wait_for_inclusion = False
     fake_wait_for_finalization = False
 
@@ -96,6 +122,7 @@ def test_do_transfer_no_waits(subtensor, fake_wallet, mocker):
         fake_wallet,
         fake_dest,
         fake_transfer_balance,
+        keep_alive,
         fake_wait_for_inclusion,
         fake_wait_for_finalization,
     )