Skip to content

Commit e51ad47

Browse files
authored
Merge pull request #3006 from opentensor/fix/thewhaleking/error-formatter
Format Error with string docs
2 parents 0e4ef47 + 198d5ab commit e51ad47

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

bittensor/utils/__init__.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,9 @@ def format_error_message(error_message: Union[dict, Exception]) -> str:
255255
err_type = error_message.get("type", err_type)
256256
err_name = error_message.get("name", err_name)
257257
err_docs = error_message.get("docs", [err_description])
258-
err_description = " ".join(err_docs)
258+
err_description = (
259+
err_docs if isinstance(err_docs, str) else " ".join(err_docs)
260+
)
259261
err_description += (
260262
f" | Please consult {BT_DOCS_LINK}/errors/subtensor#{err_name.lower()}"
261263
)

tests/unit_tests/extrinsics/test__init__.py

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,3 +102,22 @@ def test_format_error_message_with_custom_error_message_without_index():
102102
== f"Subtensor returned `SubstrateRequestException({fake_custom_error['message']})` error. This means: "
103103
f"`{fake_custom_error['data']}`."
104104
)
105+
106+
107+
def test_format_error_with_string_docs():
108+
fake_error_message = {
109+
"type": "SomeType",
110+
"name": "SomeErrorName",
111+
"docs": "Some error description.",
112+
}
113+
114+
# Call
115+
result = format_error_message(fake_error_message)
116+
117+
# Assertions
118+
119+
assert (
120+
result == "Subtensor returned `SomeErrorName(SomeType)` error. "
121+
"This means: `Some error description."
122+
f" | Please consult {BT_DOCS_LINK}/errors/subtensor#someerrorname`."
123+
)

0 commit comments

Comments
 (0)