Merge pull request #2900 from opentensor/feat/roman/replace-transfer_allow_death-with-transfer_keep_alive

basfroman · web-flow · commit f4abe88d8518 · 2025-05-29T12:52:20.000-07:00
Replace `transfer_allow_death` with `transfer_keep_alive`
diff --git a/bittensor/core/async_subtensor.py b/bittensor/core/async_subtensor.py
@@ -2322,7 +2322,7 @@ async def get_transfer_fee(
 
         call = await self.substrate.compose_call(
             call_module="Balances",
-            call_function="transfer_allow_death",
+            call_function="transfer_keep_alive",
             call_params={"dest": dest, "value": value.rao},
         )
 
diff --git a/bittensor/core/extrinsics/asyncex/transfer.py b/bittensor/core/extrinsics/asyncex/transfer.py
@@ -45,7 +45,7 @@ async def _do_transfer(
     """
     call = await subtensor.substrate.compose_call(
         call_module="Balances",
-        call_function="transfer_allow_death",
+        call_function="transfer_keep_alive",
         call_params={"dest": destination, "value": amount.rao},
     )
 
diff --git a/bittensor/core/extrinsics/transfer.py b/bittensor/core/extrinsics/transfer.py
@@ -44,7 +44,7 @@ def _do_transfer(
     """
     call = subtensor.substrate.compose_call(
         call_module="Balances",
-        call_function="transfer_allow_death",
+        call_function="transfer_keep_alive",
         call_params={"dest": destination, "value": amount.rao},
     )
 
diff --git a/bittensor/core/subtensor.py b/bittensor/core/subtensor.py
@@ -1831,7 +1831,7 @@ def get_transfer_fee(self, wallet: "Wallet", dest: str, value: Balance) -> Balan
         value = check_and_convert_to_balance(value)
         call = self.substrate.compose_call(
             call_module="Balances",
-            call_function="transfer_allow_death",
+            call_function="transfer_keep_alive",
             call_params={"dest": dest, "value": value.rao},
         )
 
diff --git a/tests/unit_tests/extrinsics/asyncex/test_transfer.py b/tests/unit_tests/extrinsics/asyncex/test_transfer.py
@@ -32,7 +32,7 @@ async def test_do_transfer_success(subtensor, fake_wallet, mocker):
     # Asserts
     subtensor.substrate.compose_call.assert_awaited_once_with(
         call_module="Balances",
-        call_function="transfer_allow_death",
+        call_function="transfer_keep_alive",
         call_params={"dest": fake_destination, "value": fake_amount.rao},
     )
 
@@ -77,7 +77,7 @@ async def test_do_transfer_failure(subtensor, fake_wallet, mocker):
     # Asserts
     subtensor.substrate.compose_call.assert_awaited_once_with(
         call_module="Balances",
-        call_function="transfer_allow_death",
+        call_function="transfer_keep_alive",
         call_params={"dest": fake_destination, "value": fake_amount.rao},
     )
 
@@ -124,7 +124,7 @@ async def test_do_transfer_no_waiting(subtensor, fake_wallet, mocker):
     # Asserts
     subtensor.substrate.compose_call.assert_awaited_once_with(
         call_module="Balances",
-        call_function="transfer_allow_death",
+        call_function="transfer_keep_alive",
         call_params={"dest": fake_destination, "value": fake_amount.rao},
     )
 
diff --git a/tests/unit_tests/extrinsics/test_transfer.py b/tests/unit_tests/extrinsics/test_transfer.py
@@ -26,7 +26,7 @@ def test_do_transfer_is_success_true(subtensor, fake_wallet, mocker):
     # Asserts
     subtensor.substrate.compose_call.assert_called_once_with(
         call_module="Balances",
-        call_function="transfer_allow_death",
+        call_function="transfer_keep_alive",
         call_params={"dest": fake_dest, "value": fake_transfer_balance.rao},
     )
     subtensor.sign_and_send_extrinsic.assert_called_once_with(
@@ -64,7 +64,7 @@ def test_do_transfer_is_success_false(subtensor, fake_wallet, mocker):
     # Asserts
     subtensor.substrate.compose_call.assert_called_once_with(
         call_module="Balances",
-        call_function="transfer_allow_death",
+        call_function="transfer_keep_alive",
         call_params={"dest": fake_dest, "value": fake_transfer_balance.rao},
     )
     subtensor.sign_and_send_extrinsic.assert_called_once_with(
@@ -103,7 +103,7 @@ def test_do_transfer_no_waits(subtensor, fake_wallet, mocker):
     # Asserts
     subtensor.substrate.compose_call.assert_called_once_with(
         call_module="Balances",
-        call_function="transfer_allow_death",
+        call_function="transfer_keep_alive",
         call_params={"dest": fake_dest, "value": fake_transfer_balance.rao},
     )
     subtensor.sign_and_send_extrinsic.assert_called_once_with(
diff --git a/tests/unit_tests/test_async_subtensor.py b/tests/unit_tests/test_async_subtensor.py
@@ -707,7 +707,7 @@ async def test_get_transfer_fee(subtensor, fake_wallet, mocker, balance):
     mocked_compose_call.assert_awaited_once()
     mocked_compose_call.assert_called_once_with(
         call_module="Balances",
-        call_function="transfer_allow_death",
+        call_function="transfer_keep_alive",
         call_params={
             "dest": fake_dest,
             "value": fake_value.rao,
diff --git a/tests/unit_tests/test_subtensor.py b/tests/unit_tests/test_subtensor.py
@@ -1877,7 +1877,7 @@ def test_get_transfer_fee(subtensor, fake_wallet, mocker):
     # Asserts
     subtensor.substrate.compose_call.assert_called_once_with(
         call_module="Balances",
-        call_function="transfer_allow_death",
+        call_function="transfer_keep_alive",
         call_params={"dest": fake_dest, "value": value.rao},
     )
 

Original file line number	Diff line number	Diff line change
`@@ -2322,7 +2322,7 @@ async def get_transfer_fee(`
`2322`	`2322`
`2323`	`2323`	`call = await self.substrate.compose_call(`
`2324`	`2324`	`call_module="Balances",`
`2325`		`- call_function="transfer_allow_death",`
	`2325`	`+ call_function="transfer_keep_alive",`
`2326`	`2326`	`call_params={"dest": dest, "value": value.rao},`
`2327`	`2327`	`)`
`2328`	`2328`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ async def _do_transfer(`
`45`	`45`	`"""`
`46`	`46`	`call = await subtensor.substrate.compose_call(`
`47`	`47`	`call_module="Balances",`
`48`		`- call_function="transfer_allow_death",`
	`48`	`+ call_function="transfer_keep_alive",`
`49`	`49`	`call_params={"dest": destination, "value": amount.rao},`
`50`	`50`	`)`
`51`	`51`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ def _do_transfer(`
`44`	`44`	`"""`
`45`	`45`	`call = subtensor.substrate.compose_call(`
`46`	`46`	`call_module="Balances",`
`47`		`- call_function="transfer_allow_death",`
	`47`	`+ call_function="transfer_keep_alive",`
`48`	`48`	`call_params={"dest": destination, "value": amount.rao},`
`49`	`49`	`)`
`50`	`50`
Original file line number	Diff line number	Diff line change
`@@ -1831,7 +1831,7 @@ def get_transfer_fee(self, wallet: "Wallet", dest: str, value: Balance) -> Balan`
`1831`	`1831`	`value = check_and_convert_to_balance(value)`
`1832`	`1832`	`call = self.substrate.compose_call(`
`1833`	`1833`	`call_module="Balances",`
`1834`		`- call_function="transfer_allow_death",`
	`1834`	`+ call_function="transfer_keep_alive",`
`1835`	`1835`	`call_params={"dest": dest, "value": value.rao},`
`1836`	`1836`	`)`
`1837`	`1837`
Original file line number	Diff line number	Diff line change
`@@ -1877,7 +1877,7 @@ def test_get_transfer_fee(subtensor, fake_wallet, mocker):`
`1877`	`1877`	`# Asserts`
`1878`	`1878`	`subtensor.substrate.compose_call.assert_called_once_with(`
`1879`	`1879`	`call_module="Balances",`
`1880`		`- call_function="transfer_allow_death",`
	`1880`	`+ call_function="transfer_keep_alive",`
`1881`	`1881`	`call_params={"dest": fake_dest, "value": value.rao},`
`1882`	`1882`	`)`
`1883`	`1883`