Merge branch 'staging' into changelog/9.11.0

Author: thewhaleking

README.md

@@ -174,6 +174,22 @@ BTCLI accepts a few environment variables that can alter how it works:
  - DISK_CACHE (default 0, also settable in config): If set to 1 (or set in config), will use disk caching for various safe-cachable substrate
 calls (such as block number to block hash mapping), which can speed up subsequent calls.
  - BTCLI_CONFIG_PATH (default `~/.bittensor/config.yml`): This will set the config file location, creating if it does not exist.
+ - BTCLI_DEBUG_FILE (default `~/.bittensor/debug.txt`): The file stores the most recent's command's debug log. 
+
+---
+
+## Debugging
+BTCLI will store a debug log for every command run. This file is overwritten for each new command run. The default location
+of this file is `~/.bittensor/debug.txt` and can be set with the `BTCLI_DEBUG_FILE` env var (see above section).
+
+The debug log will **NOT** contain any sensitive data (private keys), and is intended to be sent to the developers
+for debugging. This file contains basic information about the command being run, the config, and the back and forth of requests and responses
+to and from the chain.
+
+If you encounter an issue, and would like to save the file somewhere it won't be overwritten, run `btcli --debug`,
+and set the save file location. We recommend doing this first before anything, and then starting your debugging with
+us on our [Discord](https://discord.gg/bittensor), or by opening an issue on [GitHub](https://github.com/opentensor/btcli/issues/new) 
+(where you can also upload your debug file).
 
 ---
 

bittensor_cli/cli.py

@@ -89,6 +89,7 @@ class Defaults:
     class config:
         base_path = "~/.bittensor"
         path = "~/.bittensor/config.yml"
+        debug_file_path = "~/.bittensor/debug.txt"
         dictionary = {
             "network": None,
             "wallet_path": None,

bittensor_cli/src/__init__.py

@@ -269,10 +269,26 @@ def get_hotkey_wallets_for_wallet(
     except FileNotFoundError:
         hotkeys = []
     for h_name in hotkeys:
-        hotkey_for_name = Wallet(path=str(wallet_path), name=wallet.name, hotkey=h_name)
+        if h_name.endswith("pub.txt"):
+            if h_name.split("pub.txt")[0] in hotkeys:
+                continue
+            else:
+                hotkey_for_name = Wallet(
+                    path=str(wallet_path),
+                    name=wallet.name,
+                    hotkey=h_name.split("pub.txt")[0],
+                )
+        else:
+            hotkey_for_name = Wallet(
+                path=str(wallet_path), name=wallet.name, hotkey=h_name
+            )
         try:
+            exists = (
+                hotkey_for_name.hotkey_file.exists_on_device()
+                or hotkey_for_name.hotkeypub_file.exists_on_device()
+            )
             if (
-                (exists := hotkey_for_name.hotkey_file.exists_on_device())
+                exists
                 and not hotkey_for_name.hotkey_file.is_encrypted()
                 # and hotkey_for_name.coldkeypub.ss58_address
                 and get_hotkey_pub_ss58(hotkey_for_name)

bittensor_cli/src/bittensor/utils.py

@@ -361,6 +361,7 @@ async def unstake(
     )
     if json_output:
         json_console.print(json.dumps(successes))
+    return True
 
 
 async def unstake_all(

bittensor_cli/src/commands/stake/remove.py

@@ -2448,3 +2448,71 @@ async def start_subnet(
             await get_start_schedule(subtensor, netuid)
             print_error(f":cross_mark: Failed to start subnet: {error_msg}")
             return False
+
+
+async def set_symbol(
+    wallet: "Wallet",
+    subtensor: "SubtensorInterface",
+    netuid: int,
+    symbol: str,
+    prompt: bool = False,
+    json_output: bool = False,
+) -> bool:
+    """
+    Set a subtensor's symbol, given the netuid and symbol.
+
+    The symbol must be a symbol that subtensor recognizes as available
+    (defined in https://github.com/opentensor/subtensor/blob/main/pallets/subtensor/src/subnets/symbols.rs#L8)
+    """
+    if not await subtensor.subnet_exists(netuid):
+        err = f"Subnet {netuid} does not exist."
+        if json_output:
+            json_console.print_json(data={"success": False, "message": err})
+        else:
+            err_console.print(err)
+        return False
+
+    if prompt and not json_output:
+        sn_info = await subtensor.subnet(netuid=netuid)
+        if not Confirm.ask(
+            f"Your current subnet symbol for SN{netuid} is {sn_info.symbol}. Do you want to update it to {symbol}?"
+        ):
+            return False
+
+    if not (unlock_status := unlock_key(wallet, print_out=False)).success:
+        err = unlock_status.message
+        if json_output:
+            json_console.print_json(data={"success": False, "message": err})
+        else:
+            console.print(err)
+        return False
+
+    start_call = await subtensor.substrate.compose_call(
+        call_module="SubtensorModule",
+        call_function="update_symbol",
+        call_params={"netuid": netuid, "symbol": symbol.encode("utf-8")},
+    )
+
+    signed_ext = await subtensor.substrate.create_signed_extrinsic(
+        call=start_call,
+        keypair=wallet.coldkey,
+    )
+
+    response = await subtensor.substrate.submit_extrinsic(
+        extrinsic=signed_ext,
+        wait_for_inclusion=True,
+    )
+    if await response.is_success:
+        message = f"Successfully updated SN{netuid}'s symbol to {symbol}."
+        if json_output:
+            json_console.print_json(data={"success": True, "message": message})
+        else:
+            console.print(f":white_heavy_check_mark:[dark_sea_green3] {message}\n")
+        return True
+    else:
+        err = format_error_message(await response.error_message)
+        if json_output:
+            json_console.print_json(data={"success": False, "message": err})
+        else:
+            err_console.print(f":cross_mark: [red]Failed[/red]: {err}")
+        return False

bittensor_cli/src/commands/subnets/subnets.py

@@ -846,12 +846,21 @@ async def wallet_list(wallet_path: str, json_output: bool):
             data = f"[bold red]Hotkey[/bold red][green] {hkey}[/green] (?)"
             hk_data = {"name": hkey.name, "ss58_address": "?"}
             if hkey:
-                hkey_ss58 = get_hotkey_pub_ss58(hkey)
+                try:
+                    hkey_ss58 = hkey.get_hotkey().ss58_address
+                    pub_only = False
+                except KeyFileError:
+                    hkey_ss58 = hkey.get_hotkeypub().ss58_address
+                    pub_only = True
                 try:
                     data = (
                         f"[bold red]Hotkey[/bold red] [green]{hkey.hotkey_str}[/green]  "
-                        f"ss58_address [green]{hkey_ss58}[/green]\n"
+                        f"ss58_address [green]{hkey_ss58}[/green]"
                     )
+                    if pub_only:
+                        data += " [blue](hotkeypub only)[/blue]\n"
+                    else:
+                        data += "\n"
                     hk_data["name"] = hkey.hotkey_str
                     hk_data["ss58_address"] = hkey_ss58
                 except UnicodeDecodeError:
@@ -1836,7 +1845,7 @@ async def check_coldkey_swap(wallet: Wallet, subtensor: SubtensorInterface):
 
 
 async def sign(
-    wallet: Wallet, message: str, use_hotkey: str, json_output: bool = False
+    wallet: Wallet, message: str, use_hotkey: bool, json_output: bool = False
 ):
     """Sign a message using the provided wallet or hotkey."""
 

bittensor_cli/src/commands/wallets.py

@@ -15,7 +15,7 @@ scripts = { btcli = "bittensor_cli.cli:main" }
 requires-python = ">=3.9,<3.14"
 dependencies = [
     "wheel",
-    "async-substrate-interface>=1.4.2",
+    "async-substrate-interface>=1.5.2",
     "aiohttp~=3.10.2",
     "backoff~=2.2.1",
     "GitPython>=3.0.0",

pyproject.toml

@@ -10,6 +10,7 @@
 * btcli subnets create
 * btcli subnets set-identity
 * btcli subnets get-identity
+* btcli subnets set-symbol
 * btcli subnets register
 * btcli subnets price
 * btcli stake add
@@ -235,6 +236,34 @@ def test_staking(local_chain, wallet_setup):
     assert get_identity_output["logo_url"] == sn_logo_url
     assert get_identity_output["additional"] == sn_add_info
 
+    # set symbol
+    set_symbol = exec_command_alice(
+        "subnets",
+        "set-symbol",
+        extra_args=[
+            "--wallet-path",
+            wallet_path_alice,
+            "--wallet-name",
+            wallet_alice.name,
+            "--hotkey",
+            wallet_alice.hotkey_str,
+            "--chain",
+            "ws://127.0.0.1:9945",
+            "--netuid",
+            netuid,
+            "--json-output",
+            "--no-prompt",
+            "シ",
+        ],
+    )
+    set_symbol_output = json.loads(set_symbol.stdout)
+    assert set_symbol_output["success"] is True, set_symbol_output
+    assert set_symbol_output["success"] is True, set_symbol_output
+    assert (
+        set_symbol_output["message"]
+        == f"Successfully updated SN{netuid}'s symbol to シ."
+    )
+
     get_s_price = exec_command_alice(
         "subnets",
         "price",