Cleanup/ruff

Author: thewhaleking

bittensor_cli/cli.py

@@ -963,13 +963,13 @@ async def _run():
             finally:
                 if initiated is False:
                     asyncio.create_task(cmd).cancel()
-                if exit_early is True:   # temporarily to handle multiple run commands in one session
+                if (
+                    exit_early is True
+                ):  # temporarily to handle multiple run commands in one session
                     try:
                         raise typer.Exit()
                     except Exception as e:  # ensures we always exit cleanly
-                        if not isinstance(
-                            e, (typer.Exit, RuntimeError)
-                        ):
+                        if not isinstance(e, (typer.Exit, RuntimeError)):
                             err_console.print(f"An unknown error has occurred: {e}")
 
         return self.asyncio_runner(_run())
@@ -2209,7 +2209,9 @@ def wallet_new_hotkey(
         )
         if not uri:
             n_words = get_n_words(n_words)
-        return self._run_command(wallets.new_hotkey(wallet, n_words, use_password, uri, overwrite))
+        return self._run_command(
+            wallets.new_hotkey(wallet, n_words, use_password, uri, overwrite)
+        )
 
     def wallet_new_coldkey(
         self,
@@ -2344,13 +2346,7 @@ def wallet_create_wallet(
         if not uri:
             n_words = get_n_words(n_words)
         return self._run_command(
-            wallets.wallet_create(
-                wallet,
-                n_words,
-                use_password,
-                uri,
-                overwrite
-            )
+            wallets.wallet_create(wallet, n_words, use_password, uri, overwrite)
         )
 
     def wallet_balance(

bittensor_cli/src/__init__.py

@@ -4,7 +4,16 @@
 
 
 class Constants:
-    networks = ["local", "finney", "test", "archive", "subvortex", "rao", "dev", "latent-lite"]
+    networks = [
+        "local",
+        "finney",
+        "test",
+        "archive",
+        "subvortex",
+        "rao",
+        "dev",
+        "latent-lite",
+    ]
     finney_entrypoint = "wss://entrypoint-finney.opentensor.ai:443"
     finney_test_entrypoint = "wss://test.finney.opentensor.ai:443"
     archive_entrypoint = "wss://archive.chain.opentensor.ai:443"
@@ -664,7 +673,10 @@ class WalletValidationTypes(Enum):
     "alpha_values": ("sudo_set_alpha_values", False),
     "liquid_alpha_enabled": ("sudo_set_liquid_alpha_enabled", False),
     "network_registration_allowed": ("sudo_set_network_registration_allowed", False),
-    "network_pow_registration_allowed": ("sudo_set_network_pow_registration_allowed", False)
+    "network_pow_registration_allowed": (
+        "sudo_set_network_pow_registration_allowed",
+        False,
+    ),
 }
 
 # Help Panels for cli help

bittensor_cli/src/bittensor/subtensor_interface.py

@@ -30,7 +30,7 @@
     err_console,
     decode_hex_identity_dict,
     validate_chain_endpoint,
-    u16_normalized_float
+    u16_normalized_float,
 )
 
 

bittensor_cli/src/bittensor/utils.py

@@ -1293,11 +1293,14 @@ def is_linux():
     """Returns True if the operating system is Linux."""
     return platform.system().lower() == "linux"
 
+
 def validate_rate_tolerance(value: Optional[float]) -> Optional[float]:
     """Validates rate tolerance input"""
     if value is not None:
         if value < 0:
-            raise typer.BadParameter("Rate tolerance cannot be negative (less than 0%).")
+            raise typer.BadParameter(
+                "Rate tolerance cannot be negative (less than 0%)."
+            )
         if value > 1:
             raise typer.BadParameter("Rate tolerance cannot be greater than 1 (100%).")
         if value > 0.5:

bittensor_cli/src/commands/wallets.py

@@ -44,7 +44,6 @@
     get_subnet_name,
     millify_tao,
     unlock_key,
-    hex_to_bytes,
     WalletLike,
 )
 
@@ -1076,12 +1075,11 @@ async def transfer(
 ):
     """Transfer token of amount to destination."""
     await transfer_extrinsic(
-        # TODO verify the order here
-        subtensor,
-        wallet,
-        destination,
-        Balance.from_tao(amount),
-        transfer_all,
+        subtensor=subtensor,
+        wallet=wallet,
+        destination=destination,
+        amount=Balance.from_tao(amount),
+        transfer_all=transfer_all,
         prompt=prompt,
     )
 
@@ -1335,11 +1333,7 @@ async def set_id(
             )
             return False
 
-    try:
-        # TODO unlock fn
-        wallet.unlock_coldkey()
-    except KeyFileError:
-        err_console.print("Error decrypting coldkey (possibly incorrect password)")
+    if not unlock_key(wallet).success:
         return False
 
     call = await subtensor.substrate.compose_call(
@@ -1431,30 +1425,15 @@ async def check_coldkey_swap(wallet: Wallet, subtensor: SubtensorInterface):
 async def sign(wallet: Wallet, message: str, use_hotkey: str):
     """Sign a message using the provided wallet or hotkey."""
 
-    def _unlock(key: str):
-        try:
-            getattr(wallet, f"unlock_{key}")()
-            return True
-        except PasswordError:
-            err_console.print(
-                ":cross_mark: [red]The password used to decrypt your keyfile is invalid[/red]"
-            )
-            return False
-        except KeyFileError:
-            err_console.print(
-                ":cross_mark: [red]Keyfile is corrupt, non-writable, or non-readable[/red]:"
-            )
-            return False
-
     if not use_hotkey:
-        if not _unlock("coldkey"):
+        if not unlock_key(wallet, "coldkey").success:
             return False
         keypair = wallet.coldkey
         print_verbose(
             f"Signing using [{COLOR_PALETTE['GENERAL']['COLDKEY']}]coldkey: {wallet.name}"
         )
     else:
-        if not _unlock("hotkey"):
+        if not unlock_key(wallet, "hotkey").success:
             return False
         keypair = wallet.hotkey
         print_verbose(