update test's runners

Author: Roman

tests/e2e_tests/conftest.py

@@ -5,6 +5,7 @@
 import shutil
 import signal
 import subprocess
+import sys
 import time
 
 import pytest
@@ -13,9 +14,48 @@
 from .utils import setup_wallet
 
 
+def wait_for_node_start(process, pattern, timestamp: int = None):
+    for line in process.stdout:
+        print(line.strip())
+        # 20 min as timeout
+        timestamp = timestamp or int(time.time())
+        if int(time.time()) - timestamp > 20 * 60:
+            pytest.fail("Subtensor not started in time")
+        if pattern.search(line):
+            print("Node started!")
+            break
+
+
 # Fixture for setting up and tearing down a localnet.sh chain between tests
 @pytest.fixture(scope="function")
 def local_chain(request):
+    """Determines whether to run the localnet.sh script in a subprocess or a Docker container."""
+    args = request.param if hasattr(request, "param") else None
+    params = "" if args is None else f"{args}"
+    if shutil.which("docker") and not os.getenv("USE_DOCKER") == "0":
+        yield from docker_runner(params)
+    else:
+        if not os.getenv("USE_DOCKER") == "0":
+            if sys.platform.startswith("linux"):
+                docker_command = (
+                    "Install docker with command "
+                    "[blue]sudo apt-get update && sudo apt-get install docker.io -y[/blue]"
+                    " or use documentation [blue]https://docs.docker.com/engine/install/[/blue]"
+                )
+            elif sys.platform == "darwin":
+                docker_command = (
+                    "Install docker with command [blue]brew install docker[/blue]"
+                )
+            else:
+                docker_command = "[blue]Unknown OS, install Docker manually: https://docs.docker.com/get-docker/[/blue]"
+
+            logging.warning("Docker not found in the operating system!")
+            logging.warning(docker_command)
+            logging.warning("Tests are run in legacy mode.")
+        yield from legacy_runner(request)
+
+
+def legacy_runner(request):
     param = request.param if hasattr(request, "param") else None
     # Get the environment variable for the script path
     script_path = os.getenv("LOCALNET_SH_PATH")
@@ -41,18 +81,6 @@ def local_chain(request):
     # Install neuron templates
     logging.info("Downloading and installing neuron templates from github")
 
-    timestamp = int(time.time())
-
-    def wait_for_node_start(process, pattern):
-        for line in process.stdout:
-            print(line.strip())
-            # 20 min as timeout
-            if int(time.time()) - timestamp > 20 * 60:
-                pytest.fail("Subtensor not started in time")
-            if pattern.search(line):
-                print("Node started!")
-                break
-
     wait_for_node_start(process, pattern)
 
     # Run the test, passing in substrate interface
@@ -72,6 +100,108 @@ def wait_for_node_start(process, pattern):
     process.wait()
 
 
+def docker_runner(params):
+    """Starts a Docker container before tests and gracefully terminates it after."""
+
+    def is_docker_running():
+        """Check if Docker has been run."""
+        try:
+            subprocess.run(
+                ["docker", "info"],
+                stdout=subprocess.DEVNULL,
+                stderr=subprocess.DEVNULL,
+                check=True,
+            )
+            return True
+        except subprocess.CalledProcessError:
+            return False
+
+    def try_start_docker():
+        """Run docker based on OS."""
+        try:
+            subprocess.run(["open", "-a", "Docker"], check=True)  # macOS
+        except (FileNotFoundError, subprocess.CalledProcessError):
+            try:
+                subprocess.run(["systemctl", "start", "docker"], check=True)  # Linux
+            except (FileNotFoundError, subprocess.CalledProcessError):
+                try:
+                    subprocess.run(
+                        ["sudo", "service", "docker", "start"], check=True
+                    )  # Linux alternative
+                except (FileNotFoundError, subprocess.CalledProcessError):
+                    print("Failed to start Docker. Manual start may be required.")
+                    return False
+
+        # Wait Docker run 10 attempts with 3 sec waits
+        for _ in range(10):
+            if is_docker_running():
+                return True
+            time.sleep(3)
+
+        print("Docker wasn't run. Manual start may be required.")
+        return False
+
+    container_name = f"test_local_chain_{str(time.time()).replace('.', '_')}"
+    image_name = "ghcr.io/opentensor/subtensor-localnet:latest"
+
+    # Command to start container
+    cmds = [
+        "docker",
+        "run",
+        "--rm",
+        "--name",
+        container_name,
+        "-p",
+        "9944:9944",
+        "-p",
+        "9945:9945",
+        image_name,
+        params,
+    ]
+
+    try_start_docker()
+
+    # Start container
+    with subprocess.Popen(
+        cmds,
+        stdout=subprocess.PIPE,
+        stderr=subprocess.PIPE,
+        text=True,
+        start_new_session=True,
+    ) as process:
+        try:
+            substrate = None
+            try:
+                pattern = re.compile(r"Imported #1")
+                wait_for_node_start(process, pattern, int(time.time()))
+            except TimeoutError:
+                raise
+
+            result = subprocess.run(
+                ["docker", "ps", "-q", "-f", f"name={container_name}"],
+                capture_output=True,
+                text=True,
+            )
+            if not result.stdout.strip():
+                raise RuntimeError("Docker container failed to start.")
+
+            substrate = AsyncSubstrateInterface(url="ws://127.0.0.1:9944")
+            yield substrate
+
+        finally:
+            try:
+                if substrate:
+                    substrate.close()
+            except Exception:
+                pass
+
+            try:
+                subprocess.run(["docker", "kill", container_name])
+                process.wait()
+            except subprocess.TimeoutExpired:
+                os.killpg(os.getpgid(process.pid), signal.SIGKILL)
+
+
 @pytest.fixture(scope="function")
 def wallet_setup():
     wallet_paths = []

tests/e2e_tests/test_senate.py

@@ -216,17 +216,17 @@ def test_senate(local_chain, wallet_setup):
     proposals_after_nay_output = proposals_after_nay.stdout.splitlines()
 
     # Total Ayes to remain 1
-    proposals_after_nay_output[9].split()[2] == "1"
+    assert proposals_after_nay_output[9].split()[2] == "1"
 
     # Total Nays increased to 1
-    proposals_after_nay_output[9].split()[4] == "1"
+    assert proposals_after_nay_output[9].split()[4] == "1"
 
     # Assert Alice has voted Nay
-    proposals_after_nay_output[10].split()[0].strip(
+    assert proposals_after_nay_output[10].split()[0].strip(
         ":"
     ) == wallet_alice.hotkey.ss58_address
 
     # Assert vote casted as Nay
-    proposals_after_nay_output[9].split()[1] == "Nay"
+    assert proposals_after_nay_output[9].split()[1] == "Nay"
 
     print("✅ Passed senate commands")

tests/e2e_tests/test_staking_sudo.py

@@ -1,5 +1,4 @@
 import re
-import time
 
 from bittensor_cli.src.bittensor.balances import Balance
 

tests/e2e_tests/test_wallet_creations.py

@@ -486,20 +486,6 @@ def test_wallet_balance_all(local_chain, wallet_setup, capfd):
         wallet_name = f"test_wallet_{i}"
         wallet_names.append(wallet_name)
 
-        result = exec_command(
-            command="wallet",
-            sub_command="new-coldkey",
-            extra_args=[
-                "--wallet-name",
-                wallet_name,
-                "--wallet-path",
-                wallet_path,
-                "--n-words",
-                "12",
-                "--no-use-password",
-            ],
-        )
-
         wallet_status, message = verify_wallet_dir(wallet_path, wallet_name)
         assert wallet_status, message