Merge pull request #343 from opentensor/release/9.0.3

Release/9.0.3

Author: ibraheem-abe

.github/workflows/e2e-subtensor-tests.yml

@@ -30,7 +30,7 @@ jobs:
     timeout-minutes: 180
     env:
       RELEASE_NAME: development
-      RUSTV: nightly-2024-03-05
+      RUSTV: stable
       RUST_BACKTRACE: full
       RUST_BIN_DIR: target/x86_64-unknown-linux-gnu
       TARGET: x86_64-unknown-linux-gnu

CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 9.0.3 /2025-02-26
+
+## What's Changed
+* Update wording for burn for sn registration by @thewhaleking in https://github.com/opentensor/btcli/pull/333
+* [fix] use chk_take = 0 if None by @camfairchild in https://github.com/opentensor/btcli/pull/335
+* Use `unlock_key` fn globally by @thewhaleking in https://github.com/opentensor/btcli/pull/336
+* Updates Rust version to stable by @ibraheem-opentensor in https://github.com/opentensor/btcli/pull/339
+* Warn Users When Setting Root-Only Hyperparams by @thewhaleking in https://github.com/opentensor/btcli/pull/337
+* st transfer allow hotkey ss58 by @thewhaleking in https://github.com/opentensor/btcli/pull/338
+* Git not required by @thewhaleking in https://github.com/opentensor/btcli/pull/341
+* Adds limit of ss58 addresses per call when fetching total_stake by @ibraheem-opentensor in https://github.com/opentensor/btcli/pull/340
+* Backmerge/main staging 902 by @ibraheem-opentensor in https://github.com/opentensor/btcli/pull/342
+
+**Full Changelog**: https://github.com/opentensor/btcli/compare/v9.0.2...v9.0.3
+
 ## 9.0.2 /2025-02-20
 
 ## What's Changed

bittensor_cli/cli.py

@@ -74,8 +74,6 @@ class GitError(Exception):
         pass
 
 
-
-
 _epilog = "Made with [bold red]:heart:[/bold red] by The Openτensor Foundaτion"
 
 np.set_printoptions(precision=8, suppress=True, floatmode="fixed")
@@ -481,7 +479,7 @@ def version_callback(value: bool):
                 f"{repo.active_branch.name}/"
                 f"{repo.commit()}"
             )
-        except (NameError, GitError):
+        except (TypeError, GitError):
             version = f"BTCLI version: {__version__}"
         typer.echo(version)
         raise typer.Exit()
@@ -3323,9 +3321,9 @@ def stake_remove(
     def stake_move(
         self,
         network: Optional[list[str]] = Options.network,
-        wallet_name=Options.wallet_name,
-        wallet_path=Options.wallet_path,
-        wallet_hotkey=Options.wallet_hotkey,
+        wallet_name: Optional[str] = Options.wallet_name,
+        wallet_path: Optional[str] = Options.wallet_path,
+        wallet_hotkey: Optional[str] = Options.wallet_hotkey,
         origin_netuid: Optional[int] = typer.Option(
             None, "--origin-netuid", help="Origin netuid"
         ),
@@ -3535,14 +3533,45 @@ def stake_transfer(
         )
         self.verbosity_handler(quiet, verbose)
 
+        if not wallet_name:
+            wallet_name = Prompt.ask(
+                "Enter the [blue]origin wallet name[/blue]",
+                default=self.config.get("wallet_name") or defaults.wallet.name,
+            )
         wallet = self.wallet_ask(
-            wallet_name,
-            wallet_path,
-            wallet_hotkey,
-            ask_for=[WO.NAME, WO.PATH, WO.HOTKEY],
-            validate=WV.WALLET_AND_HOTKEY,
+            wallet_name, wallet_path, wallet_hotkey, ask_for=[WO.NAME]
         )
 
+        if not wallet_hotkey:
+            origin_hotkey = Prompt.ask(
+                "Enter the [blue]origin hotkey[/blue] name or "
+                "[blue]ss58 address[/blue] where the stake will be moved from",
+                default=self.config.get("wallet_hotkey") or defaults.wallet.hotkey,
+            )
+            if is_valid_ss58_address(origin_hotkey):
+                origin_hotkey = origin_hotkey
+            else:
+                wallet = self.wallet_ask(
+                    wallet_name,
+                    wallet_path,
+                    origin_hotkey,
+                    ask_for=[WO.NAME, WO.PATH, WO.HOTKEY],
+                    validate=WV.WALLET_AND_HOTKEY,
+                )
+                origin_hotkey = wallet.hotkey.ss58_address
+        else:
+            if is_valid_ss58_address(wallet_hotkey):
+                origin_hotkey = wallet_hotkey
+            else:
+                wallet = self.wallet_ask(
+                    wallet_name,
+                    wallet_path,
+                    wallet_hotkey,
+                    ask_for=[],
+                    validate=WV.WALLET_AND_HOTKEY,
+                )
+                origin_hotkey = wallet.hotkey.ss58_address
+
         if not dest_ss58:
             dest_ss58 = Prompt.ask(
                 "Enter the [blue]destination wallet name[/blue] or [blue]coldkey SS58 address[/blue]"
@@ -3580,6 +3609,7 @@ def stake_transfer(
             move_stake.transfer_stake(
                 wallet=wallet,
                 subtensor=self.initialize_chain(network),
+                origin_hotkey=origin_hotkey,
                 origin_netuid=origin_netuid,
                 dest_netuid=dest_netuid,
                 dest_coldkey_ss58=dest_ss58,

bittensor_cli/src/bittensor/subtensor_interface.py

@@ -1327,20 +1327,29 @@ async def get_stake_for_coldkeys(
         This function is useful for analyzing the stake distribution and delegation patterns of multiple
         accounts simultaneously, offering a broader perspective on network participation and investment strategies.
         """
-        result = await self.query_runtime_api(
-            runtime_api="StakeInfoRuntimeApi",
-            method="get_stake_info_for_coldkeys",
-            params=[coldkey_ss58_list],
-            block_hash=block_hash,
-        )
-        if result is None:
-            return None
-
+        BATCH_SIZE = 60
+
+        tasks = []
+        for i in range(0, len(coldkey_ss58_list), BATCH_SIZE):
+            ss58_chunk = coldkey_ss58_list[i : i + BATCH_SIZE]
+            tasks.append(
+                self.query_runtime_api(
+                    runtime_api="StakeInfoRuntimeApi",
+                    method="get_stake_info_for_coldkeys",
+                    params=[ss58_chunk],
+                    block_hash=block_hash,
+                )
+            )
+        results = await asyncio.gather(*tasks)
         stake_info_map = {}
-        for coldkey_bytes, stake_info_list in result:
-            coldkey_ss58 = decode_account_id(coldkey_bytes)
-            stake_info_map[coldkey_ss58] = StakeInfo.list_from_any(stake_info_list)
-        return stake_info_map
+        for result in results:
+            if result is None:
+                continue
+            for coldkey_bytes, stake_info_list in result:
+                coldkey_ss58 = decode_account_id(coldkey_bytes)
+                stake_info_map[coldkey_ss58] = StakeInfo.list_from_any(stake_info_list)
+
+        return stake_info_map if stake_info_map else None
 
     async def all_subnets(self, block_hash: Optional[str] = None) -> list[DynamicInfo]:
         result = await self.query_runtime_api(

bittensor_cli/src/commands/stake/add.py

@@ -17,6 +17,7 @@
     is_valid_ss58_address,
     print_error,
     print_verbose,
+    unlock_key,
 )
 from bittensor_wallet import Wallet
 from bittensor_wallet.errors import KeyFileError
@@ -338,10 +339,7 @@ async def stake_extrinsic(
     if prompt:
         if not Confirm.ask("Would you like to continue?"):
             raise typer.Exit()
-    try:
-        wallet.unlock_coldkey()
-    except KeyFileError:
-        err_console.print("Error decrypting coldkey (possibly incorrect password)")
+    if not unlock_key(wallet).success:
         return False
 
     if safe_staking:

bittensor_cli/src/commands/stake/children_hotkeys.py

@@ -671,6 +671,8 @@ async def display_chk_take(ss58, netuid):
         chk_take = await get_childkey_take(
             subtensor=subtensor, netuid=netuid, hotkey=ss58
         )
+        if chk_take is None:
+            chk_take = 0
         chk_take = u16_to_float(chk_take)
         console.print(
             f"Child take for {ss58} is: {chk_take * 100:.2f}% on netuid {netuid}."

bittensor_cli/src/commands/stake/move.py

@@ -17,6 +17,7 @@
     format_error_message,
     group_subnets,
     get_subnet_name,
+    unlock_key,
 )
 
 if TYPE_CHECKING:
@@ -621,10 +622,7 @@ async def move_stake(
             raise typer.Exit()
 
     # Perform moving operation.
-    try:
-        wallet.unlock_coldkey()
-    except KeyFileError:
-        err_console.print("Error decrypting coldkey (possibly incorrect password)")
+    if not unlock_key(wallet).success:
         return False
     with console.status(
         f"\n:satellite: Moving [blue]{amount_to_move_as_balance}[/blue] from [blue]{origin_hotkey}[/blue] on netuid: [blue]{origin_netuid}[/blue] \nto "
@@ -697,6 +695,7 @@ async def transfer_stake(
     wallet: Wallet,
     subtensor: "SubtensorInterface",
     amount: float,
+    origin_hotkey: str,
     origin_netuid: int,
     dest_netuid: int,
     dest_coldkey_ss58: str,
@@ -709,6 +708,7 @@ async def transfer_stake(
         wallet (Wallet): Bittensor wallet object.
         subtensor (SubtensorInterface): Subtensor interface instance.
         amount (float): Amount to transfer.
+        origin_hotkey (str): The hotkey SS58 to transfer the stake from.
         origin_netuid (int): The netuid to transfer stake from.
         dest_netuid (int): The netuid to transfer stake to.
         dest_coldkey_ss58 (str): The destination coldkey to transfer stake to.
@@ -739,16 +739,15 @@ async def transfer_stake(
         return False
 
     # Get current stake balances
-    hotkey_ss58 = wallet.hotkey.ss58_address
     with console.status(f"Retrieving stake data from {subtensor.network}..."):
         current_stake = await subtensor.get_stake(
             coldkey_ss58=wallet.coldkeypub.ss58_address,
-            hotkey_ss58=hotkey_ss58,
+            hotkey_ss58=origin_hotkey,
             netuid=origin_netuid,
         )
         current_dest_stake = await subtensor.get_stake(
             coldkey_ss58=dest_coldkey_ss58,
-            hotkey_ss58=hotkey_ss58,
+            hotkey_ss58=origin_hotkey,
             netuid=dest_netuid,
         )
     amount_to_transfer = Balance.from_tao(amount).set_unit(origin_netuid)
@@ -768,19 +767,16 @@ async def transfer_stake(
             subtensor=subtensor,
             origin_netuid=origin_netuid,
             destination_netuid=dest_netuid,
-            origin_hotkey=hotkey_ss58,
-            destination_hotkey=hotkey_ss58,
+            origin_hotkey=origin_hotkey,
+            destination_hotkey=origin_hotkey,
             amount_to_move=amount_to_transfer,
         )
 
         if not Confirm.ask("Would you like to continue?"):
             raise typer.Exit()
 
     # Perform transfer operation
-    try:
-        wallet.unlock_coldkey()
-    except KeyFileError:
-        err_console.print("Error decrypting coldkey (possibly incorrect password)")
+    if not unlock_key(wallet).success:
         return False
 
     with console.status("\n:satellite: Transferring stake ..."):
@@ -789,7 +785,7 @@ async def transfer_stake(
             call_function="transfer_stake",
             call_params={
                 "destination_coldkey": dest_coldkey_ss58,
-                "hotkey": hotkey_ss58,
+                "hotkey": origin_hotkey,
                 "origin_netuid": origin_netuid,
                 "destination_netuid": dest_netuid,
                 "alpha_amount": amount_to_transfer.rao,
@@ -820,12 +816,12 @@ async def transfer_stake(
     new_stake, new_dest_stake = await asyncio.gather(
         subtensor.get_stake(
             coldkey_ss58=wallet.coldkeypub.ss58_address,
-            hotkey_ss58=hotkey_ss58,
+            hotkey_ss58=origin_hotkey,
             netuid=origin_netuid,
         ),
         subtensor.get_stake(
             coldkey_ss58=dest_coldkey_ss58,
-            hotkey_ss58=hotkey_ss58,
+            hotkey_ss58=origin_hotkey,
             netuid=dest_netuid,
         ),
     )
@@ -933,10 +929,7 @@ async def swap_stake(
             raise typer.Exit()
 
     # Perform swap operation
-    try:
-        wallet.unlock_coldkey()
-    except KeyFileError:
-        err_console.print("Error decrypting coldkey (possibly incorrect password)")
+    if not unlock_key(wallet).success:
         return False
 
     with console.status(

bittensor_cli/src/commands/stake/remove.py

@@ -21,6 +21,7 @@
     is_valid_ss58_address,
     format_error_message,
     group_subnets,
+    unlock_key,
 )
 
 if TYPE_CHECKING:
@@ -268,10 +269,7 @@ async def unstake(
             raise typer.Exit()
 
     # Execute extrinsics
-    try:
-        wallet.unlock_coldkey()
-    except KeyFileError:
-        err_console.print("Error decrypting coldkey (possibly incorrect password)")
+    if not unlock_key(wallet).success:
         return False
 
     with console.status("\n:satellite: Performing unstaking operations...") as status:
@@ -465,10 +463,7 @@ async def unstake_all(
     ):
         return False
 
-    try:
-        wallet.unlock_coldkey()
-    except KeyFileError:
-        err_console.print("Error decrypting coldkey (possibly incorrect password)")
+    if not unlock_key(wallet).success:
         return False
 
     with console.status("Unstaking all stakes...") as status:

bittensor_cli/src/commands/subnets/subnets.py

@@ -97,8 +97,10 @@ async def _find_event_attributes_in_extrinsic_receipt(
     sn_burn_cost = await burn_cost(subtensor)
     if sn_burn_cost > your_balance:
         err_console.print(
-            f"Your balance of: [{COLOR_PALETTE['POOLS']['TAO']}]{your_balance}[{COLOR_PALETTE['POOLS']['TAO']}] is not enough to pay the subnet lock cost of: "
-            f"[{COLOR_PALETTE['POOLS']['TAO']}]{sn_burn_cost}[{COLOR_PALETTE['POOLS']['TAO']}]"
+            f"Your balance of: [{COLOR_PALETTE['POOLS']['TAO']}]{your_balance}[{COLOR_PALETTE['POOLS']['TAO']}]"
+            f" is not enough to burn "
+            f"[{COLOR_PALETTE['POOLS']['TAO']}]{sn_burn_cost}[{COLOR_PALETTE['POOLS']['TAO']}] "
+            f"to register a subnet."
         )
         return False
 
@@ -107,7 +109,7 @@ async def _find_event_attributes_in_extrinsic_receipt(
             f"Your balance is: [{COLOR_PALETTE['POOLS']['TAO']}]{your_balance}"
         )
         if not Confirm.ask(
-            f"Do you want to register a subnet for [{COLOR_PALETTE['POOLS']['TAO']}]{sn_burn_cost}?"
+            f"Do you want to burn [{COLOR_PALETTE['POOLS']['TAO']}]{sn_burn_cost} to register a subnet?"
         ):
             return False
 
@@ -145,10 +147,7 @@ async def _find_event_attributes_in_extrinsic_receipt(
                 )
                 return False
 
-    try:
-        wallet.unlock_coldkey()
-    except KeyFileError:
-        err_console.print("Error decrypting coldkey (possibly incorrect password)")
+    if not unlock_key(wallet).success:
         return False
 
     with console.status(":satellite: Registering subnet...", spinner="earth"):

bittensor_cli/src/commands/sudo.py

@@ -189,6 +189,11 @@ async def set_hyperparameter_extrinsic(
                 ":cross_mark: [red]Invalid hyperparameter specified.[/red]"
             )
             return False
+    if sudo_:
+        if not Confirm.ask(
+            "This hyperparam is only settable by root sudo users. If you are not, this will fail. Please confirm"
+        ):
+            return False
 
     substrate = subtensor.substrate
     msg_value = value if not arbitrary_extrinsic else call_params