update remove all

Author: ibraheem-abe

bittensor_cli/src/commands/stake/remove.py

@@ -232,7 +232,7 @@ async def unstake(
                 str(netuid),  # Netuid
                 staking_address_name,  # Hotkey Name
                 str(amount_to_unstake_as_balance),  # Amount to Unstake
-                str(subnet_info.price.tao)
+                f"{subnet_info.price.tao:.6f}"
                 + f"({Balance.get_unit(0)}/{Balance.get_unit(netuid)})",  # Rate
                 str(stake_fee),  # Fee
                 str(received_amount),  # Received Amount
@@ -255,7 +255,7 @@ async def unstake(
                 base_table_row.extend(
                     [
                         # Rate with tolerance
-                        f"{rate_with_tolerance:.4f} {Balance.get_unit(0)}/{Balance.get_unit(netuid)}",
+                        f"{rate_with_tolerance:.6f} {Balance.get_unit(0)}/{Balance.get_unit(netuid)}",
                         # Partial unstake
                         f"[{'dark_sea_green3' if allow_partial_stake else 'red'}]"
                         f"{allow_partial_stake}[/{'dark_sea_green3' if allow_partial_stake else 'red'}]",
@@ -446,8 +446,7 @@ async def unstake_all(
         #     style=COLOR_PALETTE["STAKE"]["SLIPPAGE_PERCENT"],
         # )
 
-        # Calculate slippage and total received
-        max_slippage = 0.0
+        # Calculate total received
         total_received_value = Balance(0)
         for stake in stake_info:
             if stake.stake.rao == 0:
@@ -465,41 +464,33 @@ async def unstake_all(
                 destination_coldkey_ss58=wallet.coldkeypub.ss58_address,
                 amount=stake_amount.rao,
             )
+
             try:
-                received_amount, slippage_pct, slippage_pct_float = _calculate_slippage(
-                    subnet_info=subnet_info, amount=stake_amount, stake_fee=stake_fee
-                )
-            except ValueError:
+                current_price = subnet_info.price.tao
+                rate = current_price
+                received_amount = stake_amount * rate - stake_fee
+
+                if received_amount < Balance.from_tao(0):
+                    print_error("Not enough Alpha to pay the transaction fee.")
+                    continue
+            except (AttributeError, ValueError):
                 continue
 
-            max_slippage = max(max_slippage, slippage_pct_float)
             total_received_value += received_amount
 
             table.add_row(
                 str(stake.netuid),
                 hotkey_display,
                 str(stake_amount),
-                str(float(subnet_info.price))
+                f"{float(subnet_info.price):.6f}"
                 + f"({Balance.get_unit(0)}/{Balance.get_unit(stake.netuid)})",
                 str(stake_fee),
-                # str(received_amount),
-                # slippage_pct,
+                str(received_amount),
             )
     console.print(table)
-    if max_slippage > 5:
-        message = (
-            f"[{COLOR_PALETTE['STAKE']['SLIPPAGE_TEXT']}]--------------------------------------------------------------"
-            f"-----------------------------------------------------\n"
-            f"[bold]WARNING:[/bold] The slippage on one of your operations is high: "
-            f"[{COLOR_PALETTE['STAKE']['SLIPPAGE_PERCENT']}]{max_slippage:.4f}%"
-            f"[/{COLOR_PALETTE['STAKE']['SLIPPAGE_PERCENT']}], this may result in a loss of funds.\n"
-            "----------------------------------------------------------------------------------------------------------"
-            "---------\n"
-        )
-        console.print(message)
 
     console.print(
-        f"Expected return after slippage: [{COLOR_PALETTE['STAKE']['STAKE_AMOUNT']}]{total_received_value}"
+        f"Total expected return: [{COLOR_PALETTE['STAKE']['STAKE_AMOUNT']}]{total_received_value}"
     )
 
     if prompt and not Confirm.ask(
@@ -840,55 +831,6 @@ async def _unstake_all_extrinsic(
 
 
 # Helpers
-def _calculate_slippage(
-    subnet_info, amount: Balance, stake_fee: Balance
-) -> tuple[Balance, str, float]:
-    """Calculate slippage and received amount for unstaking operation.
-
-    Args:
-        subnet_info: Subnet information containing price data
-        amount: Amount being unstaked
-        stake_fee: Stake fee to include in slippage calculation
-
-    Returns:
-        tuple containing:
-        - received_amount: Balance after slippage deduction
-        - slippage_pct: Formatted string of slippage percentage
-        - slippage_pct_float: Float value of slippage percentage
-
-    TODO: Update to v3. This method only works for protocol-liquidity-only
-          mode (user liquidity disabled)
-    """
-    received_amount, _, _ = subnet_info.alpha_to_tao_with_slippage(amount)
-    received_amount -= stake_fee
-
-    if received_amount < Balance.from_tao(0):
-        print_error("Not enough Alpha to pay the transaction fee.")
-        raise ValueError
-
-    if subnet_info.is_dynamic:
-        # Ideal amount w/o slippage
-        ideal_amount = subnet_info.alpha_to_tao(amount)
-
-        # Total slippage including fees
-        total_slippage = ideal_amount - received_amount
-        slippage_pct_float = (
-            100 * (float(total_slippage.tao) / float(ideal_amount.tao))
-            if ideal_amount.tao != 0
-            else 0
-        )
-        slippage_pct = f"{slippage_pct_float:.4f} %"
-    else:
-        # TODO: Fix this. Slippage is always zero for static networks.
-        # Root will only have fee-based slippage
-        slippage_pct_float = (
-            100 * float(stake_fee.tao) / float(amount.tao) if amount.tao != 0 else 0
-        )
-        slippage_pct = f"{slippage_pct_float:.4f} %"
-
-    return received_amount, slippage_pct, slippage_pct_float
-
-
 async def _unstake_selection(
     dynamic_info,
     identities,
@@ -996,7 +938,7 @@ async def _unstake_selection(
 
     for netuid_, stake_amount in netuid_stakes.items():
         symbol = dynamic_info[netuid_].symbol
-        rate = f"{dynamic_info[netuid_].price.tao:.4f} τ/{symbol}"
+        rate = f"{dynamic_info[netuid_].price.tao:.6f} τ/{symbol}"
         table.add_row(str(netuid_), symbol, str(stake_amount), rate)
     console.print("\n", table, "\n")