PR suggestions

Author: thewhaleking

bittensor_cli/src/bittensor/subtensor_interface.py

@@ -1490,6 +1490,15 @@ async def get_owned_hotkeys(
         return [decode_account_id(hotkey[0]) for hotkey in owned_hotkeys or []]
 
     async def get_extrinsic_fee(self, call: GenericCall, keypair: Keypair) -> Balance:
+        """
+        Determines the fee for the extrinsic call.
+        Args:
+            call: Created extrinsic call
+            keypair: The keypair that would sign the extrinsic (usually you would just want to use the *pub for this)
+
+        Returns:
+            Balance object representing the fee for this extrinsic.
+        """
         fee_dict = await self.substrate.get_payment_info(call, keypair)
         return Balance.from_rao(fee_dict["partial_fee"])
 

bittensor_cli/src/commands/stake/add.py

@@ -72,6 +72,18 @@ async def get_stake_extrinsic_fee(
         safe_staking_: bool,
         price_limit: Optional[Balance] = None,
     ):
+        """
+        Quick method to get the extrinsic fee for adding stake depending on the args supplied.
+        Args:
+            netuid_: The netuid where the stake will be added
+            amount_: the amount of stake to add
+            staking_address_: the hotkey ss58 to stake to
+            safe_staking_: whether to use safe staking
+            price_limit: rate with tolerance
+
+        Returns:
+            Balance object representing the extrinsic fee for adding stake.
+        """
         call_fn = "add_stake" if not safe_staking_ else "add_stake_limit"
         call_params = {
             "hotkey": staking_address_,

bittensor_cli/src/commands/stake/remove.py

@@ -215,19 +215,19 @@ async def unstake(
                     if subnet_info.is_dynamic:
                         price_with_tolerance = current_price * (1 - rate_tolerance)
                         rate_with_tolerance = price_with_tolerance
-                        price_with_tolerance = Balance.from_tao(
+                        price_limit = Balance.from_tao(
                             rate_with_tolerance
-                        ).rao  # Actual price to pass to extrinsic
+                        )  # Actual price to pass to extrinsic
                     else:
-                        price_with_tolerance = 1
+                        price_limit = Balance.from_rao(1)
                     extrinsic_fee = await _get_extrinsic_fee(
                         "unstake_safe",
                         wallet,
                         subtensor,
                         hotkey_ss58=staking_address_ss58,
                         amount=amount_to_unstake_as_balance,
                         netuid=netuid,
-                        price_limit=price_with_tolerance,
+                        price_limit=price_limit,
                         allow_partial_stake=allow_partial_stake,
                     )
                 else: