chore: remove childkey take removal

Author: Samuel Dare

pallets/admin-utils/tests/mock.rs

@@ -79,9 +79,8 @@ parameter_types! {
     pub const InitialFoundationDistribution: u64 = 0;
     pub const InitialDefaultDelegateTake: u16 = 11_796; // 18% honest number.
     pub const InitialMinDelegateTake: u16 = 5_898; // 9%;
-    pub const InitialDefaultChildKeyTake: u16 = 11_796; // 18% honest number.
-    pub const InitialMinChildKeyTake: u16 = 5_898; // 9%;
-    pub const InitialMinTake: u16 = 5_898; // 9%;
+    pub const InitialDefaultChildKeyTake: u16 = 0; // Allow 0 %
+    pub const InitialMinChildKeyTake: u16 = 0; // Allow 0 %
     pub const InitialWeightsVersionKey: u16 = 0;
     pub const InitialServingRateLimit: u64 = 0; // No limit.
     pub const InitialTxRateLimit: u64 = 0; // Disable rate limit for testing

pallets/subtensor/src/staking/set_children.rs

@@ -130,11 +130,6 @@ impl<T: Config> Pallet<T> {
         // --- 7.1. Insert my new children + proportion list into the map.
         ChildKeys::<T>::insert(hotkey.clone(), netuid, children.clone());
 
-        if children.is_empty() {
-            // If there are no children, remove the ChildkeyTake value
-            ChildkeyTake::<T>::remove(hotkey.clone(), netuid);
-        }
-
         // --- 7.2. Update the parents list for my new children.
         for (proportion, new_child_i) in children.clone().iter() {
             // --- 8.2.1. Get the child's parents on this network.

pallets/subtensor/tests/children.rs

@@ -1622,55 +1622,3 @@ fn test_get_parents_chain() {
         );
     });
 }
-
-// SKIP_WASM_BUILD=1 RUST_LOG=info cargo test --test children -- test_childkey_take_removal_on_empty_children --exact --nocapture
-#[test]
-fn test_childkey_take_removal_on_empty_children() {
-    new_test_ext(1).execute_with(|| {
-        let coldkey = U256::from(1);
-        let hotkey = U256::from(2);
-        let child = U256::from(3);
-        let netuid: u16 = 1;
-        let proportion: u64 = 1000;
-
-        // Add network and register hotkey
-        add_network(netuid, 13, 0);
-        register_ok_neuron(netuid, hotkey, coldkey, 0);
-
-        // Set a child and childkey take
-        assert_ok!(SubtensorModule::do_set_children(
-            RuntimeOrigin::signed(coldkey),
-            hotkey,
-            netuid,
-            vec![(proportion, child)]
-        ));
-
-        let take: u16 = u16::MAX / 10; // 10% take
-        assert_ok!(SubtensorModule::set_childkey_take(
-            RuntimeOrigin::signed(coldkey),
-            hotkey,
-            netuid,
-            take
-        ));
-
-        // Verify childkey take is set
-        assert_eq!(SubtensorModule::get_childkey_take(&hotkey, netuid), take);
-
-        // Remove all children
-        assert_ok!(SubtensorModule::do_set_children(
-            RuntimeOrigin::signed(coldkey),
-            hotkey,
-            netuid,
-            vec![]
-        ));
-
-        // Verify children are removed
-        let children = SubtensorModule::get_children(&hotkey, netuid);
-        assert!(children.is_empty());
-
-        // Verify childkey take is removed
-        assert_eq!(SubtensorModule::get_childkey_take(&hotkey, netuid), 0);
-        // Verify childkey take storage is empty
-        assert_eq!(ChildkeyTake::<Test>::get(hotkey, netuid), 0);
-    });
-}