add migration and test

Author: JohnReedV

pallets/subtensor/src/macros/hooks.rs

@@ -76,7 +76,9 @@ mod hooks {
                 // Migrate to RAO
                 .saturating_add(migrations::migrate_rao::migrate_rao::<T>())
 				// Fix the IsNetworkMember map to be consistent with other storage maps
-				.saturating_add(migrations::migrate_fix_is_network_member::migrate_fix_is_network_member::<T>());
+				.saturating_add(migrations::migrate_fix_is_network_member::migrate_fix_is_network_member::<T>())
+                // Upgrade identities to V2
+                .saturating_add(migrations::migrate_identities_v2::migrate_identities_to_v2::<T>());
             weight
         }
 

pallets/subtensor/src/migrations/migrate_identities_v2.rs

@@ -0,0 +1,91 @@
+use super::*;
+use frame_support::weights::Weight;
+use log;
+use scale_info::prelude::{string::String, vec::Vec};
+
+pub fn migrate_identities_to_v2<T: Config>() -> Weight {
+    use frame_support::traits::Get;
+    let migration_name = b"migrate_identities_to_v2".to_vec();
+
+    // Start counting weight
+    let mut weight = T::DbWeight::get().reads(1);
+
+    // Check if we already ran this migration
+    if HasMigrationRun::<T>::get(&migration_name) {
+        log::info!(
+            target: "runtime",
+            "Migration '{:?}' has already run. Skipping.",
+            String::from_utf8_lossy(&migration_name)
+        );
+        return weight;
+    }
+
+    log::info!(
+        target: "runtime",
+        "Running migration '{}'",
+        String::from_utf8_lossy(&migration_name)
+    );
+
+    // -----------------------------
+    // 1) Migrate Chain Identities
+    // -----------------------------
+    let old_identities = Identities::<T>::iter().collect::<Vec<_>>();
+    for (account_id, old_identity) in old_identities.clone() {
+        let new_identity = ChainIdentityV2 {
+            name: old_identity.name,
+            url: old_identity.url,
+            github_repo: Vec::new(),
+            image: old_identity.image,
+            discord: old_identity.discord,
+            description: old_identity.description,
+            additional: old_identity.additional,
+        };
+
+        // Insert into the new storage map
+        IdentitiesV2::<T>::insert(&account_id, &new_identity);
+        weight = weight.saturating_add(T::DbWeight::get().writes(1));
+
+        Identities::<T>::remove(&account_id);
+        weight = weight.saturating_add(T::DbWeight::get().writes(1));
+    }
+
+    weight = weight.saturating_add(T::DbWeight::get().reads(old_identities.len() as u64));
+
+    // -----------------------------
+    // 2) Migrate Subnet Identities
+    // -----------------------------
+    let old_subnet_identities = SubnetIdentities::<T>::iter().collect::<Vec<_>>();
+    for (netuid, old_subnet_identity) in old_subnet_identities.clone() {
+        let new_subnet_identity = SubnetIdentityV2 {
+            subnet_name: old_subnet_identity.subnet_name,
+            github_repo: old_subnet_identity.github_repo,
+            subnet_contact: old_subnet_identity.subnet_contact,
+            subnet_url: Vec::new(),
+            discord: Vec::new(),
+            description: Vec::new(),
+            additional: Vec::new(),
+        };
+
+        // Insert into the new storage map
+        SubnetIdentitiesV2::<T>::insert(netuid, &new_subnet_identity);
+        weight = weight.saturating_add(T::DbWeight::get().writes(1));
+
+        SubnetIdentities::<T>::remove(netuid);
+        weight = weight.saturating_add(T::DbWeight::get().writes(1));
+    }
+    weight = weight.saturating_add(T::DbWeight::get().reads(old_subnet_identities.len() as u64));
+
+    // -----------------------------
+    // Mark the migration as done
+    // -----------------------------
+    HasMigrationRun::<T>::insert(&migration_name, true);
+    weight = weight.saturating_add(T::DbWeight::get().writes(1));
+
+    log::info!(
+        target: "runtime",
+        "Migration '{}' completed successfully.",
+        String::from_utf8_lossy(&migration_name)
+    );
+
+    weight
+}

pallets/subtensor/src/migrations/mod.rs

@@ -6,6 +6,7 @@ pub mod migrate_delete_subnet_21;
 pub mod migrate_delete_subnet_3;
 pub mod migrate_fix_is_network_member;
 pub mod migrate_fix_total_coldkey_stake;
+pub mod migrate_identities_v2;
 pub mod migrate_init_total_issuance;
 pub mod migrate_populate_owned_hotkeys;
 pub mod migrate_populate_staking_hotkeys;

pallets/subtensor/src/tests/serving.rs

@@ -899,6 +899,118 @@ fn test_migrate_set_hotkey_identities() {
     });
 }
 
+#[test]
+fn test_migrate_identities_to_v2() {
+    new_test_ext(1).execute_with(|| {
+        let account_id_1 = U256::from(1);
+        let account_id_2 = U256::from(2);
+
+        let chainone_name = b"ChainOne".to_vec();
+        let chainone_url = b"https://chainone.example".to_vec();
+        let chainone_image = b"some_image_data".to_vec();
+        let chainone_discord = b"discord#1".to_vec();
+        let chainone_description = b"Old chain identity".to_vec();
+        let chainone_additional = b"extra-info".to_vec();
+
+        let chaintwo_name = b"ChainTwo".to_vec();
+        let chaintwo_url = b"https://chaintwo.example".to_vec();
+        let chaintwo_description = b"Another chain identity".to_vec();
+
+        Identities::<Test>::insert(
+            account_id_1,
+            ChainIdentity {
+                name: chainone_name.clone(),
+                url: chainone_url.clone(),
+                image: chainone_image.clone(),
+                discord: chainone_discord.clone(),
+                description: chainone_description.clone(),
+                additional: chainone_additional.clone(),
+            },
+        );
+
+        Identities::<Test>::insert(
+            account_id_2,
+            ChainIdentity {
+                name: chaintwo_name.clone(),
+                url: chaintwo_url.clone(),
+                image: b"".to_vec(),
+                discord: b"".to_vec(),
+                description: chaintwo_description.clone(),
+                additional: b"".to_vec(),
+            },
+        );
+
+        let old_subnet_name = b"SubnetExample".to_vec();
+        let old_github_repo = b"https://github.com/org/repo".to_vec();
+        let old_subnet_contact = b"subnet@example".to_vec();
+
+        SubnetIdentities::<Test>::insert(
+            42u16,
+            SubnetIdentity {
+                subnet_name: old_subnet_name.clone(),
+                github_repo: old_github_repo.clone(),
+                subnet_contact: old_subnet_contact.clone(),
+            },
+        );
+
+        assert!(Identities::<Test>::get(account_id_1).is_some());
+        assert!(Identities::<Test>::get(account_id_2).is_some());
+        assert!(SubnetIdentities::<Test>::get(42u16).is_some());
+        assert!(!HasMigrationRun::<Test>::get(
+            b"migrate_identities_to_v2".to_vec()
+        ));
+
+        let weight = crate::migrations::migrate_identities_v2::migrate_identities_to_v2::<Test>();
+
+        assert!(
+            HasMigrationRun::<Test>::get(b"migrate_identities_to_v2".to_vec()),
+            "Expected HasMigrationRun to be true after migration"
+        );
+        assert!(Identities::<Test>::get(account_id_1).is_none());
+        assert!(Identities::<Test>::get(account_id_2).is_none());
+        assert!(SubnetIdentities::<Test>::get(42u16).is_none());
+
+        let new_identity_1 = IdentitiesV2::<Test>::get(account_id_1)
+            .expect("ChainOne should be migrated to IdentitiesV2");
+        let expected_github_repo = b"".to_vec();
+
+        assert_eq!(new_identity_1.name, chainone_name);
+        assert_eq!(new_identity_1.url, chainone_url);
+        assert_eq!(new_identity_1.github_repo, expected_github_repo);
+        assert_eq!(new_identity_1.image, chainone_image);
+        assert_eq!(new_identity_1.discord, chainone_discord);
+        assert_eq!(new_identity_1.description, chainone_description);
+        assert_eq!(new_identity_1.additional, chainone_additional);
+
+        let new_identity_2 = IdentitiesV2::<Test>::get(account_id_2)
+            .expect("ChainTwo should be migrated to IdentitiesV2");
+        assert_eq!(new_identity_2.name, chaintwo_name);
+        assert_eq!(new_identity_2.url, chaintwo_url);
+        assert_eq!(new_identity_2.github_repo, b"".to_vec());
+
+        let new_subnet_identity = SubnetIdentitiesV2::<Test>::get(42u16)
+            .expect("SubnetExample should be migrated to SubnetIdentitiesV2");
+
+        let expected_subnet_url = b"".to_vec();
+        let expected_discord = b"".to_vec();
+        let expected_description = b"".to_vec();
+        let expected_additional = b"".to_vec();
+
+        assert_eq!(new_subnet_identity.subnet_name, old_subnet_name);
+        assert_eq!(new_subnet_identity.github_repo, old_github_repo);
+        assert_eq!(new_subnet_identity.subnet_contact, old_subnet_contact);
+        assert_eq!(new_subnet_identity.subnet_url, expected_subnet_url);
+        assert_eq!(new_subnet_identity.discord, expected_discord);
+        assert_eq!(new_subnet_identity.description, expected_description);
+        assert_eq!(new_subnet_identity.additional, expected_additional);
+
+        assert!(
+            weight != Weight::zero(),
+            "Migration weight should be non-zero"
+        );
+    });
+}
+
 // SKIP_WASM_BUILD=1 RUST_LOG=debug cargo test --test serving -- test_do_set_subnet_identity --exact --nocapture
 #[test]
 fn test_do_set_subnet_identity() {