Feat/devnet companion/check metadata hash extension (#649)

* draft: hotkey swap for senate

* feature-gate hash

* use 1.10.0-rc2

* add feature

* feat: remove schedule coldkey swap

* chore: fix tests

* fixes for network resumption

* chore: bump spec

* fix: add back arbitration check

* fix: hotkey

* fix: coldkey arb swap hotkey

* swap delegate stake also

* add test for this

* swap over stakinghotkeys map

* check map first

* add staking hotkeys test

* no take

* keep old stake

* add check to test

* fix some tests

* fix delegate test

* update staking hotekys maps

* init

* comment out

* add admin swap

* fix swap

* ..

* hotkey staking maps fix

* remove staking hotkeys

* remove commented code

* cargo fmt

* cargo fix --workspace

* bump spec_version to 165

* swap hotkey benchmark removed

* add migration and tests for total coldkey hotfix

* adds new test for missing hotkey value

* bump migration values

* fmt

* lock file update

* add production just target

* fmt

* clippy

* benchmarking fix

* feat: try runtime passing

* chore: remove commented code

* chore: make logs human readable

* chore: remove comments

* Update pallets/subtensor/src/lib.rs

Co-authored-by: Sam Johnson <[email protected]>

* fmt

* use rc3 with new fix polkadot-sdk/pull/4117

* incl lock

* bump CI

---------

Co-authored-by: Samuel Dare <[email protected]>
Co-authored-by: distributedstatemachine <[email protected]>
Co-authored-by: const <[email protected]>
Co-authored-by: Sam Johnson <[email protected]>
Co-authored-by: Unconst <[email protected]>

Author: 6 people

Cargo.lock

@@ -47,4 +47,8 @@ lint:
   @echo "Running cargo clippy with automatic fixes on potentially dirty code..."
   just clippy-fix
   @echo "Running cargo clippy..."
-  just clippy
+  just clippy
+
+production:
+  @echo "Running cargo build with metadata-hash generation..."
+  cargo +{{RUSTV}} build --profile production --features="runtime-benchmarks metadata-hash"

Cargo.toml

@@ -54,6 +54,7 @@ sp-io = { workspace = true }
 sp-timestamp = { workspace = true }
 sp-inherents = { workspace = true }
 sp-keyring = { workspace = true }
+frame-metadata-hash-extension = { workspace = true }
 frame-system = { workspace = true }
 pallet-transaction-payment = { workspace = true }
 pallet-commitments = { path = "../pallets/commitments" }

justfile

@@ -136,6 +136,7 @@ pub fn create_benchmark_extrinsic(
         pallet_transaction_payment::ChargeTransactionPayment::<runtime::Runtime>::from(0),
         pallet_subtensor::SubtensorSignedExtension::<runtime::Runtime>::new(),
         pallet_commitments::CommitmentsSignedExtension::<runtime::Runtime>::new(),
+        frame_metadata_hash_extension::CheckMetadataHash::<runtime::Runtime>::new(true),
     );
 
     let raw_payload = runtime::SignedPayload::from_raw(
@@ -152,6 +153,7 @@ pub fn create_benchmark_extrinsic(
             (),
             (),
             (),
+            None,
         ),
     );
     let signature = raw_payload.using_encoded(|e| sender.sign(e));

node/Cargo.toml

@@ -41,6 +41,7 @@ pallet-timestamp = { workspace = true }
 pallet-transaction-payment = { workspace = true }
 pallet-utility = { workspace = true }
 frame-executive = { workspace = true }
+frame-metadata-hash-extension = { workspace = true }
 sp-api = { workspace = true }
 sp-block-builder = { workspace = true }
 sp-consensus-aura = { workspace = true }
@@ -111,6 +112,7 @@ std = [
 	"codec/std",
 	"scale-info/std",
 	"frame-executive/std",
+	"frame-metadata-hash-extension/std",
 	"frame-support/std",
 	"frame-system-rpc-runtime-api/std",
 	"frame-system/std",
@@ -204,3 +206,4 @@ try-runtime = [
 	"pallet-commitments/try-runtime",
 	"pallet-registry/try-runtime"
 ]
+metadata-hash = ["substrate-wasm-builder/metadata-hash"]

node/src/benchmarking.rs

@@ -1,10 +1,19 @@
 fn main() {
-    #[cfg(feature = "std")]
+    #[cfg(all(feature = "std", not(feature = "metadata-hash")))]
     {
         substrate_wasm_builder::WasmBuilder::new()
             .with_current_project()
             .export_heap_base()
             .import_memory()
             .build();
     }
+    #[cfg(all(feature = "std", feature = "metadata-hash"))]
+    {
+        substrate_wasm_builder::WasmBuilder::new()
+            .with_current_project()
+            .export_heap_base()
+            .import_memory()
+            .enable_metadata_hash("TAO", 9)
+            .build();
+    }
 }

runtime/Cargo.toml

@@ -1282,6 +1282,7 @@ pub type SignedExtra = (
     pallet_transaction_payment::ChargeTransactionPayment<Runtime>,
     pallet_subtensor::SubtensorSignedExtension<Runtime>,
     pallet_commitments::CommitmentsSignedExtension<Runtime>,
+    frame_metadata_hash_extension::CheckMetadataHash<Runtime>,
 );
 
 type Migrations = pallet_grandpa::migrations::MigrateV4ToV5<Runtime>;

runtime/build.rs

@@ -1,2 +1,2 @@
-cargo build --profile production --features runtime-benchmarks
+cargo build --profile production --features "runtime-benchmarks metadata-hash"