add more tests

Author: open-junius

pallets/subtensor/src/staking/add_stake.rs

@@ -137,8 +137,6 @@ impl<T: Config> Pallet<T> {
             "do_add_stake( origin:{coldkey:?} hotkey:{hotkey:?}, netuid:{netuid:?}, stake_to_be_added:{stake_to_be_added:?} )"
         );
 
-        Self::ensure_subtoken_enabled(netuid)?;
-
         // 2. Calculate the maximum amount that can be executed with price limit
         let max_amount: TaoCurrency = Self::get_max_amount_add(netuid, limit_price)?.into();
         let mut possible_stake = stake_to_be_added;

pallets/subtensor/src/staking/remove_stake.rs

@@ -343,8 +343,6 @@ impl<T: Config> Pallet<T> {
             "do_remove_stake( origin:{coldkey:?} hotkey:{hotkey:?}, netuid: {netuid:?}, alpha_unstaked:{alpha_unstaked:?} )"
         );
 
-        Self::ensure_subtoken_enabled(netuid)?;
-
         // 2. Calculate the maximum amount that can be executed with price limit
         let max_amount = Self::get_max_amount_remove(netuid, limit_price)?;
         let mut possible_alpha = alpha_unstaked;
@@ -432,8 +430,6 @@ impl<T: Config> Pallet<T> {
     ) -> DispatchResult {
         let coldkey = ensure_signed(origin.clone())?;
 
-        Self::ensure_subtoken_enabled(netuid)?;
-
         let alpha_unstaked =
             Self::get_stake_for_hotkey_and_coldkey_on_subnet(&hotkey, &coldkey, netuid);
 

pallets/swap/src/mock.rs

@@ -36,7 +36,7 @@ pub const OK_HOTKEY_ACCOUNT_ID_RICH: AccountId = 1005;
 pub const NOT_SUBNET_OWNER: AccountId = 666;
 pub const NON_EXISTENT_NETUID: u16 = 999;
 pub const WRAPPING_FEES_NETUID: u16 = 124;
-
+pub const SUBTOKEN_DISABLED_NETUID: u16 = 13579;
 parameter_types! {
     pub const BlockHashCount: u64 = 250;
     pub const SS58Prefix: u8 = 42;
@@ -116,8 +116,9 @@ impl SubnetInfo<AccountId> for MockLiquidityProvider {
         *account_id != NOT_SUBNET_OWNER
     }
 
-    fn is_subtoken_enabled(_netuid: NetUid) -> bool {
-        true
+    // Only disable one subnet for testing
+    fn is_subtoken_enabled(netuid: NetUid) -> bool {
+        netuid.inner() != SUBTOKEN_DISABLED_NETUID
     }
 }
 

pallets/swap/src/pallet/tests.rs

@@ -1944,3 +1944,50 @@ fn test_less_price_movement() {
         });
     });
 }
+
+#[test]
+fn test_swap_subtoken_disabled() {
+    new_test_ext().execute_with(|| {
+        let netuid = NetUid::from(SUBTOKEN_DISABLED_NETUID); // Use a netuid not used elsewhere
+        let price_low = 0.1;
+        let price_high = 0.2;
+        let tick_low = price_to_tick(price_low);
+        let tick_high = price_to_tick(price_high);
+        let liquidity = 1_000_000_u64;
+
+        assert_ok!(Pallet::<Test>::maybe_initialize_v3(netuid));
+
+        assert_noop!(
+            Pallet::<Test>::add_liquidity(
+                RuntimeOrigin::signed(OK_COLDKEY_ACCOUNT_ID),
+                OK_HOTKEY_ACCOUNT_ID,
+                netuid,
+                tick_low,
+                tick_high,
+                liquidity,
+            ),
+            Error::<Test>::SubtokenDisabled
+        );
+
+        assert_noop!(
+            Pallet::<Test>::remove_liquidity(
+                RuntimeOrigin::signed(OK_COLDKEY_ACCOUNT_ID),
+                OK_HOTKEY_ACCOUNT_ID,
+                netuid,
+                PositionId::from(0),
+            ),
+            Error::<Test>::SubtokenDisabled
+        );
+
+        assert_noop!(
+            Pallet::<Test>::modify_position(
+                RuntimeOrigin::signed(OK_COLDKEY_ACCOUNT_ID),
+                OK_HOTKEY_ACCOUNT_ID,
+                netuid,
+                PositionId::from(0),
+                liquidity as i64,
+            ),
+            Error::<Test>::SubtokenDisabled
+        );
+    });
+}