use bool return type

Author: camfairchild

pallets/subtensor/src/staking/stake_utils.rs

@@ -553,7 +553,7 @@ impl<T: Config> Pallet<T> {
         hotkey: &T::AccountId,
         netuid: u16,
         amount: u64,
-    ) -> Result<(), ()> {
+    ) -> bool {
         let mut alpha_share_pool = Self::get_alpha_share_pool(hotkey.clone(), netuid);
         alpha_share_pool.sim_update_value_for_one(amount as i64)
     }
@@ -895,9 +895,9 @@ impl<T: Config> Pallet<T> {
         let try_stake_result = Self::try_increase_stake_for_hotkey_and_coldkey_on_subnet(
             hotkey,
             netuid,
-            expected_alpha.unwrap(),
+            expected_alpha.unwrap_or(0),
         );
-        ensure!(try_stake_result.is_ok(), Error::<T>::InsufficientLiquidity);
+        ensure!(try_stake_result, Error::<T>::InsufficientLiquidity);
 
         Ok(())
     }
@@ -1019,7 +1019,7 @@ impl<T: Config> Pallet<T> {
             destination_netuid,
             expected_alpha,
         );
-        ensure!(try_stake_result.is_ok(), Error::<T>::InsufficientLiquidity);
+        ensure!(try_stake_result, Error::<T>::InsufficientLiquidity);
 
         if check_transfer_toggle {
             // Ensure transfer is toggled.

primitives/share-pool/src/lib.rs

@@ -75,13 +75,13 @@ where
         });
     }
 
-    pub fn sim_update_value_for_one(&mut self, update: i64) -> Result<(), ()> {
+    pub fn sim_update_value_for_one(&mut self, update: i64) -> bool {
         let shared_value: U64F64 = self.state_ops.get_shared_value();
         let denominator: U64F64 = self.state_ops.get_denominator();
 
         // Then, update this key's share
         if denominator == 0 {
-            Ok(())
+            true
         } else {
             // There are already keys in the pool, set or update this key
             let value_per_share: I64F64 = I64F64::saturating_from_num(
@@ -95,9 +95,9 @@ where
                 .unwrap_or(I64F64::saturating_from_num(0));
 
             if shares_per_update != 0 {
-                Ok(())
+                true
             } else {
-                Err(())
+                false
             }
         }
     }