Merge pull request #693 from opentensor/fix-identity-migration-test

devnet fix clippy & unit test

Author: JohnReedV

pallets/collective/src/lib.rs

@@ -951,9 +951,9 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> {
     ///
     /// If not `approved`:
     /// - one event deposited.
-    /// Two removals, one mutation.
-    /// Computation and i/o `O(P)` where:
-    /// - `P` is number of active proposals
+    /// - two removals, one mutation.
+    /// - computation and i/o `O(P)` where:
+    ///   - `P` is number of active proposals
     fn do_approve_proposal(
         seats: MemberCount,
         yes_votes: MemberCount,

pallets/subtensor/Cargo.toml

@@ -84,6 +84,7 @@ std = [
 	"serde_with/std",
 	"substrate-fixed/std",
 	"num-traits/std",
+	"serde_json/std"
 ]
 runtime-benchmarks = [
 	"frame-benchmarking/runtime-benchmarks",

pallets/subtensor/tests/children.rs

@@ -297,7 +297,6 @@ fn test_do_set_child_singular_multiple_children() {
 
 // SKIP_WASM_BUILD=1 RUST_LOG=info cargo test --test children -- test_add_singular_child --exact --nocapture
 #[test]
-#[cfg(not(tarpaulin))]
 fn test_add_singular_child() {
     new_test_ext(1).execute_with(|| {
         let netuid: u16 = 1;

pallets/subtensor/tests/coinbase.rs

@@ -6,7 +6,6 @@ use sp_core::U256;
 
 // Test the ability to hash all sorts of hotkeys.
 #[test]
-#[cfg(not(tarpaulin))]
 fn test_hotkey_hashing() {
     new_test_ext(1).execute_with(|| {
         for i in 0..10000 {
@@ -18,7 +17,6 @@ fn test_hotkey_hashing() {
 // Test drain tempo on hotkeys.
 // SKIP_WASM_BUILD=1 RUST_LOG=debug cargo test --test coinbase test_hotkey_drain_time -- --nocapture
 #[test]
-#[cfg(not(tarpaulin))]
 fn test_hotkey_drain_time() {
     new_test_ext(1).execute_with(|| {
         // Block 0
@@ -46,7 +44,6 @@ fn test_hotkey_drain_time() {
 // To run this test specifically, use the following command:
 // SKIP_WASM_BUILD=1 RUST_LOG=debug cargo test --test coinbase test_coinbase_basic -- --nocapture
 #[test]
-#[cfg(not(tarpaulin))]
 fn test_coinbase_basic() {
     new_test_ext(1).execute_with(|| {
         // Define network ID
@@ -138,7 +135,6 @@ fn test_coinbase_basic() {
 // Test getting and setting hotkey emission tempo
 // SKIP_WASM_BUILD=1 RUST_LOG=debug cargo test --test coinbase test_set_and_get_hotkey_emission_tempo -- --nocapture
 #[test]
-#[cfg(not(tarpaulin))]
 fn test_set_and_get_hotkey_emission_tempo() {
     new_test_ext(1).execute_with(|| {
         // Get the default hotkey emission tempo

pallets/subtensor/tests/difficulty.rs

@@ -5,7 +5,6 @@ mod mock;
 use sp_core::U256;
 
 #[test]
-#[cfg(not(tarpaulin))]
 fn test_registration_difficulty_adjustment() {
     new_test_ext(1).execute_with(|| {
         // Create Net 1

pallets/subtensor/tests/epoch.rs

@@ -2107,7 +2107,6 @@ fn test_zero_weights() {
 
 // Test that epoch assigns validator permits to highest stake uids, varies uid interleaving and stake values.
 #[test]
-#[cfg(not(tarpaulin))]
 fn test_validator_permits() {
     let netuid: u16 = 1;
     let tempo: u16 = u16::MAX - 1; // high tempo to skip automatic epochs in on_initialize, use manual epochs instead

pallets/subtensor/tests/mock.rs

@@ -264,6 +264,7 @@ impl CollectiveInterface<AccountId, H256, u32> for TriumvirateVotes {
 }
 
 // We call pallet_collective TriumvirateCollective
+#[allow(dead_code)]
 type TriumvirateCollective = pallet_collective::Instance1;
 impl pallet_collective::Config<TriumvirateCollective> for Test {
     type RuntimeOrigin = RuntimeOrigin;
@@ -281,6 +282,7 @@ impl pallet_collective::Config<TriumvirateCollective> for Test {
 }
 
 // We call council members Triumvirate
+#[allow(dead_code)]
 type TriumvirateMembership = pallet_membership::Instance1;
 impl pallet_membership::Config<TriumvirateMembership> for Test {
     type RuntimeEvent = RuntimeEvent;
@@ -297,6 +299,7 @@ impl pallet_membership::Config<TriumvirateMembership> for Test {
 
 // This is a dummy collective instance for managing senate members
 // Probably not the best solution, but fastest implementation
+#[allow(dead_code)]
 type SenateCollective = pallet_collective::Instance2;
 impl pallet_collective::Config<SenateCollective> for Test {
     type RuntimeOrigin = RuntimeOrigin;
@@ -314,6 +317,7 @@ impl pallet_collective::Config<SenateCollective> for Test {
 }
 
 // We call our top K delegates membership Senate
+#[allow(dead_code)]
 type SenateMembership = pallet_membership::Instance2;
 impl pallet_membership::Config<SenateMembership> for Test {
     type RuntimeEvent = RuntimeEvent;

pallets/subtensor/tests/neuron_info.rs

@@ -15,7 +15,6 @@ fn test_get_neuron_none() {
 }
 
 #[test]
-#[cfg(not(tarpaulin))]
 fn test_get_neuron_some() {
     new_test_ext(1).execute_with(|| {
         let netuid: u16 = 1;

pallets/subtensor/tests/registration.rs

@@ -539,7 +539,6 @@ fn test_burn_adjustment() {
 }
 
 #[test]
-#[cfg(not(tarpaulin))]
 fn test_registration_too_many_registrations_per_block() {
     new_test_ext(1).execute_with(|| {
         let netuid: u16 = 1;

pallets/subtensor/tests/serving.rs

@@ -164,7 +164,6 @@ fn test_serving_set_metadata_update() {
 }
 
 #[test]
-#[cfg(not(tarpaulin))]
 fn test_axon_serving_rate_limit_exceeded() {
     new_test_ext(1).execute_with(|| {
         let hotkey_account_id = U256::from(1);
@@ -382,7 +381,6 @@ fn test_prometheus_serving_set_metadata_update() {
 }
 
 #[test]
-#[cfg(not(tarpaulin))]
 fn test_prometheus_serving_rate_limit_exceeded() {
     new_test_ext(1).execute_with(|| {
         let hotkey_account_id = U256::from(1);
@@ -586,7 +584,7 @@ fn test_do_set_identity() {
         ));
 
         // Check if identity is set correctly
-        let stored_identity = Identities::<Test>::get(coldkey).unwrap();
+        let stored_identity = Identities::<Test>::get(coldkey).expect("Identity should be set");
         assert_eq!(stored_identity.name, name);
         assert_eq!(stored_identity.url, url);
         assert_eq!(stored_identity.image, image);
@@ -622,7 +620,8 @@ fn test_do_set_identity() {
             additional.clone()
         ));
 
-        let updated_identity = Identities::<Test>::get(coldkey).unwrap();
+        let updated_identity =
+            Identities::<Test>::get(coldkey).expect("Updated identity should be set");
         assert_eq!(updated_identity.name, new_name);
         assert_eq!(updated_identity.url, new_url);
 
@@ -760,7 +759,7 @@ fn test_set_and_get_identity() {
         ));
 
         // Get and verify identity
-        let stored_identity = Identities::<Test>::get(coldkey).unwrap();
+        let stored_identity = Identities::<Test>::get(coldkey).expect("Identity should be set");
         assert_eq!(stored_identity.name, name);
         assert_eq!(stored_identity.url, url);
         assert_eq!(stored_identity.image, image);
@@ -782,7 +781,8 @@ fn test_set_and_get_identity() {
         ));
 
         // Get and verify updated identity
-        let updated_identity = Identities::<Test>::get(coldkey).unwrap();
+        let updated_identity =
+            Identities::<Test>::get(coldkey).expect("Updated identity should be set");
         assert_eq!(updated_identity.name, new_name);
         assert_eq!(updated_identity.url, new_url);
         assert_eq!(updated_identity.image, image);
@@ -807,9 +807,7 @@ fn test_migrate_set_hotkey_identities() {
             >();
 
         // Assert that the migration has run
-        assert!(HasMigrationRun::<Test>::get(
-            b"fix_total_coldkey_stake_v7".to_vec()
-        ));
+        assert!(HasMigrationRun::<Test>::get(b"migrate_identities".to_vec()));
 
         // Verify that some identities were set
         // Note: This assumes that at least one valid identity was in the JSON file