Skip to content

Commit 8d6b090

Browse files
committed
improve comment
1 parent 5227bad commit 8d6b090

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

node/src/consensus/aura_wrapped_import_queue.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,11 +153,13 @@ where
153153
log::debug!("Verifying block: {:?}", number);
154154
if is_babe_digest(block.header.digest()) {
155155
self.check_babe_block(block).await?;
156-
log::debug!(
157-
"Detected Babe block! Verifier cannot continue, upgrade must be triggered elsewhere..."
158-
);
156+
// It is critical to pause the verifier when we detect a Babe block while we wait for
157+
// the node to switch to the Babe service. Otherwise if the node rejects the valid babe
158+
// block, it is possible it will repeatedly request the block over and over and get
159+
// blacklisted by other nodes.
160+
log::debug!("Detected valid Babe block, deliberately stalling verifier.");
159161
pending::<()>().await;
160-
unreachable!("Should not reach here, pending forever.");
162+
unreachable!("Cannot reach here, pending forever.");
161163
} else {
162164
self.inner.verify(block).await
163165
}

0 commit comments

Comments
 (0)