Fix clippy and lints

Author: keithtensor

pallets/subtensor/src/tests/epoch.rs

@@ -2285,19 +2285,19 @@ fn test_compute_alpha_values() {
     // exp_val = exp(0.0 - 1.0 * 0.1) = exp(-0.1)
     // alpha[0] = 1 / (1 + exp(-0.1)) ~ 0.9048374180359595
     let exp_val_0 = I32F32::from_num(0.9048374180359595);
-    let expected_alpha_0 = I32F32::from_num(1.0) / I32F32::from_num(1.0).saturating_add(exp_val_0);
+    let expected_alpha_0 = I32F32::from_num(1.0) / (I32F32::from_num(1.0) + exp_val_0);
 
     // For consensus[1] = 0.5:
     // exp_val = exp(0.0 - 1.0 * 0.5) = exp(-0.5)
     // alpha[1] = 1 / (1 + exp(-0.5)) ~ 0.6065306597126334
     let exp_val_1 = I32F32::from_num(0.6065306597126334);
-    let expected_alpha_1 = I32F32::from_num(1.0) / I32F32::from_num(1.0).saturating_add(exp_val_1);
+    let expected_alpha_1 = I32F32::from_num(1.0) / (I32F32::from_num(1.0) + exp_val_1);
 
     // For consensus[2] = 0.9:
     // exp_val = exp(0.0 - 1.0 * 0.9) = exp(-0.9)
     // alpha[2] = 1 / (1 + exp(-0.9)) ~ 0.4065696597405991
     let exp_val_2 = I32F32::from_num(0.4065696597405991);
-    let expected_alpha_2 = I32F32::from_num(1.0) / I32F32::from_num(1.0).saturating_add(exp_val_2);
+    let expected_alpha_2 = I32F32::from_num(1.0) / (I32F32::from_num(1.0) + exp_val_2);
 
     // Define an epsilon for approximate equality checks.
     let epsilon = I32F32::from_num(1e-6);
@@ -2329,13 +2329,13 @@ fn test_compute_alpha_values_256_miners() {
 
     for (i, &c) in consensus.iter().enumerate() {
         // Use saturating subtraction and multiplication
-        let exponent = b.saturating_sub(a.saturating_mul(c));
+        let exponent = b - (a * c);
 
         // Use safe_exp instead of exp
         let exp_val = safe_exp(exponent);
 
         // Use saturating addition and division
-        let expected_alpha = I32F32::from_num(1.0) / I32F32::from_num(1.0).saturating_add(exp_val);
+        let expected_alpha = I32F32::from_num(1.0) / (I32F32::from_num(1.0) + exp_val);
 
         // Assert that the computed alpha values match the expected values within the epsilon.
         assert_approx_eq(alpha[i], expected_alpha, epsilon);

support/linting/src/forbid_saturating_math.rs

@@ -50,7 +50,7 @@ fn is_saturating_math_call(func: &Expr) -> bool {
         return false;
     };
 
-    path.last().map_or(false, |seg| {
+    path.last().is_some_and(|seg| {
         seg.ident.to_string().starts_with("saturating_")
     })
 }