Merge pull request #2114 from opentensor/Remove-Duplicate-Setter-snownerhotkey

Remove Duplicate HyperParameter setter

Author: JohnReedV

pallets/admin-utils/src/lib.rs

@@ -1655,11 +1655,7 @@ pub mod pallet {
             netuid: NetUid,
             hotkey: <T as frame_system::Config>::AccountId,
         ) -> DispatchResult {
-            pallet_subtensor::Pallet::<T>::ensure_subnet_owner(origin.clone(), netuid)?;
-            pallet_subtensor::Pallet::<T>::set_subnet_owner_hotkey(netuid, &hotkey);
-
-            log::debug!("SubnetOwnerHotkeySet( netuid: {netuid:?}, hotkey: {hotkey:?} )");
-            Ok(())
+            pallet_subtensor::Pallet::<T>::do_set_sn_owner_hotkey(origin, netuid, &hotkey)
         }
 
         ///

pallets/admin-utils/src/tests/mod.rs

@@ -1712,48 +1712,48 @@ fn test_sets_a_lower_value_clears_small_nominations() {
     });
 }
 
-#[test]
-fn test_sudo_set_subnet_owner_hotkey() {
-    new_test_ext().execute_with(|| {
-        let netuid = NetUid::from(1);
-
-        let coldkey: U256 = U256::from(1);
-        let hotkey: U256 = U256::from(2);
-        let new_hotkey: U256 = U256::from(3);
-
-        let coldkey_origin = <<Test as Config>::RuntimeOrigin>::signed(coldkey);
-        let root = RuntimeOrigin::root();
-        let random_account = RuntimeOrigin::signed(U256::from(123456));
-
-        pallet_subtensor::SubnetOwner::<Test>::insert(netuid, coldkey);
-        pallet_subtensor::SubnetOwnerHotkey::<Test>::insert(netuid, hotkey);
-        assert_eq!(
-            pallet_subtensor::SubnetOwnerHotkey::<Test>::get(netuid),
-            hotkey
-        );
-
-        assert_ok!(AdminUtils::sudo_set_subnet_owner_hotkey(
-            coldkey_origin,
-            netuid,
-            new_hotkey
-        ));
-
-        assert_eq!(
-            pallet_subtensor::SubnetOwnerHotkey::<Test>::get(netuid),
-            new_hotkey
-        );
-
-        assert_noop!(
-            AdminUtils::sudo_set_subnet_owner_hotkey(random_account, netuid, new_hotkey),
-            DispatchError::BadOrigin
-        );
-
-        assert_noop!(
-            AdminUtils::sudo_set_subnet_owner_hotkey(root, netuid, new_hotkey),
-            DispatchError::BadOrigin
-        );
-    });
-}
+// #[test]
+// fn test_sudo_set_subnet_owner_hotkey() {
+//     new_test_ext().execute_with(|| {
+//         let netuid = NetUid::from(1);
+
+//         let coldkey: U256 = U256::from(1);
+//         let hotkey: U256 = U256::from(2);
+//         let new_hotkey: U256 = U256::from(3);
+
+//         let coldkey_origin = <<Test as Config>::RuntimeOrigin>::signed(coldkey);
+//         let root = RuntimeOrigin::root();
+//         let random_account = RuntimeOrigin::signed(U256::from(123456));
+
+//         pallet_subtensor::SubnetOwner::<Test>::insert(netuid, coldkey);
+//         pallet_subtensor::SubnetOwnerHotkey::<Test>::insert(netuid, hotkey);
+//         assert_eq!(
+//             pallet_subtensor::SubnetOwnerHotkey::<Test>::get(netuid),
+//             hotkey
+//         );
+
+//         assert_ok!(AdminUtils::sudo_set_subnet_owner_hotkey(
+//             coldkey_origin,
+//             netuid,
+//             new_hotkey
+//         ));
+
+//         assert_eq!(
+//             pallet_subtensor::SubnetOwnerHotkey::<Test>::get(netuid),
+//             new_hotkey
+//         );
+
+//         assert_noop!(
+//             AdminUtils::sudo_set_subnet_owner_hotkey(random_account, netuid, new_hotkey),
+//             DispatchError::BadOrigin
+//         );
+
+//         assert_noop!(
+//             AdminUtils::sudo_set_subnet_owner_hotkey(root, netuid, new_hotkey),
+//             DispatchError::BadOrigin
+//         );
+//     });
+// }
 
 // cargo test --package pallet-admin-utils --lib -- tests::test_sudo_set_ema_halving --exact --show-output
 #[test]