Merge pull request #1326 from opentensor/fix/add-dest-hotkey-check

Add dest hotkey check and test

Author: sam0x17

pallets/subtensor/src/staking/stake_utils.rs

@@ -987,6 +987,12 @@ impl<T: Config> Pallet<T> {
             Error::<T>::HotKeyAccountNotExists
         );
 
+        // Ensure that the destination hotkey account exists
+        ensure!(
+            Self::hotkey_account_exists(destination_hotkey),
+            Error::<T>::HotKeyAccountNotExists
+        );
+
         // Ensure there is enough stake in the origin subnet.
         let origin_alpha = Self::get_stake_for_hotkey_and_coldkey_on_subnet(
             origin_hotkey,

pallets/subtensor/src/tests/move_stake.rs

@@ -245,7 +245,9 @@ fn test_do_move_nonexistent_destination_hotkey() {
         let fee = 0;
 
         // Set up initial stake
-        SubtensorModule::stake_into_subnet(&origin_hotkey, &coldkey, netuid, stake_amount, fee);
+        SubtensorModule::create_account_if_non_existent(&coldkey, &origin_hotkey);
+        let alpha =
+            SubtensorModule::stake_into_subnet(&origin_hotkey, &coldkey, netuid, stake_amount, fee);
 
         // Attempt to move stake from a non-existent origin hotkey
         add_network(netuid, 1, 0);
@@ -256,12 +258,12 @@ fn test_do_move_nonexistent_destination_hotkey() {
                 nonexistent_destination_hotkey,
                 netuid,
                 netuid,
-                1234
+                alpha
             ),
             Error::<Test>::HotKeyAccountNotExists
         );
 
-        // Check that the stake was moved successfully
+        // Check that the stake was not moved
         assert_eq!(
             SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(
                 &origin_hotkey,

runtime/src/lib.rs

@@ -229,7 +229,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
     //   `spec_version`, and `authoring_version` are the same between Wasm and native.
     // This value is set to 100 to notify Polkadot-JS App (https://polkadot.js.org/apps) to use
     //   the compatible custom types.
-    spec_version: 241,
+    spec_version: 242,
     impl_version: 1,
     apis: RUNTIME_API_VERSIONS,
     transaction_version: 1,