Merge branch 'devnet-ready' into utility-pallet-fees

Author: JohnReedV

.github/workflows/docker.yml

@@ -9,7 +9,6 @@ on:
         description: "Branch or tag to use for the Docker image tag and ref to checkout (optional)"
         required: false
         default: ""
-
   push:
     branches:
       - devnet-ready
@@ -35,6 +34,13 @@ jobs:
           echo "tag=$branch_or_tag" >> $GITHUB_ENV
           echo "ref=$branch_or_tag" >> $GITHUB_ENV
 
+          # Check if this is a tagged release (not devnet-ready/devnet/testnet)
+          if [[ "${{ github.event_name }}" == "release" && "$branch_or_tag" != "devnet-ready" && "$branch_or_tag" != "devnet" && "$branch_or_tag" != "testnet" ]]; then
+            echo "latest_tag=true" >> $GITHUB_ENV
+          else
+            echo "latest_tag=false" >> $GITHUB_ENV
+          fi
+
       - name: Checkout code
         uses: actions/checkout@v4
         with:
@@ -58,5 +64,7 @@ jobs:
         with:
           context: .
           push: true
+          platforms: linux/amd64,linux/arm64
           tags: |
             ghcr.io/${{ github.repository }}:${{ env.tag }}
+            ${{ env.latest_tag == 'true' && format('ghcr.io/{0}:latest', github.repository) || '' }}

Cargo.lock

@@ -4,7 +4,7 @@ version = "0.1.0"
 description = "Implementation of the bittensor blockchain"
 authors = ["Substrate DevHub <https://github.com/substrate-developer-hub>"]
 homepage = "https://substrate.io/"
-edition = "2021"
+edition = "2024"
 license = "Unlicense"
 publish = false
 repository = "https://github.com/opentensor/subtensor"
@@ -23,21 +23,14 @@ rayon = "1.10"
 
 [workspace]
 members = [
-    "node",
-    "pallets/commitments",
-    "pallets/subtensor",
-    "pallets/admin-utils",
-    "pallets/collective",
-    "pallets/registry",
-    "primitives/*",
-    "runtime",
-    "support/tools",
-    "support/macros",
-    "support/linting",
-    "support/procedural-fork",
-    "pallets/drand",
+	"common",
+	"node",
+	"pallets/*",
+	"precompiles",
+	"primitives/*",
+	"runtime",
+	"support/*",
 ]
-exclude = ["support/procedural-fork"]
 resolver = "2"
 
 [workspace.lints.clippy]
@@ -46,13 +39,29 @@ arithmetic-side-effects = "deny"
 type_complexity = "allow"
 unwrap-used = "deny"
 manual_inspect = "allow"
+useless_conversion = "allow"     # until polkadot is patched
 
 [workspace.dependencies]
+pallet-admin-utils = { default-features = false, path = "pallets/admin-utils" }
+pallet-collective = { default-features = false, path = "pallets/collective" }
+pallet-commitments = { default-features = false, path = "pallets/commitments" }
+pallet-registry = { default-features = false, path = "pallets/registry" }
+pallet-subtensor = { default-features = false, path = "pallets/subtensor" }
+subtensor-custom-rpc = { default-features = false, path = "pallets/subtensor/rpc" }
+subtensor-custom-rpc-runtime-api = { default-features = false, path = "pallets/subtensor/runtime-api" }
+subtensor-precompiles = { default-features = false, path = "precompiles" }
+subtensor-runtime-common = { default-features = false, path = "common" }
+node-subtensor-runtime = { default-features = false, path = "runtime" }
+
 async-trait = "0.1"
 cargo-husky = { version = "1", default-features = false }
 clap = "4.5.4"
-codec = { package = "parity-scale-codec", version = "3.6.1", default-features = false, features = ["derive"] }
-ed25519-dalek = { version = "2.1.0", default-features = false, features = ["alloc"] }
+codec = { package = "parity-scale-codec", version = "3.6.1", default-features = false, features = [
+	"derive",
+] }
+ed25519-dalek = { version = "2.1.0", default-features = false, features = [
+	"alloc",
+] }
 enumflags2 = "0.7.9"
 futures = "0.3.30"
 hex = { version = "0.4", default-features = false }
@@ -63,7 +72,9 @@ memmap2 = "0.9.4"
 ndarray = { version = "0.15.6", default-features = false }
 parity-util-mem = "0.12.0"
 rand = "0.8.5"
-scale-codec = { package = "parity-scale-codec", version = "3.6.12", default-features = false, features = ["derive"] }
+scale-codec = { package = "parity-scale-codec", version = "3.6.12", default-features = false, features = [
+	"derive",
+] }
 scale-info = { version = "2.11.2", default-features = false }
 serde = { version = "1.0.214", default-features = false }
 serde-tuple-vec-map = { version = "1.0.1", default-features = false }
@@ -73,11 +84,11 @@ serde_with = { version = "=2.0.0", default-features = false }
 smallvec = "1.13.2"
 litep2p = { git = "https://github.com/paritytech/litep2p", tag = "v0.7.0" }
 syn = { version = "2.0.87", features = [
-    "full",
-    "visit-mut",
-    "visit",
-    "extra-traits",
-    "parsing",
+	"full",
+	"visit-mut",
+	"visit",
+	"extra-traits",
+	"parsing",
 ] }
 quote = "1"
 proc-macro2 = { version = "1", features = ["span-locations"] }
@@ -181,7 +192,9 @@ fc-consensus = { git = "https://github.com/opentensor/frontier", rev = "635bdac8
 fp-consensus = { git = "https://github.com/opentensor/frontier", rev = "635bdac882", default-features = false }
 fp-dynamic-fee = { git = "https://github.com/opentensor/frontier", rev = "635bdac882", default-features = false }
 fc-api = { git = "https://github.com/opentensor/frontier", rev = "635bdac882", default-features = false }
-fc-rpc = { git = "https://github.com/opentensor/frontier", rev = "635bdac882", default-features = false, features = ["rpc-binary-search-estimate"]}
+fc-rpc = { git = "https://github.com/opentensor/frontier", rev = "635bdac882", default-features = false, features = [
+	"rpc-binary-search-estimate",
+] }
 fc-rpc-core = { git = "https://github.com/opentensor/frontier", rev = "635bdac882", default-features = false }
 fc-mapping-sync = { git = "https://github.com/opentensor/frontier", rev = "635bdac882", default-features = false }
 precompile-utils = { git = "https://github.com/opentensor/frontier", rev = "635bdac882", default-features = false }
@@ -199,21 +212,34 @@ pallet-hotfix-sufficients = { git = "https://github.com/opentensor/frontier", re
 
 #DRAND
 pallet-drand = { path = "pallets/drand", default-features = false }
-sp-crypto-ec-utils = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-stable2409", features = ["bls12-381"] }
-getrandom = { version = "0.2.15", features = ["custom"], default-features = false }
-sp-keystore = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-stable2409",  default-features = false }
+sp-crypto-ec-utils = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-stable2409", features = [
+	"bls12-381",
+] }
+getrandom = { version = "0.2.15", features = [
+	"custom",
+], default-features = false }
+sp-keystore = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-stable2409", default-features = false }
 w3f-bls = { version = "=0.1.3", default-features = false }
-ark-crypto-primitives = { version = "0.4.0", default-features = false, features = [ "r1cs", "snark" ] }
-ark-scale = { version = "0.0.11", default-features = false, features = ["hazmat"] }
+ark-crypto-primitives = { version = "0.4.0", default-features = false, features = [
+	"r1cs",
+	"snark",
+] }
+ark-scale = { version = "0.0.11", default-features = false, features = [
+	"hazmat",
+] }
 sp-ark-bls12-381 = { git = "https://github.com/paritytech/substrate-curves", default-features = false }
-ark-bls12-381 = { version = "0.4.0", features = ["curve"], default-features = false }
-ark-serialize = { version = "0.4.0", features = [ "derive" ], default-features = false }
+ark-bls12-381 = { version = "0.4.0", features = [
+	"curve",
+], default-features = false }
+ark-serialize = { version = "0.4.0", features = [
+	"derive",
+], default-features = false }
 ark-ff = { version = "0.4.0", default-features = false }
 ark-ec = { version = "0.4.0", default-features = false }
 ark-std = { version = "0.4.0", default-features = false }
 anyhow = "1.0.81"
 sha2 = { version = "0.10.8", default-features = false }
-rand_chacha = { version = "0.3.1", default-features = false  }
+rand_chacha = { version = "0.3.1", default-features = false }
 tle = { git = "https://github.com/ideal-lab5/timelock", rev = "5416406cfd32799e31e1795393d4916894de4468", default-features = false }
 
 frame-metadata = "16"
@@ -232,11 +258,11 @@ codegen-units = 1
 [features]
 default = []
 try-runtime = [
-    "node-subtensor/try-runtime",
-    "node-subtensor-runtime/try-runtime",
+	"node-subtensor/try-runtime",
+	"node-subtensor-runtime/try-runtime",
 ]
 runtime-benchmarks = [
-    "node-subtensor/runtime-benchmarks",
-    "node-subtensor-runtime/runtime-benchmarks",
+	"node-subtensor/runtime-benchmarks",
+	"node-subtensor-runtime/runtime-benchmarks",
 ]
 metadata-hash = ["node-subtensor-runtime/metadata-hash"]

Cargo.toml

@@ -1,4 +1,4 @@
-ARG BASE_IMAGE=ubuntu:24.04
+ARG BASE_IMAGE=ubuntu:latest
 
 FROM $BASE_IMAGE AS builder
 SHELL ["/bin/bash", "-c"]
@@ -18,18 +18,22 @@ RUN apt-get update && \
   apt-get install -y curl build-essential protobuf-compiler clang git pkg-config libssl-dev && \
   rm -rf /var/lib/apt/lists/*
 
-RUN set -o pipefail && curl https://sh.rustup.rs -sSf | sh -s -- -y
-ENV PATH="/root/.cargo/bin:${PATH}"
-RUN rustup update stable
-RUN rustup target add wasm32-unknown-unknown --toolchain stable
-
 # Copy entire repository
 COPY . /build
 WORKDIR /build
 
+# Install Rust
+RUN set -o pipefail && curl https://sh.rustup.rs -sSf | sh -s -- -y
+ENV PATH="/root/.cargo/bin:${PATH}"
+RUN rustup toolchain install
+RUN rustup target add wasm32-unknown-unknown
+
 # Build the project
 RUN cargo build -p node-subtensor --profile production  --features="metadata-hash" --locked
 
+# Slim down image
+RUN rm -rf /root/.cargo
+
 # Verify the binary was produced
 RUN test -e /build/target/production/node-subtensor
 

Dockerfile

@@ -31,6 +31,7 @@ fn main() {
 
     // Parse each rust file with syn and run the linting suite on it in parallel
     rust_files.par_iter().for_each_with(tx.clone(), |tx, file| {
+        let is_test = file.display().to_string().contains("test");
         let Ok(content) = fs::read_to_string(file) else {
             return;
         };
@@ -63,6 +64,10 @@ fn main() {
         track_lint(ForbidKeysRemoveCall::lint(&parsed_file));
         track_lint(RequireFreezeStruct::lint(&parsed_file));
         track_lint(RequireExplicitPalletIndex::lint(&parsed_file));
+
+        if is_test {
+            track_lint(ForbidSaturatingMath::lint(&parsed_file));
+        }
     });
 
     // Collect and print all errors after the parallel processing is done