fix: check if emissions disabled value is same before setting

Address review feedback from open-junius:
- Add check to return early if the new value equals the current value
- Update weight to account for additional read (2 reads total)
- Add test for same value case

Author: MkDev11

pallets/admin-utils/src/lib.rs

@@ -2247,7 +2247,7 @@ pub mod pallet {
         #[pallet::call_index(85)]
         #[pallet::weight((
             Weight::from_parts(7_343_000, 0)
-                .saturating_add(<T as frame_system::Config>::DbWeight::get().reads(1))
+                .saturating_add(<T as frame_system::Config>::DbWeight::get().reads(2))
                 .saturating_add(<T as frame_system::Config>::DbWeight::get().writes(1)),
             DispatchClass::Operational,
             Pays::Yes
@@ -2262,6 +2262,12 @@ pub mod pallet {
                 pallet_subtensor::Pallet::<T>::if_subnet_exist(netuid),
                 Error::<T>::SubnetDoesNotExist
             );
+
+            let current_value = pallet_subtensor::Pallet::<T>::get_emissions_disabled(netuid);
+            if current_value == disabled {
+                return Ok(());
+            }
+
             pallet_subtensor::Pallet::<T>::set_emissions_disabled(netuid, disabled);
             log::debug!(
                 "sudo_set_emissions_disabled( netuid: {netuid:?}, disabled: {disabled:?} ) "

pallets/admin-utils/src/tests/mod.rs

@@ -2943,3 +2943,38 @@ fn test_sudo_set_emissions_disabled_subnet_not_exist() {
         );
     });
 }
+
+#[test]
+fn test_sudo_set_emissions_disabled_same_value() {
+    new_test_ext().execute_with(|| {
+        let netuid = NetUid::from(1);
+        add_network(netuid, 10);
+
+        // Default value is false
+        assert!(!SubtensorModule::get_emissions_disabled(netuid));
+
+        // Setting to same value (false) should succeed without changing anything
+        assert_ok!(AdminUtils::sudo_set_emissions_disabled(
+            <<Test as Config>::RuntimeOrigin>::root(),
+            netuid,
+            false
+        ));
+        assert!(!SubtensorModule::get_emissions_disabled(netuid));
+
+        // Now disable emissions
+        assert_ok!(AdminUtils::sudo_set_emissions_disabled(
+            <<Test as Config>::RuntimeOrigin>::root(),
+            netuid,
+            true
+        ));
+        assert!(SubtensorModule::get_emissions_disabled(netuid));
+
+        // Setting to same value (true) should succeed without changing anything
+        assert_ok!(AdminUtils::sudo_set_emissions_disabled(
+            <<Test as Config>::RuntimeOrigin>::root(),
+            netuid,
+            true
+        ));
+        assert!(SubtensorModule::get_emissions_disabled(netuid));
+    });
+}