feat: reduce arb period to 18 hours for testnet

Author: Samuel Dare

pallets/subtensor/src/lib.rs

@@ -394,9 +394,11 @@ pub mod pallet {
         vec![]
     }
     #[pallet::type_value]
-    /// Default stake interval.
+    /// Default arbitration period.
+    /// This value represents the default arbitration period in blocks.
+    /// The period is set to 18 hours, assuming a block time of 12 seconds.
     pub fn DefaultArbitrationPeriod<T: Config>() -> u64 {
-        7200 * 3
+        5400 // 18 hours * 60 minutes/hour * 5 blocks/minute
     }
     #[pallet::storage] // ---- StorageItem Global Used Work.
     pub type ArbitrationPeriod<T: Config> =

pallets/subtensor/tests/staking.rs

@@ -3188,7 +3188,7 @@ fn test_arbitrated_coldkey_swap_success() {
         );
 
         // Check that drain block is set correctly
-        let drain_block: u64 = 7200 * 3 + 1;
+        let drain_block: u64 = 5400 + 1;
 
         log::info!(
             "ColdkeysToSwapAtBlock before scheduling: {:?}",
@@ -3205,7 +3205,7 @@ fn test_arbitrated_coldkey_swap_success() {
             pallet_subtensor::ColdkeysToSwapAtBlock::<Test>::get(drain_block)
         );
 
-        // Make 7200 * 4 blocks pass
+        // Make 5400 blocks pass
         run_to_block(drain_block);
 
         // Run unstaking
@@ -3385,8 +3385,8 @@ fn test_arbitrated_coldkey_swap_with_no_stake() {
             nonce
         ));
 
-        // Make 7200 * 4 blocks pass, simulating on_idle for each block
-        let drain_block: u64 = 7200 * 3 + 1;
+        // Make 5400 blocks pass, simulating on_idle for each block
+        let drain_block: u64 = 5400 + 1;
         for _ in 0..drain_block {
             next_block();
             SubtensorModule::on_idle(System::block_number(), Weight::MAX);
@@ -3446,8 +3446,8 @@ fn test_arbitrated_coldkey_swap_with_multiple_stakes() {
             nonce
         ));
 
-        // Make 7200 * 4 blocks pass, simulating on_idle for each block
-        let drain_block: u64 = 7200 * 3 + 1;
+        // Make 5400 blocks pass, simulating on_idle for each block
+        let drain_block: u64 = 5400 + 1;
         for _ in 0..drain_block {
             next_block();
             SubtensorModule::on_idle(System::block_number(), Weight::MAX);
@@ -3530,7 +3530,7 @@ fn test_arbitrated_coldkey_swap_multiple_arbitrations() {
         );
 
         // Simulate the passage of blocks and on_idle calls
-        for i in 0..(7200 * 3 + 1) {
+        for i in 0..(5400 + 1) {
             // Simulate 10 blocks
             next_block();
             SubtensorModule::on_idle(System::block_number(), Weight::MAX);
@@ -3744,8 +3744,8 @@ fn test_concurrent_arbitrated_coldkey_swaps() {
             current_block,
             nonce2
         ));
-        // Make 7200 * 3 blocks pass
-        let drain_block: u64 = 7200 * 3 + 1;
+        // Make 5400 blocks pass
+        let drain_block: u64 = 5400 + 1;
         run_to_block(drain_block);
 
         // Run arbitration

runtime/src/lib.rs

@@ -139,7 +139,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
     //   `spec_version`, and `authoring_version` are the same between Wasm and native.
     // This value is set to 100 to notify Polkadot-JS App (https://polkadot.js.org/apps) to use
     //   the compatible custom types.
-    spec_version: 188,
+    spec_version: 189,
     impl_version: 1,
     apis: RUNTIME_API_VERSIONS,
     transaction_version: 1,