Add 1000 rao min stake - tests in progress

Author: gztensor

pallets/admin-utils/src/tests/mod.rs

@@ -931,136 +931,6 @@ mod sudo_set_nominator_min_required_stake {
             );
         });
     }
-
-    #[test]
-    fn clears_staker_nominations_below_min() {
-        new_test_ext().execute_with(|| {
-            System::set_block_number(1);
-
-            // Create accounts.
-            let netuid = 1;
-            let hot1 = U256::from(1);
-            let hot2 = U256::from(2);
-            let cold1 = U256::from(3);
-            let cold2 = U256::from(4);
-
-            // SubtensorModule::set_target_stakes_per_interval(10);
-            // Register network.
-            add_network(netuid, 0);
-
-            // Register hot1.
-            register_ok_neuron(netuid, hot1, cold1, 0);
-            assert_eq!(SubtensorModule::get_owning_coldkey_for_hotkey(&hot1), cold1);
-
-            // Register hot2.
-            register_ok_neuron(netuid, hot2, cold2, 0);
-            assert_eq!(SubtensorModule::get_owning_coldkey_for_hotkey(&hot2), cold2);
-
-            // Add stake cold1 --> hot1 (non delegation.)
-            SubtensorModule::add_balance_to_coldkey_account(&cold1, 5);
-            assert_ok!(SubtensorModule::add_stake(
-                <<Test as Config>::RuntimeOrigin>::signed(cold1),
-                hot1,
-                netuid,
-                1
-            ));
-            assert_eq!(
-                SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hot1, &cold1, netuid),
-                1
-            );
-            assert_eq!(Balances::free_balance(cold1), 4);
-
-            // Add stake cold2 --> hot1 (is delegation.)
-            SubtensorModule::add_balance_to_coldkey_account(&cold2, 5);
-            assert_ok!(SubtensorModule::add_stake(
-                <<Test as Config>::RuntimeOrigin>::signed(cold2),
-                hot1,
-                netuid,
-                1
-            ));
-            assert_eq!(
-                SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hot1, &cold2, netuid),
-                1
-            );
-            assert_eq!(Balances::free_balance(cold2), 4);
-
-            // Add stake cold1 --> hot2
-            SubtensorModule::add_balance_to_coldkey_account(&cold1, 5);
-            assert_ok!(SubtensorModule::add_stake(
-                <<Test as Config>::RuntimeOrigin>::signed(cold1),
-                hot2,
-                netuid,
-                1
-            ));
-            assert_eq!(
-                SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hot2, &cold1, netuid),
-                1
-            );
-            assert_eq!(Balances::free_balance(cold1), 8);
-
-            // Add stake cold2 --> hot2
-            SubtensorModule::add_balance_to_coldkey_account(&cold2, 5);
-            assert_ok!(SubtensorModule::add_stake(
-                <<Test as Config>::RuntimeOrigin>::signed(cold2),
-                hot2,
-                netuid,
-                1
-            ));
-            assert_eq!(
-                SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hot2, &cold2, netuid),
-                1
-            );
-            assert_eq!(Balances::free_balance(cold2), 8);
-
-            // Set min stake to 0 (noop)
-            assert_ok!(AdminUtils::sudo_set_nominator_min_required_stake(
-                <<Test as Config>::RuntimeOrigin>::root(),
-                0u64
-            ));
-            assert_eq!(
-                SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hot1, &cold1, netuid),
-                1
-            );
-            assert_eq!(
-                SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hot2, &cold1, netuid),
-                1
-            );
-            assert_eq!(
-                SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hot1, &cold2, netuid),
-                1
-            );
-            assert_eq!(
-                SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hot2, &cold2, netuid),
-                1
-            );
-
-            // Set min nomination to 10: should clear (cold2, hot1) and (cold1, hot2).
-            assert_ok!(AdminUtils::sudo_set_nominator_min_required_stake(
-                <<Test as Config>::RuntimeOrigin>::root(),
-                10u64
-            ));
-            assert_eq!(
-                SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hot1, &cold1, netuid),
-                1
-            );
-            assert_eq!(
-                SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hot2, &cold1, netuid),
-                0
-            );
-            assert_eq!(
-                SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hot1, &cold2, netuid),
-                0
-            );
-            assert_eq!(
-                SubtensorModule::get_stake_for_hotkey_and_coldkey_on_subnet(&hot2, &cold2, netuid),
-                1
-            );
-
-            // Balances have been added back into accounts.
-            assert_eq!(Balances::free_balance(cold1), 9);
-            assert_eq!(Balances::free_balance(cold2), 9);
-        });
-    }
 }
 
 #[test]

pallets/subtensor/src/staking/add_stake.rs

@@ -62,7 +62,7 @@ impl<T: Config> Pallet<T> {
             Error::<T>::HotKeyAccountNotExists
         );
 
-        // Ensure stake_to_ve_added is at least DefaultMinStake
+        // Ensure stake_to_be_added is at least DefaultMinStake
         ensure!(
             stake_to_be_added >= DefaultMinStake::<T>::get(),
             Error::<T>::AmountTooLow

pallets/subtensor/src/staking/move_stake.rs

@@ -1,5 +1,5 @@
 use super::*;
-// use substrate_fixed::types::I96F32;
+use sp_core::Get;
 
 impl<T: Config> Pallet<T> {
     /// Moves stake from one hotkey to another across subnets.
@@ -75,6 +75,12 @@ impl<T: Config> Pallet<T> {
             alpha_amount,
         );
 
+        // Ensure origin_tao is at least DefaultMinStake
+        ensure!(
+            origin_tao >= DefaultMinStake::<T>::get(),
+            Error::<T>::AmountTooLow
+        );
+
         // --- 8. Stake the resulting TAO into the destination subnet for the destination hotkey
         Self::stake_into_subnet(
             &destination_hotkey.clone(),