Merge branch 'development' into sudo-calls-commit-reveal

Author: JohnReedV

pallets/admin-utils/tests/tests.rs

@@ -1152,5 +1152,26 @@ fn test_sudo_set_commit_reveal_weights_enabled() {
             SubtensorModule::get_commit_reveal_weights_enabled(netuid),
             to_be_set
         );
+
+fn test_sudo_set_target_stakes_per_interval() {
+    new_test_ext().execute_with(|| {
+        let to_be_set = 100;
+        let init_value = SubtensorModule::get_target_stakes_per_interval();
+        assert_eq!(
+            AdminUtils::sudo_set_target_stakes_per_interval(
+                <<Test as Config>::RuntimeOrigin>::signed(U256::from(1)),
+                to_be_set
+            ),
+            Err(DispatchError::BadOrigin)
+        );
+        assert_eq!(
+            SubtensorModule::get_target_stakes_per_interval(),
+            init_value
+        );
+        assert_ok!(AdminUtils::sudo_set_target_stakes_per_interval(
+            <<Test as Config>::RuntimeOrigin>::root(),
+            to_be_set
+        ));
+        assert_eq!(SubtensorModule::get_target_stakes_per_interval(), to_be_set);
     });
 }

pallets/subtensor/src/events.rs

@@ -130,5 +130,7 @@ mod events {
         MaxDelegateTakeSet(u16),
         /// minimum delegate take is set by sudo/admin transaction
         MinDelegateTakeSet(u16),
+        /// the target stakes per interval is set by sudo/admin transaction
+        TargetStakesPerIntervalSet(u64),
     }
 }

pallets/subtensor/src/utils.rs

@@ -143,7 +143,10 @@ impl<T: Config> Pallet<T> {
         Self::deposit_event(Event::WeightsMinStake(min_stake));
     }
     pub fn set_target_stakes_per_interval(target_stakes_per_interval: u64) {
-        TargetStakesPerInterval::<T>::set(target_stakes_per_interval)
+        TargetStakesPerInterval::<T>::set(target_stakes_per_interval);
+        Self::deposit_event(Event::TargetStakesPerIntervalSet(
+            target_stakes_per_interval,
+        ));
     }
     pub fn set_stakes_this_interval_for_coldkey_hotkey(
         coldkey: &T::AccountId,

runtime/src/lib.rs

@@ -797,7 +797,7 @@ parameter_types! {
     pub const SubtensorInitialPruningScore : u16 = u16::MAX;
     pub const SubtensorInitialBondsMovingAverage: u64 = 900_000;
     pub const SubtensorInitialDefaultTake: u16 = 11_796; // 18% honest number.
-    pub const SubtensorInitialMinTake: u16 = 0;
+    pub const SubtensorInitialMinTake: u16 = 11_796; // 18%, no change is allowed initially
     pub const SubtensorInitialWeightsVersionKey: u64 = 0;
     pub const SubtensorInitialMinDifficulty: u64 = 10_000_000;
     pub const SubtensorInitialMaxDifficulty: u64 = u64::MAX / 4;