Fix TX-extension type definition

Author: ales-otf

node/Cargo.toml

@@ -70,6 +70,7 @@ frame-system.workspace = true
 pallet-transaction-payment.workspace = true
 pallet-commitments.workspace = true
 pallet-drand.workspace = true
+pallet-rate-limiting.workspace = true
 sp-crypto-ec-utils = { workspace = true, default-features = true, features = [
 	"bls12-381",
 ] }
@@ -173,6 +174,7 @@ runtime-benchmarks = [
 	"polkadot-sdk/runtime-benchmarks",
 	"pallet-subtensor/runtime-benchmarks",
 	"pallet-shield/runtime-benchmarks",
+	"pallet-rate-limiting/runtime-benchmarks",
 ]
 
 pow-faucet = []

node/src/benchmarking.rs

@@ -143,8 +143,12 @@ pub fn create_benchmark_extrinsic(
             pallet_subtensor::transaction_extension::SubtensorTransactionExtension::<
                 runtime::Runtime,
             >::new(),
-            pallet_drand::drand_priority::DrandPriority::<runtime::Runtime>::new(),
-            frame_metadata_hash_extension::CheckMetadataHash::<runtime::Runtime>::new(true),
+            // Keep the same order while staying under the 12-item tuple limit.
+            (
+                pallet_drand::drand_priority::DrandPriority::<runtime::Runtime>::new(),
+                frame_metadata_hash_extension::CheckMetadataHash::<runtime::Runtime>::new(true),
+            ),
+            pallet_rate_limiting::RateLimitTransactionExtension::<runtime::Runtime>::new(),
         );
 
     let raw_payload = runtime::SignedPayload::from_raw(

node/src/mev_shield/author.rs

@@ -396,8 +396,12 @@ where
             pallet_subtensor::transaction_extension::SubtensorTransactionExtension::<
                 runtime::Runtime,
             >::new(),
-            pallet_drand::drand_priority::DrandPriority::<runtime::Runtime>::new(),
-            frame_metadata_hash_extension::CheckMetadataHash::<runtime::Runtime>::new(false),
+            // Keep the same order while staying under the 12-item tuple limit.
+            (
+                pallet_drand::drand_priority::DrandPriority::<runtime::Runtime>::new(),
+                frame_metadata_hash_extension::CheckMetadataHash::<runtime::Runtime>::new(false),
+            ),
+            pallet_rate_limiting::RateLimitTransactionExtension::<runtime::Runtime>::new(),
         );
 
     // 3) Manually construct the `Implicit` tuple that the runtime will also derive.
@@ -431,8 +435,12 @@ where
         (),           // ChargeTransactionPaymentWrapper::Implicit = ()
         (),           // SudoTransactionExtension::Implicit = ()
         (),           // SubtensorTransactionExtension::Implicit = ()
-        (),           // DrandPriority::Implicit = ()
-        None,         // CheckMetadataHash::Implicit = Option<[u8; 32]>
+        // Match the nested tuple shape used by TransactionExtensions.
+        (
+            (),   // DrandPriority::Implicit = ()
+            None, // CheckMetadataHash::Implicit = Option<[u8; 32]>
+        ),
+        (), // RateLimitTransactionExtension::Implicit = ()
     );
 
     // 4) Build the exact signable payload from call + extra + implicit.

pallets/admin-utils/src/benchmarking.rs

@@ -73,8 +73,8 @@ mod benchmarks {
             #[allow(deprecated)]
             let _ = AdminUtils::<T>::sudo_set_serving_rate_limit(
                 RawOrigin::Root.into(),
-                1u16.into(),  /*netuid*/
-                100u64,       /*serving_rate_limit*/
+                1u16.into(), /*netuid*/
+                100u64,      /*serving_rate_limit*/
             );
         }
     }

runtime/src/lib.rs

@@ -175,15 +175,17 @@ impl frame_system::offchain::CreateSignedTransaction<pallet_drand::Call<Runtime>
             frame_system::CheckEra::<Runtime>::from(Era::Immortal),
             check_nonce::CheckNonce::<Runtime>::from(nonce).into(),
             frame_system::CheckWeight::<Runtime>::new(),
-            pallet_rate_limiting::RateLimitTransactionExtension::<Runtime>::new(),
             ChargeTransactionPaymentWrapper::new(
                 pallet_transaction_payment::ChargeTransactionPayment::<Runtime>::from(0),
             ),
             SudoTransactionExtension::<Runtime>::new(),
             pallet_subtensor::transaction_extension::SubtensorTransactionExtension::<Runtime>::new(
             ),
-            pallet_drand::drand_priority::DrandPriority::<Runtime>::new(),
-            frame_metadata_hash_extension::CheckMetadataHash::<Runtime>::new(true),
+            (
+                pallet_drand::drand_priority::DrandPriority::<Runtime>::new(),
+                frame_metadata_hash_extension::CheckMetadataHash::<Runtime>::new(true),
+            ),
+            pallet_rate_limiting::RateLimitTransactionExtension::<Runtime>::new(),
         );
 
         let raw_payload = SignedPayload::new(call.clone(), extra.clone()).ok()?;
@@ -1679,6 +1681,8 @@ pub type Header = generic::Header<BlockNumber, BlakeTwo256>;
 // Block type as expected by this runtime.
 pub type Block = generic::Block<Header, UncheckedExtrinsic>;
 // The extensions to the basic transaction logic.
+// Note: The SDK only implements TransactionExtension for tuples up to 12 items, so we nest the last
+// two extensions to keep order/encoding while staying under the limit.
 pub type TransactionExtensions = (
     frame_system::CheckNonZeroSender<Runtime>,
     frame_system::CheckSpecVersion<Runtime>,
@@ -1691,8 +1695,11 @@ pub type TransactionExtensions = (
     ChargeTransactionPaymentWrapper<Runtime>,
     SudoTransactionExtension<Runtime>,
     pallet_subtensor::transaction_extension::SubtensorTransactionExtension<Runtime>,
-    pallet_drand::drand_priority::DrandPriority<Runtime>,
-    frame_metadata_hash_extension::CheckMetadataHash<Runtime>,
+    (
+        pallet_drand::drand_priority::DrandPriority<Runtime>,
+        frame_metadata_hash_extension::CheckMetadataHash<Runtime>,
+    ),
+    pallet_rate_limiting::RateLimitTransactionExtension<Runtime>,
 );
 
 type Migrations = (