Fix rao migration did not update TotalIssuance

Author: ales-otf

pallets/subtensor/src/migrations/migrate_init_total_issuance.rs

@@ -1,6 +1,6 @@
 use super::*;
-use frame_support::pallet_prelude::OptionQuery;
-use frame_support::{pallet_prelude::Identity, storage_alias};
+use frame_support::pallet_prelude::{Identity, OptionQuery, Weight};
+use frame_support::storage_alias;
 use sp_std::vec::Vec;
 
 // TODO: Implement comprehensive tests for this migration
@@ -14,6 +14,43 @@ pub mod deprecated_loaded_emission_format {
         StorageMap<Pallet<T>, Identity, u16, Vec<(AccountIdOf<T>, u64)>, OptionQuery>;
 }
 
+pub(crate) fn migrate_init_total_issuance<T: Config>() -> Weight {
+    // Calculate the total locked tokens across all subnets
+    let subnets_len = crate::SubnetLocked::<T>::iter().count() as u64;
+    let total_subnet_locked: u64 =
+        crate::SubnetLocked::<T>::iter().fold(0, |acc, (_, v)| acc.saturating_add(v));
+
+    // Retrieve the total balance of all accounts
+    let total_account_balances = <<T as crate::Config>::Currency as fungible::Inspect<
+        <T as frame_system::Config>::AccountId,
+    >>::total_issuance();
+
+    // Get the total stake from the system
+    let total_stake = crate::TotalStake::<T>::get();
+
+    // Retrieve the previous total issuance for logging purposes
+    let prev_total_issuance = crate::TotalIssuance::<T>::get();
+
+    // Calculate the new total issuance
+    let new_total_issuance = total_account_balances
+        .saturating_add(total_stake)
+        .saturating_add(total_subnet_locked);
+
+    // Update the total issuance in storage
+    crate::TotalIssuance::<T>::put(new_total_issuance);
+
+    // Log the change in total issuance
+    log::info!(
+        "Subtensor Pallet Total Issuance Updated: previous: {:?}, new: {:?}",
+        prev_total_issuance,
+        new_total_issuance
+    );
+
+    // Return the weight of the operation
+    // We performed subnets_len + 5 reads and 1 write
+    <T as frame_system::Config>::DbWeight::get().reads_writes(subnets_len.saturating_add(5), 1)
+}
+
 pub mod initialise_total_issuance {
     use frame_support::pallet_prelude::Weight;
     use frame_support::traits::{fungible, OnRuntimeUpgrade};
@@ -33,41 +70,7 @@ pub mod initialise_total_issuance {
         ///
         /// Returns the weight of the migration operation.
         fn on_runtime_upgrade() -> Weight {
-            // Calculate the total locked tokens across all subnets
-            let subnets_len = crate::SubnetLocked::<T>::iter().count() as u64;
-            let total_subnet_locked: u64 =
-                crate::SubnetLocked::<T>::iter().fold(0, |acc, (_, v)| acc.saturating_add(v));
-
-            // Retrieve the total balance of all accounts
-            let total_account_balances = <<T as crate::Config>::Currency as fungible::Inspect<
-                <T as frame_system::Config>::AccountId,
-            >>::total_issuance();
-
-            // Get the total stake from the system
-            let total_stake = crate::TotalStake::<T>::get();
-
-            // Retrieve the previous total issuance for logging purposes
-            let prev_total_issuance = crate::TotalIssuance::<T>::get();
-
-            // Calculate the new total issuance
-            let new_total_issuance = total_account_balances
-                .saturating_add(total_stake)
-                .saturating_add(total_subnet_locked);
-
-            // Update the total issuance in storage
-            crate::TotalIssuance::<T>::put(new_total_issuance);
-
-            // Log the change in total issuance
-            log::info!(
-                "Subtensor Pallet Total Issuance Updated: previous: {:?}, new: {:?}",
-                prev_total_issuance,
-                new_total_issuance
-            );
-
-            // Return the weight of the operation
-            // We performed subnets_len + 5 reads and 1 write
-            <T as frame_system::Config>::DbWeight::get()
-                .reads_writes(subnets_len.saturating_add(5), 1)
+            super::migrate_init_total_issuance::<T>()
         }
 
         /// Performs post-upgrade checks to ensure the migration was successful.

pallets/subtensor/src/migrations/migrate_rao.rs

@@ -1,11 +1,13 @@
-use super::*;
 use alloc::string::String;
+
 use frame_support::IterableStorageMap;
 use frame_support::{traits::Get, weights::Weight};
-use log;
 use sp_runtime::format;
 use substrate_fixed::types::U64F64;
 
+use super::*;
+use crate::subnets::subnet::POOL_INITIAL_TAO;
+
 pub fn migrate_rao<T: Config>() -> Weight {
     let migration_name = b"migrate_rao".to_vec();
 
@@ -69,12 +71,12 @@ pub fn migrate_rao<T: Config>() -> Weight {
             TokenSymbol::<T>::insert(netuid, Pallet::<T>::get_symbol_for_subnet(0));
             continue;
         }
-        let owner: T::AccountId = SubnetOwner::<T>::get(netuid);
-        let lock: u64 = SubnetLocked::<T>::get(netuid);
+        let owner = SubnetOwner::<T>::get(netuid);
+        let lock = SubnetLocked::<T>::get(netuid);
 
         // Put initial TAO from lock into subnet TAO and produce numerically equal amount of Alpha
         // The initial TAO is the locked amount, with a minimum of 1 RAO and a cap of 100 TAO.
-        let pool_initial_tao = 100_000_000_000.min(lock.max(1));
+        let pool_initial_tao = POOL_INITIAL_TAO.min(lock.max(1));
 
         let remaining_lock = lock.saturating_sub(pool_initial_tao);
         // Refund the owner for the remaining lock.
@@ -127,6 +129,10 @@ pub fn migrate_rao<T: Config>() -> Weight {
         // TargetStakesPerInterval::<T>::put(10); (DEPRECATED)
     }
 
+    // update `TotalIssuance`, because currency issuance (`T::Currency`) has changed due to lock
+    // refunds above
+    weight = weight.saturating_add(migrate_init_total_issuance::migrate_init_total_issuance::<T>());
+
     // Mark the migration as completed
     HasMigrationRun::<T>::insert(&migration_name, true);
     weight = weight.saturating_add(T::DbWeight::get().writes(1));

scripts/try-runtime-upgrade.sh

@@ -49,7 +49,7 @@ do_try_runtime() {
   fi
 
   eval "try-runtime --runtime $runtime_wasm_path on-runtime-upgrade \
-    --no-weight-warnings --disable-spec-version-check --disable-idempotency-checks \
+    --no-weight-warnings --disable-spec-version-check --disable-idempotency-checks --checks=all \
     $chain_state"
 }