Skip to content

Global subsidies based on ema prices #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: devnet-ready
Choose a base branch
from
Open

Global subsidies based on ema prices #2140

wants to merge 6 commits into from
+103 −18

Conversation

gztensor
Copy link
Contributor

Description

No root sell when EMA prices sum up to lower than 1.0.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Oct 16, 2025
@gztensor gztensor marked this pull request as draft October 16, 2025 17:06
@gztensor gztensor marked this pull request as ready for review October 16, 2025 17:12
camfairchild
camfairchild previously approved these changes Oct 16, 2025
View reviewed changes
camfairchild
camfairchild reviewed Oct 16, 2025
View reviewed changes
pallets/subtensor/src/tests/coinbase.rs
// Prices are low => we limit tao issued (buy alpha with it)
let tao_issued = TaoCurrency::from(((0.1 + 0.2) * emission as f64) as u64);
assert_abs_diff_eq!(
TotalIssuance::<Test>::get(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issuance should increase by the full emission, no? We should still be emitting the same amount of TAO. It's just where it goes that is different.

@gztensor gztensor marked this pull request as draft October 16, 2025 20:04
@gztensor gztensor marked this pull request as ready for review October 17, 2025 20:48
camfairchild
camfairchild previously approved these changes Oct 17, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

@camfairchild camfairchild camfairchild left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gztensor @sam0x17 @camfairchild